[jira] [Commented] (YARN-3497) ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy
[ https://issues.apache.org/jira/browse/YARN-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505131#comment-14505131 ] Hudson commented on YARN-3497: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2120 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2120/]) YARN-3497. ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy. Contributed by Jason Lowe (jianhe: rev f967fd2f21791c5c4a5a090cc14ee88d155d2e2b) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/ContainerManagementProtocolProxy.java * hadoop-yarn-project/CHANGES.txt > ContainerManagementProtocolProxy modifies IPC timeout conf without making a > copy > > > Key: YARN-3497 > URL: https://issues.apache.org/jira/browse/YARN-3497 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 2.6.0 >Reporter: Jason Lowe >Assignee: Jason Lowe > Fix For: 2.7.1 > > Attachments: YARN-3497.001.patch, YARN-3497.002.patch > > > yarn-client's ContainerManagementProtocolProxy is updating > ipc.client.connection.maxidletime in the conf passed in without making a copy > of it. That modification "leaks" into other systems using the same conf and > can cause them to setup RPC connections with a timeout of zero as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3497) ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy
[ https://issues.apache.org/jira/browse/YARN-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505079#comment-14505079 ] Hudson commented on YARN-3497: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #171 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/171/]) YARN-3497. ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy. Contributed by Jason Lowe (jianhe: rev f967fd2f21791c5c4a5a090cc14ee88d155d2e2b) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/ContainerManagementProtocolProxy.java * hadoop-yarn-project/CHANGES.txt > ContainerManagementProtocolProxy modifies IPC timeout conf without making a > copy > > > Key: YARN-3497 > URL: https://issues.apache.org/jira/browse/YARN-3497 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 2.6.0 >Reporter: Jason Lowe >Assignee: Jason Lowe > Fix For: 2.7.1 > > Attachments: YARN-3497.001.patch, YARN-3497.002.patch > > > yarn-client's ContainerManagementProtocolProxy is updating > ipc.client.connection.maxidletime in the conf passed in without making a copy > of it. That modification "leaks" into other systems using the same conf and > can cause them to setup RPC connections with a timeout of zero as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3497) ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy
[ https://issues.apache.org/jira/browse/YARN-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504815#comment-14504815 ] Hudson commented on YARN-3497: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #161 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/161/]) YARN-3497. ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy. Contributed by Jason Lowe (jianhe: rev f967fd2f21791c5c4a5a090cc14ee88d155d2e2b) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/ContainerManagementProtocolProxy.java > ContainerManagementProtocolProxy modifies IPC timeout conf without making a > copy > > > Key: YARN-3497 > URL: https://issues.apache.org/jira/browse/YARN-3497 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 2.6.0 >Reporter: Jason Lowe >Assignee: Jason Lowe > Fix For: 2.7.1 > > Attachments: YARN-3497.001.patch, YARN-3497.002.patch > > > yarn-client's ContainerManagementProtocolProxy is updating > ipc.client.connection.maxidletime in the conf passed in without making a copy > of it. That modification "leaks" into other systems using the same conf and > can cause them to setup RPC connections with a timeout of zero as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3497) ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy
[ https://issues.apache.org/jira/browse/YARN-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504808#comment-14504808 ] Hudson commented on YARN-3497: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2102 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2102/]) YARN-3497. ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy. Contributed by Jason Lowe (jianhe: rev f967fd2f21791c5c4a5a090cc14ee88d155d2e2b) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/ContainerManagementProtocolProxy.java * hadoop-yarn-project/CHANGES.txt > ContainerManagementProtocolProxy modifies IPC timeout conf without making a > copy > > > Key: YARN-3497 > URL: https://issues.apache.org/jira/browse/YARN-3497 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 2.6.0 >Reporter: Jason Lowe >Assignee: Jason Lowe > Fix For: 2.7.1 > > Attachments: YARN-3497.001.patch, YARN-3497.002.patch > > > yarn-client's ContainerManagementProtocolProxy is updating > ipc.client.connection.maxidletime in the conf passed in without making a copy > of it. That modification "leaks" into other systems using the same conf and > can cause them to setup RPC connections with a timeout of zero as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3497) ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy
[ https://issues.apache.org/jira/browse/YARN-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504755#comment-14504755 ] Hudson commented on YARN-3497: -- FAILURE: Integrated in Hadoop-Yarn-trunk #904 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/904/]) YARN-3497. ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy. Contributed by Jason Lowe (jianhe: rev f967fd2f21791c5c4a5a090cc14ee88d155d2e2b) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/ContainerManagementProtocolProxy.java > ContainerManagementProtocolProxy modifies IPC timeout conf without making a > copy > > > Key: YARN-3497 > URL: https://issues.apache.org/jira/browse/YARN-3497 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 2.6.0 >Reporter: Jason Lowe >Assignee: Jason Lowe > Fix For: 2.7.1 > > Attachments: YARN-3497.001.patch, YARN-3497.002.patch > > > yarn-client's ContainerManagementProtocolProxy is updating > ipc.client.connection.maxidletime in the conf passed in without making a copy > of it. That modification "leaks" into other systems using the same conf and > can cause them to setup RPC connections with a timeout of zero as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3497) ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy
[ https://issues.apache.org/jira/browse/YARN-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504748#comment-14504748 ] Hudson commented on YARN-3497: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #170 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/170/]) YARN-3497. ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy. Contributed by Jason Lowe (jianhe: rev f967fd2f21791c5c4a5a090cc14ee88d155d2e2b) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/ContainerManagementProtocolProxy.java > ContainerManagementProtocolProxy modifies IPC timeout conf without making a > copy > > > Key: YARN-3497 > URL: https://issues.apache.org/jira/browse/YARN-3497 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 2.6.0 >Reporter: Jason Lowe >Assignee: Jason Lowe > Fix For: 2.7.1 > > Attachments: YARN-3497.001.patch, YARN-3497.002.patch > > > yarn-client's ContainerManagementProtocolProxy is updating > ipc.client.connection.maxidletime in the conf passed in without making a copy > of it. That modification "leaks" into other systems using the same conf and > can cause them to setup RPC connections with a timeout of zero as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3497) ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy
[ https://issues.apache.org/jira/browse/YARN-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503283#comment-14503283 ] Hudson commented on YARN-3497: -- FAILURE: Integrated in Hadoop-trunk-Commit #7617 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7617/]) YARN-3497. ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy. Contributed by Jason Lowe (jianhe: rev f967fd2f21791c5c4a5a090cc14ee88d155d2e2b) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/ContainerManagementProtocolProxy.java > ContainerManagementProtocolProxy modifies IPC timeout conf without making a > copy > > > Key: YARN-3497 > URL: https://issues.apache.org/jira/browse/YARN-3497 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 2.6.0 >Reporter: Jason Lowe >Assignee: Jason Lowe > Fix For: 2.7.1 > > Attachments: YARN-3497.001.patch, YARN-3497.002.patch > > > yarn-client's ContainerManagementProtocolProxy is updating > ipc.client.connection.maxidletime in the conf passed in without making a copy > of it. That modification "leaks" into other systems using the same conf and > can cause them to setup RPC connections with a timeout of zero as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3497) ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy
[ https://issues.apache.org/jira/browse/YARN-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503265#comment-14503265 ] Jian He commented on YARN-3497: --- looks good , + 1 > ContainerManagementProtocolProxy modifies IPC timeout conf without making a > copy > > > Key: YARN-3497 > URL: https://issues.apache.org/jira/browse/YARN-3497 > Project: Hadoop YARN > Issue Type: Bug > Components: client >Affects Versions: 2.6.0 >Reporter: Jason Lowe >Assignee: Jason Lowe > Attachments: YARN-3497.001.patch, YARN-3497.002.patch > > > yarn-client's ContainerManagementProtocolProxy is updating > ipc.client.connection.maxidletime in the conf passed in without making a copy > of it. That modification "leaks" into other systems using the same conf and > can cause them to setup RPC connections with a timeout of zero as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3497) ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy
[
https://issues.apache.org/jira/browse/YARN-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503019#comment-14503019
]
Hadoop QA commented on YARN-3497:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12726573/YARN-3497.002.patch
against trunk revision c17cd4f.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/7397//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7397//console
This message is automatically generated.
> ContainerManagementProtocolProxy modifies IPC timeout conf without making a
> copy
>
>
> Key: YARN-3497
> URL: https://issues.apache.org/jira/browse/YARN-3497
> Project: Hadoop YARN
> Issue Type: Bug
> Components: client
>Affects Versions: 2.6.0
>Reporter: Jason Lowe
>Assignee: Jason Lowe
> Attachments: YARN-3497.001.patch, YARN-3497.002.patch
>
>
> yarn-client's ContainerManagementProtocolProxy is updating
> ipc.client.connection.maxidletime in the conf passed in without making a copy
> of it. That modification "leaks" into other systems using the same conf and
> can cause them to setup RPC connections with a timeout of zero as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3497) ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy
[
https://issues.apache.org/jira/browse/YARN-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500873#comment-14500873
]
Jian He commented on YARN-3497:
---
should we change below to use this.conf as well ?
{code}
conf.setInt(
CommonConfigurationKeysPublic.IPC_CLIENT_CONNECTION_MAXIDLETIME_KEY,
0);
{code}
> ContainerManagementProtocolProxy modifies IPC timeout conf without making a
> copy
>
>
> Key: YARN-3497
> URL: https://issues.apache.org/jira/browse/YARN-3497
> Project: Hadoop YARN
> Issue Type: Bug
> Components: client
>Affects Versions: 2.6.0
>Reporter: Jason Lowe
>Assignee: Jason Lowe
> Attachments: YARN-3497.001.patch
>
>
> yarn-client's ContainerManagementProtocolProxy is updating
> ipc.client.connection.maxidletime in the conf passed in without making a copy
> of it. That modification "leaks" into other systems using the same conf and
> can cause them to setup RPC connections with a timeout of zero as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3497) ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy
[
https://issues.apache.org/jira/browse/YARN-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498486#comment-14498486
]
Hadoop QA commented on YARN-3497:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12725933/YARN-3497.001.patch
against trunk revision 1fa8075.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/7362//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7362//console
This message is automatically generated.
> ContainerManagementProtocolProxy modifies IPC timeout conf without making a
> copy
>
>
> Key: YARN-3497
> URL: https://issues.apache.org/jira/browse/YARN-3497
> Project: Hadoop YARN
> Issue Type: Bug
> Components: client
>Affects Versions: 2.6.0
>Reporter: Jason Lowe
>Assignee: Jason Lowe
> Attachments: YARN-3497.001.patch
>
>
> yarn-client's ContainerManagementProtocolProxy is updating
> ipc.client.connection.maxidletime in the conf passed in without making a copy
> of it. That modification "leaks" into other systems using the same conf and
> can cause them to setup RPC connections with a timeout of zero as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
