[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987168#comment-15987168 ] Junping Du commented on YARN-3573: -- I too agree it is better to use config rather than constructor parameter. My previous concern is just we remove it too quickly just like what we did in YARN-5007. Given YARN-5007 is already reverted, I agree we can keep it is. > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0, 3.0.0-alpha1 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982744#comment-15982744 ] Brahma Reddy Battula commented on YARN-3573: I too agree with [~boky01] ( [comment here|https://issues.apache.org/jira/browse/YARN-5007?focusedCommentId=15982680=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15982680] ).we should mark as Depecrated,as it's better to use from config instead of ctor param. > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0, 3.0.0-alpha1 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982086#comment-15982086 ] Junping Du commented on YARN-3573: -- I still doubt the necessary of this deprecation especially I learnt from TEZ-3694 where we build Tez against Hadoop 3. The constructor could be widely used by downstream projects and deprecation on these methods doesn't make sense unless we have significant gains here. > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0, 3.0.0-alpha1 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260972#comment-15260972 ] Andras Bokor commented on YARN-3573: [~brahmareddy] Thanks for getting back to me. I meant MiniYARNCluster not MiniMRYarnCluster. Actually what I see is that through the other constructors we call the deprecated constructor. So finally we cannot avoid to call a deprecated method. It can be confusing at first time. Is it considered to remove? > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260649#comment-15260649 ] Brahma Reddy Battula commented on YARN-3573: *Earlier:* {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} *Now:* {code}MiniMRYarnCluster(String testName, int noOfNMs){code} timelineserver startup wiil be based on the config value instead passing as Boolean param.. Please refer YARN-2890 for more details...Hope this helps.. > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260263#comment-15260263 ] Andras Bokor commented on YARN-3573: Anybody who can help me? > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256295#comment-15256295 ] Andras Bokor commented on YARN-3573: Hi All, I run into this JIRA. I do not really understand the purpose of this fix. If the constructor is deprecated what is the preferred way to create a MiniYARNCluster object? > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975798#comment-14975798 ] Hudson commented on YARN-3573: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #601 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/601/]) YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) * hadoop-yarn-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975858#comment-14975858 ] Hudson commented on YARN-3573: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #541 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/541/]) YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java * hadoop-yarn-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975929#comment-14975929 ] Hudson commented on YARN-3573: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2479 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2479/]) YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java * hadoop-yarn-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975900#comment-14975900 ] Hudson commented on YARN-3573: -- FAILURE: Integrated in Hadoop-Yarn-trunk #1325 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1325/]) YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java * hadoop-yarn-project/CHANGES.txt > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976095#comment-14976095 ] Hudson commented on YARN-3573: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2532 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2532/]) YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java * hadoop-yarn-project/CHANGES.txt > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975783#comment-14975783 ] Hudson commented on YARN-3573: -- FAILURE: Integrated in Hadoop-trunk-Commit #8712 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8712/]) YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) * hadoop-yarn-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14973987#comment-14973987 ] Tsuyoshi Ozawa commented on YARN-3573: -- Kicking Jenkins. > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975563#comment-14975563 ] Tsuyoshi Ozawa commented on YARN-3573: -- Is the problem I mentioned same to MAPREDUCE-6525? > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975608#comment-14975608 ] Brahma Reddy Battula commented on YARN-3573: Yes, it is same.It's not related to this jira. > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975614#comment-14975614 ] Tsuyoshi Ozawa commented on YARN-3573: -- Make sense. +1, checking this in. > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975562#comment-14975562 ] Tsuyoshi Ozawa commented on YARN-3573: -- [~brahmareddy] I think one of the test failures are related. Could you fix it? {quote} TestMiniMRClientCluster.testRestart:146 Address before restart: asf909.gq1.ygridcore.net:0 is different from new address: asf909.gq1.ygridcore.net:48695 expected:<...9.gq1.ygridcore.net:[0]> but was:<...9.gq1.ygridcore.net:[48695]> {quote} > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975779#comment-14975779 ] Hudson commented on YARN-3573: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #589 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/589/]) YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java * hadoop-yarn-project/CHANGES.txt > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Fix For: 2.8.0 > > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14974155#comment-14974155 ] Hadoop QA commented on YARN-3573: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 7m 53s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 2 new or modified test files. | | {color:red}-1{color} | javac | 8m 58s | The applied patch generated 4 additional warning messages. | | {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 1m 3s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 37s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 35s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 43s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:red}-1{color} | mapreduce tests | 105m 51s | Tests failed in hadoop-mapreduce-client-jobclient. | | {color:green}+1{color} | yarn tests | 2m 24s | Tests passed in hadoop-yarn-server-tests. | | | | 130m 30s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.mapred.TestMiniMRClientCluster | | | hadoop.mapreduce.v2.TestMRAMWithNonNormalizedCapabilities | | | hadoop.mapreduce.TestMapReduceLazyOutput | | | hadoop.mapreduce.v2.TestNonExistentJob | | | hadoop.mapreduce.v2.TestMRAppWithCombiner | | | hadoop.mapreduce.v2.TestUberAM | | | hadoop.mapreduce.v2.TestMRJobsWithHistoryService | | Timed out tests | org.apache.hadoop.mapreduce.v2.TestMRJobs | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12751672/YARN-3573-002.patch | | Optional Tests | javac unit findbugs checkstyle | | git revision | trunk / 5acdde4 | | javac | https://builds.apache.org/job/PreCommit-YARN-Build/9574/artifact/patchprocess/diffJavacWarnings.txt | | hadoop-mapreduce-client-jobclient test log | https://builds.apache.org/job/PreCommit-YARN-Build/9574/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt | | hadoop-yarn-server-tests test log | https://builds.apache.org/job/PreCommit-YARN-Build/9574/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/9574/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/9574/console | This message was automatically generated. > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14974223#comment-14974223 ] Brahma Reddy Battula commented on YARN-3573: Testcase failures are unrelated.. I had seen ,these are failing in [pre-commit builds | https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/578/]..[~ozawa] kindly review.. > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3573) MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated
[ https://issues.apache.org/jira/browse/YARN-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968801#comment-14968801 ] Tsuyoshi Ozawa commented on YARN-3573: -- LGTM, pending for Jenkins. > MiniMRYarnCluster constructor that starts the timeline server using a boolean > should be marked deprecated > - > > Key: YARN-3573 > URL: https://issues.apache.org/jira/browse/YARN-3573 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver >Affects Versions: 2.6.0 >Reporter: Mit Desai >Assignee: Brahma Reddy Battula > Attachments: YARN-3573-002.patch, YARN-3573.patch > > > {code}MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS){code} > starts the timeline server using *boolean enableAHS*. It is better to have > the timelineserver started based on the config value. > We should mark this constructor as deprecated to avoid its future use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)