[jira] [Commented] (YARN-3593) Modifications in Node Labels Page for Partitions
[ https://issues.apache.org/jira/browse/YARN-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535267#comment-14535267 ] Wangda Tan commented on YARN-3593: -- Hmm.. reconsidered this, it may be strange to show a node's label is if user doesn't add anything to the node. So let's keep it as is, we may not need to change RM node's page. Committing this ticket. > Modifications in Node Labels Page for Partitions > > > Key: YARN-3593 > URL: https://issues.apache.org/jira/browse/YARN-3593 > Project: Hadoop YARN > Issue Type: Sub-task > Components: webapp >Affects Versions: 2.6.0, 2.7.0 >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Attachments: NodeLabelsPageModifications.png, > YARN-3593.20150507-1.patch > > > Need to support displaying the label type in Node Labels page and also > instead of we need to show as -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3593) Modifications in Node Labels Page for Partitions
[ https://issues.apache.org/jira/browse/YARN-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535254#comment-14535254 ] Naganarasimha G R commented on YARN-3593: - Hi [~wangda] Thanks for the review and good point but RMNodeImpl.getNodeLabels which is used to get labels for the node in the UI will return empty list when node doesn't have any label or when node label is disabled. So in that case will be displayed even when node label is disabled, is that fine ? > Modifications in Node Labels Page for Partitions > > > Key: YARN-3593 > URL: https://issues.apache.org/jira/browse/YARN-3593 > Project: Hadoop YARN > Issue Type: Sub-task > Components: webapp >Affects Versions: 2.6.0, 2.7.0 >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Attachments: NodeLabelsPageModifications.png, > YARN-3593.20150507-1.patch > > > Need to support displaying the label type in Node Labels page and also > instead of we need to show as -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3593) Modifications in Node Labels Page for Partitions
[ https://issues.apache.org/jira/browse/YARN-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535056#comment-14535056 ] Wangda Tan commented on YARN-3593: -- [~Naganarasimha], Looks good generally, Do you think we should make RM Nodes page consistent with this? when a node has no label, it should be instead of empty when label is enabled? > Modifications in Node Labels Page for Partitions > > > Key: YARN-3593 > URL: https://issues.apache.org/jira/browse/YARN-3593 > Project: Hadoop YARN > Issue Type: Sub-task > Components: webapp >Affects Versions: 2.6.0, 2.7.0 >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Attachments: NodeLabelsPageModifications.png, > YARN-3593.20150507-1.patch > > > Need to support displaying the label type in Node Labels page and also > instead of we need to show as -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3593) Modifications in Node Labels Page for Partitions
[ https://issues.apache.org/jira/browse/YARN-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534283#comment-14534283 ] Naganarasimha G R commented on YARN-3593: - Hi [~wangda], Can you please take a look @ this. > Modifications in Node Labels Page for Partitions > > > Key: YARN-3593 > URL: https://issues.apache.org/jira/browse/YARN-3593 > Project: Hadoop YARN > Issue Type: Sub-task > Components: webapp >Affects Versions: 2.6.0, 2.7.0 >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Attachments: NodeLabelsPageModifications.png, > YARN-3593.20150507-1.patch > > > Need to support displaying the label type in Node Labels page and also > instead of we need to show as -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3593) Modifications in Node Labels Page for Partitions
[
https://issues.apache.org/jira/browse/YARN-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533234#comment-14533234
]
Hadoop QA commented on YARN-3593:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 39s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 32s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 33s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 45s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 16s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | yarn tests | 53m 40s | Tests passed in
hadoop-yarn-server-resourcemanager. |
| | | 89m 57s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12731228/YARN-3593.20150507-1.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / daf3e4e |
| hadoop-yarn-server-resourcemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/7769/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/7769/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/7769/console |
This message was automatically generated.
> Modifications in Node Labels Page for Partitions
>
>
> Key: YARN-3593
> URL: https://issues.apache.org/jira/browse/YARN-3593
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: webapp
>Affects Versions: 2.6.0, 2.7.0
>Reporter: Naganarasimha G R
>Assignee: Naganarasimha G R
> Attachments: NodeLabelsPageModifications.png,
> YARN-3593.20150507-1.patch
>
>
> Need to support displaying the label type in Node Labels page and also
> instead of we need to show as
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
