[jira] [Commented] (YARN-3732) Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract classes

2016-11-01 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625176#comment-15625176
 ] 

Hudson commented on YARN-3732:
--

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10742 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/10742/])
YARN-3732. Change NodeHeartbeatResponse.java and (rohithsharmaks: rev 
9d0c2ad5a5e3a93c8c48f66ab9b21756d42b645a)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/RegisterNodeManagerResponse.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/NodeHeartbeatResponse.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/RegisterNodeManagerResponsePBImpl.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NodeHeartbeatResponsePBImpl.java


> Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as 
> abstract classes
> --
>
> Key: YARN-3732
> URL: https://issues.apache.org/jira/browse/YARN-3732
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Devaraj K
>Assignee: Devaraj K
>Priority: Minor
> Fix For: 3.0.0-alpha2
>
> Attachments: YARN-3732-1.patch, YARN-3732-2.patch, YARN-3732.patch
>
>
> All the other protocol record classes are abstract classes. Change 
> NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract 
> classes to make it consistent with other protocol record classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-3732) Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract classes

2016-10-28 Thread Devaraj K (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616520#comment-15616520
 ] 

Devaraj K commented on YARN-3732:
-

Thanks [~rohithsharma] for the review and commit.

> Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as 
> abstract classes
> --
>
> Key: YARN-3732
> URL: https://issues.apache.org/jira/browse/YARN-3732
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Devaraj K
>Assignee: Devaraj K
>Priority: Minor
> Fix For: 3.0.0-alpha2
>
> Attachments: YARN-3732-1.patch, YARN-3732-2.patch, YARN-3732.patch
>
>
> All the other protocol record classes are abstract classes. Change 
> NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract 
> classes to make it consistent with other protocol record classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-3732) Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract classes

2016-10-27 Thread Devaraj K (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614197#comment-15614197
 ] 

Devaraj K commented on YARN-3732:
-

ASF License warnings are not related to the patch.

> Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as 
> abstract classes
> --
>
> Key: YARN-3732
> URL: https://issues.apache.org/jira/browse/YARN-3732
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Devaraj K
>Assignee: Devaraj K
>Priority: Minor
> Attachments: YARN-3732-1.patch, YARN-3732-2.patch, YARN-3732.patch
>
>
> All the other protocol record classes are abstract classes. Change 
> NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract 
> classes to make it consistent with other protocol record classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-3732) Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract classes

2016-10-27 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613860#comment-15613860
 ] 

Hadoop QA commented on YARN-3732:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
15s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
40s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: 
The patch generated 0 new + 34 unchanged - 13 fixed = 34 total (was 47) {color} 
|
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
28s{color} | {color:green} hadoop-yarn-server-common in the patch passed. 
{color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 15m  
5s{color} | {color:red} The patch generated 4 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 39s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Issue | YARN-3732 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12835704/YARN-3732-2.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux f16cbb7889e5 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 
20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / 28660f5 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/13620/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-YARN-Build/13620/artifact/patchprocess/patch-asflicense-problems.txt
 |
| modules | C: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/13620/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as 
> abstract classes
> 

[jira] [Commented] (YARN-3732) Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract classes

2016-10-27 Thread Devaraj K (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611093#comment-15611093
 ] 

Devaraj K commented on YARN-3732:
-

Thanks [~rohithsharma] for checking this, will update the patch for the trunk.

> Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as 
> abstract classes
> --
>
> Key: YARN-3732
> URL: https://issues.apache.org/jira/browse/YARN-3732
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Devaraj K
>Assignee: Devaraj K
>Priority: Minor
> Attachments: YARN-3732-1.patch, YARN-3732.patch
>
>
> All the other protocol record classes are abstract classes. Change 
> NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract 
> classes to make it consistent with other protocol record classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-3732) Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract classes

2016-10-27 Thread Rohith Sharma K S (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611002#comment-15611002
 ] 

Rohith Sharma K S commented on YARN-3732:
-

One risk I see is rolling upgrade might fail, so I would prefer to go for trunk.

> Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as 
> abstract classes
> --
>
> Key: YARN-3732
> URL: https://issues.apache.org/jira/browse/YARN-3732
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Devaraj K
>Assignee: Devaraj K
>Priority: Minor
> Attachments: YARN-3732-1.patch, YARN-3732.patch
>
>
> All the other protocol record classes are abstract classes. Change 
> NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract 
> classes to make it consistent with other protocol record classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-3732) Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract classes

2016-10-27 Thread Rohith Sharma K S (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15610998#comment-15610998
 ] 

Rohith Sharma K S commented on YARN-3732:
-

+1 for changing it to abstract. Cancelling patch as it was one year old. 
[~devaraj.k] would you rebase the patch?

> Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as 
> abstract classes
> --
>
> Key: YARN-3732
> URL: https://issues.apache.org/jira/browse/YARN-3732
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Devaraj K
>Assignee: Devaraj K
>Priority: Minor
> Attachments: YARN-3732-1.patch, YARN-3732.patch
>
>
> All the other protocol record classes are abstract classes. Change 
> NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract 
> classes to make it consistent with other protocol record classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-3732) Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract classes

2015-05-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562681#comment-14562681
 ] 

Hadoop QA commented on YARN-3732:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 59s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   8m  4s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 50s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 33s | There were no new checkstyle 
issues. |
| {color:red}-1{color} | whitespace |   0m  1s | The patch has 2  line(s) that 
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   0m 52s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |   0m 25s | Tests passed in 
hadoop-yarn-server-common. |
| | |  37m 18s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12735838/YARN-3732.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 7e509f5 |
| whitespace | 
https://builds.apache.org/job/PreCommit-YARN-Build/8112/artifact/patchprocess/whitespace.txt
 |
| hadoop-yarn-server-common test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8112/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8112/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8112/console |


This message was automatically generated.

 Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as 
 abstract classes
 --

 Key: YARN-3732
 URL: https://issues.apache.org/jira/browse/YARN-3732
 Project: Hadoop YARN
  Issue Type: Improvement
Reporter: Devaraj K
Assignee: Devaraj K
Priority: Minor
 Attachments: YARN-3732.patch


 All the other protocol record classes are abstract classes. Change 
 NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract 
 classes to make it consistent with other protocol record classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3732) Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract classes

2015-05-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562824#comment-14562824
 ] 

Hadoop QA commented on YARN-3732:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  15m  2s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   7m 46s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 57s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 30s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  2s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   0m 52s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |   0m 25s | Tests passed in 
hadoop-yarn-server-common. |
| | |  37m 11s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12735852/YARN-3732-1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 7e509f5 |
| hadoop-yarn-server-common test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8113/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8113/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8113/console |


This message was automatically generated.

 Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as 
 abstract classes
 --

 Key: YARN-3732
 URL: https://issues.apache.org/jira/browse/YARN-3732
 Project: Hadoop YARN
  Issue Type: Improvement
Reporter: Devaraj K
Assignee: Devaraj K
Priority: Minor
 Attachments: YARN-3732-1.patch, YARN-3732.patch


 All the other protocol record classes are abstract classes. Change 
 NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract 
 classes to make it consistent with other protocol record classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)