[jira] [Commented] (YARN-3733) DominantRC#compare() does not work as expected if cluster resource is empty

[ https://issues.apache.org/jira/browse/YARN-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572247#comment-14572247 ] Rohith commented on YARN-3733: -- +1 for handling virtual core's. This will good immprovement fo

[jira] [Commented] (YARN-3733) DominantRC#compare() does not work as expected if cluster resource is empty

[ https://issues.apache.org/jira/browse/YARN-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572239#comment-14572239 ] Sunil G commented on YARN-3733: --- Patch looks good to me. +1 For MockRM.submitApp, I think we

[jira] [Commented] (YARN-3733) DominantRC#compare() does not work as expected if cluster resource is empty

[ https://issues.apache.org/jira/browse/YARN-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1457#comment-1457 ] Hadoop QA commented on YARN-3733: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3733) DominantRC#compare() does not work as expected if cluster resource is empty

[ https://issues.apache.org/jira/browse/YARN-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572085#comment-14572085 ] Rohith commented on YARN-3733: -- bq. only memory or vcores are more in TestCapacityScheduler. A

[jira] [Commented] (YARN-3733) DominantRC#compare() does not work as expected if cluster resource is empty

[ https://issues.apache.org/jira/browse/YARN-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14571658#comment-14571658 ] Wangda Tan commented on YARN-3733: -- Patch LGTM generally, will commit the patch once [~sun

[jira] [Commented] (YARN-3733) DominantRC#compare() does not work as expected if cluster resource is empty

[ https://issues.apache.org/jira/browse/YARN-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570950#comment-14570950 ] Hadoop QA commented on YARN-3733: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3733) DominantRC#compare() does not work as expected if cluster resource is empty

[ https://issues.apache.org/jira/browse/YARN-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570937#comment-14570937 ] Sunil G commented on YARN-3733: --- Thank you [~rohithsharma] for the detailed information and p

[jira] [Commented] (YARN-3733) DominantRC#compare() does not work as expected if cluster resource is empty

[ https://issues.apache.org/jira/browse/YARN-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570025#comment-14570025 ] Wangda Tan commented on YARN-3733: -- Took a look at the patch and discussion. Thanks for wo

[jira] [Commented] (YARN-3733) DominantRC#compare() does not work as expected if cluster resource is empty

[ https://issues.apache.org/jira/browse/YARN-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568913#comment-14568913 ] Hadoop QA commented on YARN-3733: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3733) DominantRC#compare() does not work as expected if cluster resource is empty

[ https://issues.apache.org/jira/browse/YARN-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568880#comment-14568880 ] Sunil G commented on YARN-3733: --- Hi [~rohithsharma] Thanks for the detailed scenario. Scenar

[jira] [Commented] (YARN-3733) DominantRC#compare() does not work as expected if cluster resource is empty

[ https://issues.apache.org/jira/browse/YARN-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568682#comment-14568682 ] Rohith commented on YARN-3733: -- Updated the summary as per defect. > DominantRC#compare() doe