[jira] [Commented] (YARN-3748) Cleanup Findbugs volatile warnings

2016-10-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613435#comment-15613435 ] Hadoop QA commented on YARN-3748: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-3748) Cleanup Findbugs volatile warnings

2015-06-22 Thread Gabor Liptak (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596936#comment-14596936 ] Gabor Liptak commented on YARN-3748: Any other changes needed before this can be

[jira] [Commented] (YARN-3748) Cleanup Findbugs volatile warnings

2015-06-06 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14576108#comment-14576108 ] Sean Busbey commented on YARN-3748: --- +1 v5 looks good. Cleanup Findbugs volatile

[jira] [Commented] (YARN-3748) Cleanup Findbugs volatile warnings

2015-06-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14575847#comment-14575847 ] Hadoop QA commented on YARN-3748: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3748) Cleanup Findbugs volatile warnings

2015-06-06 Thread Gabor Liptak (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14575863#comment-14575863 ] Gabor Liptak commented on YARN-3748: [~busbey] The tests did pass this time. Cleanup

[jira] [Commented] (YARN-3748) Cleanup Findbugs volatile warnings

2015-06-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14567506#comment-14567506 ] Hadoop QA commented on YARN-3748: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3748) Cleanup Findbugs volatile warnings

2015-06-01 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14567343#comment-14567343 ] Sean Busbey commented on YARN-3748: --- +1 lgtm, presuming that failed test passes locally.

[jira] [Commented] (YARN-3748) Cleanup Findbugs volatile warnings

2015-05-30 Thread Gabor Liptak (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566115#comment-14566115 ] Gabor Liptak commented on YARN-3748: [~busbey] Updated patch to make variables final.

[jira] [Commented] (YARN-3748) Cleanup Findbugs volatile warnings

2015-05-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566151#comment-14566151 ] Hadoop QA commented on YARN-3748: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3748) Cleanup Findbugs volatile warnings

2015-05-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566229#comment-14566229 ] Hadoop QA commented on YARN-3748: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3748) Cleanup Findbugs volatile warnings

2015-05-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565783#comment-14565783 ] Hadoop QA commented on YARN-3748: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3748) Cleanup Findbugs volatile warnings

2015-05-29 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565830#comment-14565830 ] Sean Busbey commented on YARN-3748: --- you should make the new AtomicFoo variables final.