[
https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613435#comment-15613435
]
Hadoop QA commented on YARN-3748:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596936#comment-14596936
]
Gabor Liptak commented on YARN-3748:
Any other changes needed before this can be consid
[
https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576108#comment-14576108
]
Sean Busbey commented on YARN-3748:
---
+1 v5 looks good.
> Cleanup Findbugs volatile warni
[
https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575863#comment-14575863
]
Gabor Liptak commented on YARN-3748:
[~busbey] The tests did pass this time.
> Cleanup
[
https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575847#comment-14575847
]
Hadoop QA commented on YARN-3748:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567506#comment-14567506
]
Hadoop QA commented on YARN-3748:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567343#comment-14567343
]
Sean Busbey commented on YARN-3748:
---
+1 lgtm, presuming that failed test passes locally.
[
https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566229#comment-14566229
]
Hadoop QA commented on YARN-3748:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566151#comment-14566151
]
Hadoop QA commented on YARN-3748:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566115#comment-14566115
]
Gabor Liptak commented on YARN-3748:
[~busbey] Updated patch to make variables final.
[
https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565830#comment-14565830
]
Sean Busbey commented on YARN-3748:
---
you should make the new AtomicFoo variables final.
[
https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565783#comment-14565783
]
Hadoop QA commented on YARN-3748:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
12 matches
Mail list logo