[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369778#comment-15369778
]
Hudson commented on YARN-3949:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[https
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642839#comment-14642839
]
Sangjin Lee commented on YARN-3949:
---
Thanks folks for reviewing and committing the patch!
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641386#comment-14641386
]
Hadoop QA commented on YARN-3949:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641380#comment-14641380
]
Joep Rottinghuis commented on YARN-3949:
LGTM.
Joep
> ensure timely flush of t
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641355#comment-14641355
]
Hadoop QA commented on YARN-3949:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641283#comment-14641283
]
Hadoop QA commented on YARN-3949:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641274#comment-14641274
]
Junping Du commented on YARN-3949:
--
+1. Latest patch LGTM. I will wait to tomorrow in case
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640974#comment-14640974
]
Sangjin Lee commented on YARN-3949:
---
For the hbase writer, {{flush()}} and {{close()}} (o
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640959#comment-14640959
]
Joep Rottinghuis commented on YARN-3949:
bq. On top of the current patch, how about
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640935#comment-14640935
]
Li Lu commented on YARN-3949:
-
bq. The current approach seems to be good now, I propose to go w
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640910#comment-14640910
]
Zhijie Shen commented on YARN-3949:
---
IMHO, given write + flush, it's not necessary to hav
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640799#comment-14640799
]
Junping Du commented on YARN-3949:
--
Thanks for your input, [~jrottinghuis]!
I agree the c
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640784#comment-14640784
]
Li Lu commented on YARN-3949:
-
On top of the current patch, how about have two simple write API
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640059#comment-14640059
]
Joep Rottinghuis commented on YARN-3949:
I think a simple write and separate flush
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639973#comment-14639973
]
Junping Du commented on YARN-3949:
--
Thanks [~sjlee0] for working out the patch! I have som
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639812#comment-14639812
]
Hadoop QA commented on YARN-3949:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639391#comment-14639391
]
Vrushali C commented on YARN-3949:
--
I think [~gtCarrera9] clarified my doubt.. thanks!
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639335#comment-14639335
]
Sangjin Lee commented on YARN-3949:
---
[~vrushalic], is your concern whether a service can
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639289#comment-14639289
]
Li Lu commented on YARN-3949:
-
I checked AbstractService and seems like it's not possible for a
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639264#comment-14639264
]
Li Lu commented on YARN-3949:
-
Hi [~sjlee0], thanks for the patch! I think the patch LGTM in ge
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639251#comment-14639251
]
Vrushali C commented on YARN-3949:
--
We are now setting the entityTable to null in the HBas
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639104#comment-14639104
]
Sangjin Lee commented on YARN-3949:
---
bq. One question about the buffer: if for some reaso
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638190#comment-14638190
]
Zhijie Shen commented on YARN-3949:
---
The proposal looks good to me for now. We may need t
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638040#comment-14638040
]
Sangjin Lee commented on YARN-3949:
---
The checkstyle issue is the file length issue with Y
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638031#comment-14638031
]
Hadoop QA commented on YARN-3949:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636056#comment-14636056
]
Sangjin Lee commented on YARN-3949:
---
For background, HBase's {{BufferedMutatorImpl}} does
26 matches
Mail list logo