[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api module

2015-07-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642625#comment-14642625
 ] 

Hudson commented on YARN-3958:
--

SUCCESS: Integrated in Hadoop-Yarn-trunk #999 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/999/])
YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api 
module. Contributed by Varun Saxena. (aajisaka: rev 
42d4e0ae99d162fde52902cb86e29f2c82a084c8)
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
* hadoop-yarn-project/CHANGES.txt
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java


 TestYarnConfigurationFields should be moved to hadoop-yarn-api module
 -

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Fix For: 2.8.0

 Attachments: YARN-3958.01.patch, YARN-3958.02.patch, 
 YARN-3958.03.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api module

2015-07-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642615#comment-14642615
 ] 

Hudson commented on YARN-3958:
--

SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #269 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/269/])
YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api 
module. Contributed by Varun Saxena. (aajisaka: rev 
42d4e0ae99d162fde52902cb86e29f2c82a084c8)
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
* hadoop-yarn-project/CHANGES.txt
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java


 TestYarnConfigurationFields should be moved to hadoop-yarn-api module
 -

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Fix For: 2.8.0

 Attachments: YARN-3958.01.patch, YARN-3958.02.patch, 
 YARN-3958.03.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api module

2015-07-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642855#comment-14642855
 ] 

Hudson commented on YARN-3958:
--

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #266 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/266/])
YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api 
module. Contributed by Varun Saxena. (aajisaka: rev 
42d4e0ae99d162fde52902cb86e29f2c82a084c8)
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
* hadoop-yarn-project/CHANGES.txt
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml


 TestYarnConfigurationFields should be moved to hadoop-yarn-api module
 -

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Fix For: 2.8.0

 Attachments: YARN-3958.01.patch, YARN-3958.02.patch, 
 YARN-3958.03.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api module

2015-07-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642811#comment-14642811
 ] 

Hudson commented on YARN-3958:
--

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #258 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/258/])
YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api 
module. Contributed by Varun Saxena. (aajisaka: rev 
42d4e0ae99d162fde52902cb86e29f2c82a084c8)
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
* hadoop-yarn-project/CHANGES.txt


 TestYarnConfigurationFields should be moved to hadoop-yarn-api module
 -

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Fix For: 2.8.0

 Attachments: YARN-3958.01.patch, YARN-3958.02.patch, 
 YARN-3958.03.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api module

2015-07-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642770#comment-14642770
 ] 

Hudson commented on YARN-3958:
--

FAILURE: Integrated in Hadoop-Hdfs-trunk #2196 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2196/])
YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api 
module. Contributed by Varun Saxena. (aajisaka: rev 
42d4e0ae99d162fde52902cb86e29f2c82a084c8)
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
* hadoop-yarn-project/CHANGES.txt
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java


 TestYarnConfigurationFields should be moved to hadoop-yarn-api module
 -

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Fix For: 2.8.0

 Attachments: YARN-3958.01.patch, YARN-3958.02.patch, 
 YARN-3958.03.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api module

2015-07-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642886#comment-14642886
 ] 

Hudson commented on YARN-3958:
--

SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2215 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2215/])
YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api 
module. Contributed by Varun Saxena. (aajisaka: rev 
42d4e0ae99d162fde52902cb86e29f2c82a084c8)
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
* hadoop-yarn-project/CHANGES.txt


 TestYarnConfigurationFields should be moved to hadoop-yarn-api module
 -

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Fix For: 2.8.0

 Attachments: YARN-3958.01.patch, YARN-3958.02.patch, 
 YARN-3958.03.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api module

2015-07-27 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642952#comment-14642952
 ] 

Varun Saxena commented on YARN-3958:


Thanks [~ajisakaa] for the review and commit

 TestYarnConfigurationFields should be moved to hadoop-yarn-api module
 -

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Fix For: 2.8.0

 Attachments: YARN-3958.01.patch, YARN-3958.02.patch, 
 YARN-3958.03.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api module

2015-07-26 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642226#comment-14642226
 ] 

Hudson commented on YARN-3958:
--

FAILURE: Integrated in Hadoop-trunk-Commit #8223 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/8223/])
YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api 
module. Contributed by Varun Saxena. (aajisaka: rev 
42d4e0ae99d162fde52902cb86e29f2c82a084c8)
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
* hadoop-yarn-project/CHANGES.txt
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java


 TestYarnConfigurationFields should be moved to hadoop-yarn-api module
 -

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Fix For: 2.8.0

 Attachments: YARN-3958.01.patch, YARN-3958.02.patch, 
 YARN-3958.03.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api

2015-07-26 Thread Akira AJISAKA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642182#comment-14642182
 ] 

Akira AJISAKA commented on YARN-3958:
-

Thanks [~varun_saxena] for the comment.

bq. Pls note hadoop-yarn-api does not have dependency on hadoop-yarn-common in 
its pom.xml Change can be made but this should go in branch-2 then ?

I understand. We cannot move YarnConfiguration class in branch-2.

bq. Moreover, realistically will somebody add a YARN related config in 
yarn-default.xml but not add it in YarnConfiguration class ? I think unlikely. 
The reverse happens far more frequently.

Make sense to me.

bq. So in branch-2 we can just move this test to hadoop-yarn-api and in trunk, 
move YarnConfiguration to hadoop-yarn-common.

I'll commit your latest patch in trunk and branch-2. Now I'm thinking moving 
YarnConfiguration to yarn-common in trunk makes little sense because it is 
unlikely that someone adds a config in yarn-default.xml but not add it in 
YarnConfiguration.java, as you said.

 TestYarnConfigurationFields should be moved to hadoop-yarn-api
 --

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Attachments: YARN-3958.01.patch, YARN-3958.02.patch, 
 YARN-3958.03.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api

2015-07-25 Thread Akira AJISAKA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641478#comment-14641478
 ] 

Akira AJISAKA commented on YARN-3958:
-

Rethinking this issue, can we move YarnConfiguration.java to hadoop-yarn-common 
to fix the problem? If the patch is committed, Jenkins cannot run the test when 
yarn-default.xml is changed.

 TestYarnConfigurationFields should be moved to hadoop-yarn-api
 --

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Attachments: YARN-3958.01.patch, YARN-3958.02.patch, 
 YARN-3958.03.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api

2015-07-25 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641558#comment-14641558
 ] 

Varun Saxena commented on YARN-3958:


[~ajisakaa],
Checked the test. You are correct.
But I think this would be a major change.
I have a concern that there might be some projects which might have induced 
dependency in their pom on hadoop-yarn-api because they want to use 
YarnConfiguration class. Pls note hadoop-yarn-api does not have dependency on 
hadoop-yarn-common in its pom.xml
Change can be made but this should go in branch-2 then ?

Moreover, realistically will somebody add a YARN related config in 
yarn-default.xml but not add it in YarnConfiguration class ?
I think unlikely. The reverse happens far more frequently.

So in branch-2 we can just move this test to hadoop-yarn-api and in trunk, move 
YarnConfiguration to hadoop-yarn-common.  Thoughts ?

 TestYarnConfigurationFields should be moved to hadoop-yarn-api
 --

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Attachments: YARN-3958.01.patch, YARN-3958.02.patch, 
 YARN-3958.03.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api

2015-07-24 Thread Akira AJISAKA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639983#comment-14639983
 ] 

Akira AJISAKA commented on YARN-3958:
-

Thanks [~varun_saxena] for updating the patch. Would you replace tabs with 
whitespaces in TestYarnConfigurationFields.java?
{code}
+configurationPropsToSkipCompare
+.add(YarnConfiguration
+   .YARN_SECURITY_SERVICE_AUTHORIZATION_APPLICATIONCLIENT_PROTOCOL);
+configurationPropsToSkipCompare
+.add(YarnConfiguration
+   .YARN_SECURITY_SERVICE_AUTHORIZATION_APPLICATIONMASTER_PROTOCOL);
{code}
The code has tabs before {{.YARN_SECURITY_...}}. I'm +1 if that is addressed.

 TestYarnConfigurationFields should be moved to hadoop-yarn-api
 --

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Attachments: YARN-3958.01.patch, YARN-3958.02.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api

2015-07-24 Thread Akira AJISAKA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640827#comment-14640827
 ] 

Akira AJISAKA commented on YARN-3958:
-

+1 pending Jenkins. Thanks.

 TestYarnConfigurationFields should be moved to hadoop-yarn-api
 --

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Attachments: YARN-3958.01.patch, YARN-3958.02.patch, 
 YARN-3958.03.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api

2015-07-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640893#comment-14640893
 ] 

Hadoop QA commented on YARN-3958:
-

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  17m 28s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 2 new or modified test files. |
| {color:green}+1{color} | javac |   7m 40s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 37s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m 55s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 20s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   3m  7s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |   0m 23s | Tests passed in 
hadoop-yarn-api. |
| {color:green}+1{color} | yarn tests |   1m 56s | Tests passed in 
hadoop-yarn-common. |
| | |  44m 24s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12747066/YARN-3958.03.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / fbd6063 |
| hadoop-yarn-api test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8652/artifact/patchprocess/testrun_hadoop-yarn-api.txt
 |
| hadoop-yarn-common test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8652/artifact/patchprocess/testrun_hadoop-yarn-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8652/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8652/console |


This message was automatically generated.

 TestYarnConfigurationFields should be moved to hadoop-yarn-api
 --

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Attachments: YARN-3958.01.patch, YARN-3958.02.patch, 
 YARN-3958.03.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api

2015-07-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638901#comment-14638901
 ] 

Hadoop QA commented on YARN-3958:
-

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  19m 22s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 2 new or modified test files. |
| {color:green}+1{color} | javac |   8m 30s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |  10m 21s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 20s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   2m 15s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 30s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 35s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   3m 26s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |   0m 23s | Tests passed in 
hadoop-yarn-api. |
| {color:green}+1{color} | yarn tests |   2m  2s | Tests passed in 
hadoop-yarn-common. |
| | |  48m 46s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12746801/YARN-3958.02.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / ee98d63 |
| hadoop-yarn-api test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8635/artifact/patchprocess/testrun_hadoop-yarn-api.txt
 |
| hadoop-yarn-common test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8635/artifact/patchprocess/testrun_hadoop-yarn-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8635/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8635/console |


This message was automatically generated.

 TestYarnConfigurationFields should be moved to hadoop-yarn-api
 --

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Attachments: YARN-3958.01.patch, YARN-3958.02.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api

2015-07-23 Thread Akira AJISAKA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638244#comment-14638244
 ] 

Akira AJISAKA commented on YARN-3958:
-

LGTM, +1.

 TestYarnConfigurationFields should be moved to hadoop-yarn-api
 --

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Attachments: YARN-3958.01.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api

2015-07-23 Thread Akira AJISAKA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638437#comment-14638437
 ] 

Akira AJISAKA commented on YARN-3958:
-

Cancelling my +1. Hi [~varun_saxena], could you remove tabs in 
TestYarnConfigurationFields.java in this jira?

 TestYarnConfigurationFields should be moved to hadoop-yarn-api
 --

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Attachments: YARN-3958.01.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3958) TestYarnConfigurationFields should be moved to hadoop-yarn-api

2015-07-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637913#comment-14637913
 ] 

Hadoop QA commented on YARN-3958:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  18m 10s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 2 new or modified test files. |
| {color:green}+1{color} | javac |   7m 54s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 50s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m 53s | There were no new checkstyle 
issues. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 2  line(s) that 
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 25s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 38s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   3m  9s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |   0m 24s | Tests passed in 
hadoop-yarn-api. |
| {color:green}+1{color} | yarn tests |   1m 57s | Tests passed in 
hadoop-yarn-common. |
| | |  45m 48s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12746657/YARN-3958.01.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 06e5dd2 |
| whitespace | 
https://builds.apache.org/job/PreCommit-YARN-Build/8626/artifact/patchprocess/whitespace.txt
 |
| hadoop-yarn-api test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8626/artifact/patchprocess/testrun_hadoop-yarn-api.txt
 |
| hadoop-yarn-common test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8626/artifact/patchprocess/testrun_hadoop-yarn-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8626/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8626/console |


This message was automatically generated.

 TestYarnConfigurationFields should be moved to hadoop-yarn-api
 --

 Key: YARN-3958
 URL: https://issues.apache.org/jira/browse/YARN-3958
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Varun Saxena
Assignee: Varun Saxena
 Attachments: YARN-3958.01.patch


 Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
 test is for checking whether all the configurations declared in 
 YarnConfiguration exist in yarn-default.xml or not.
 But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
 file, it is not necessary that this test will be run. So if the developer 
 misses to update yarn-default.xml and patch is committed, it will lead to 
 unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)