[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007289#comment-16007289
]
Jason Lowe commented on YARN-4002:
--
FYI we're finding this change to be quite expensive on large clusters.
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387088#comment-15387088
]
Guoyao Xu commented on YARN-4002:
-
I think that might not be a big problem. Because hostsReader.refresh()
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292058#comment-15292058
]
Hudson commented on YARN-4002:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #9825 (See
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291646#comment-15291646
]
Hadoop QA commented on YARN-4002:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289372#comment-15289372
]
Jian He commented on YARN-4002:
---
ok, let's keep it, I think the lock can be removed ?
> make
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288564#comment-15288564
]
Rohith Sharma K S commented on YARN-4002:
-
bq. also, setExcludesFile, setIncludesFile,
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287663#comment-15287663
]
Jian He commented on YARN-4002:
---
[~rohithsharma], could you fix the findbugs warning ?
also, setExcludesFile,
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286342#comment-15286342
]
Hadoop QA commented on YARN-4002:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284966#comment-15284966
]
Jian He commented on YARN-4002:
---
[~rohithsharma], thanks for updating the patch.
I think we may eliminate the
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284311#comment-15284311
]
Hadoop QA commented on YARN-4002:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15282962#comment-15282962
]
Jian He commented on YARN-4002:
---
Yeah, I think so. because otherwise node heartbeat still competes on the
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15282381#comment-15282381
]
Rohith Sharma K S commented on YARN-4002:
-
I agree this wont solve 100%, but it reduces lock time
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15282354#comment-15282354
]
Rohith Sharma K S commented on YARN-4002:
-
For the second suggestion, IIRC I was suggested to
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281883#comment-15281883
]
Jian He commented on YARN-4002:
---
[~rohithsharma], the patch may not work because
hostsReader.refresh() tries
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281768#comment-15281768
]
Wangda Tan commented on YARN-4002:
--
Thanks [~rohithsharma],
Few suggestions:
1) hostsWrite/ReadLock ->
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281264#comment-15281264
]
Hadoop QA commented on YARN-4002:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281041#comment-15281041
]
Wangda Tan commented on YARN-4002:
--
[~rohithsharma], is there any update for the latest patch? Cleaning up
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229904#comment-15229904
]
Hadoop QA commented on YARN-4002:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15224070#comment-15224070
]
Hadoop QA commented on YARN-4002:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217609#comment-15217609
]
Rohith Sharma K S commented on YARN-4002:
-
It looks jenkins is triggered long back, I will kick of
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217605#comment-15217605
]
Rohith Sharma K S commented on YARN-4002:
-
That make sense to me. Thanks
> make
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217334#comment-15217334
]
Hong Zhiguo commented on YARN-4002:
---
Including return statement into readlock critical seciton doesn't
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217294#comment-15217294
]
Rohith Sharma K S commented on YARN-4002:
-
Hi [~zhiguohong]
In the latest patch
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203611#comment-15203611
]
Rohith Sharma K S commented on YARN-4002:
-
Thanks [~leftnoteasy] for the looking at the patch..
I
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202592#comment-15202592
]
Wangda Tan commented on YARN-4002:
--
[~rohithsharma], [~zhiguohong],
Thanks for working on this patch,
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174833#comment-15174833
]
Rohith Sharma K S commented on YARN-4002:
-
All the method in HostsFileReader are synchronized. And
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174795#comment-15174795
]
Hong Zhiguo commented on YARN-4002:
---
Hi, [~rohithsharma], thanks for the refinement.
But why don't take
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174776#comment-15174776
]
Rohith Sharma K S commented on YARN-4002:
-
[~leftnoteasy] would you like to have look at patch? If
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173728#comment-15173728
]
Hadoop QA commented on YARN-4002:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173557#comment-15173557
]
Rohith Sharma K S commented on YARN-4002:
-
Recently we hit this issue in 2K nodes testing. It is
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038392#comment-15038392
]
Brook Zhou commented on YARN-4002:
--
If this is currently not being worked on, I will assign it to me.
>
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15039597#comment-15039597
]
Hong Zhiguo commented on YARN-4002:
---
I'm working on it. I've proposed 2 different solutions and waiting
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680731#comment-14680731
]
Wangda Tan commented on YARN-4002:
--
[~xinxianyin], YARN-3091 is mostly for grouping all RM
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662744#comment-14662744
]
Xianyin Xin commented on YARN-4002:
---
+1 for the proposal. [~leftnoteasy], I think
[
https://issues.apache.org/jira/browse/YARN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662100#comment-14662100
]
Wangda Tan commented on YARN-4002:
--
Thanks for reporting, [~zhiguohong]. +1 for this
35 matches
Mail list logo