[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305972#comment-15305972 ] Hudson commented on YARN-4007: -- SUCCESS: Integrated in Hadoop-trunk-Commit #9885 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9885/]) YARN-4007. Add support for different network setups when launching the (vvasudev: rev 86fb58b7dc832c2df30469d128598a6a1bed8df5) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DockerLinuxContainerRuntime.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/TestDockerContainerRuntime.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > Fix For: 2.9.0 > > Attachments: YARN-4007.001.patch, YARN-4007.002.patch, > YARN-4007.003.patch > > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303647#comment-15303647 ] Varun Vasudev commented on YARN-4007: - [~sidharta-s] clarified that the tests have no ordering requirement in an offline conversation and he is correct. I also agree that the ports discussion should be handled in another JIRA - it's a far bigger change with things like collision and scheduling that need to thought through. Latest patch looks good to me. I'll commit it tomorrow if no one objects. > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > Attachments: YARN-4007.001.patch, YARN-4007.002.patch, > YARN-4007.003.patch > > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303629#comment-15303629 ] Sidharta Seethana commented on YARN-4007: - Should we continue this discussion on YARN-5168 ? I'll add my comments there as well. > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > Attachments: YARN-4007.001.patch, YARN-4007.002.patch, > YARN-4007.003.patch > > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303619#comment-15303619 ] Zhongyue Luo commented on YARN-4007: I would be nice, if using bridge mode, the admin can specify a port range in yarn-site.xml which is available on all NM hosts for port mapping. Users should be restricted from mapping a container port to a specific host port, always a container port mapped to a random port among the available port range. Thoughts? > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > Attachments: YARN-4007.001.patch, YARN-4007.002.patch, > YARN-4007.003.patch > > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303500#comment-15303500 ] Jun Gong commented on YARN-4007: As discussed in YARN-5168, for host network, port mapping might conflict for each container. And some container might use important system port, e.g. port 80, 22. Maybe we could address it in following jira? > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > Attachments: YARN-4007.001.patch, YARN-4007.002.patch, > YARN-4007.003.patch > > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303385#comment-15303385 ] Jun Gong commented on YARN-4007: Yes, we faced same problems and solved it by "-p", we could discuss more in YARN-5168. > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > Attachments: YARN-4007.001.patch, YARN-4007.002.patch, > YARN-4007.003.patch > > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303384#comment-15303384 ] Jun Gong commented on YARN-4007: Filed YARN-5168 to address it. > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > Attachments: YARN-4007.001.patch, YARN-4007.002.patch, > YARN-4007.003.patch > > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303351#comment-15303351 ] tangzhankun commented on YARN-4007: --- [~hex108], Thanks for raise this port handling problem. We may not only support "- P " but also "-p hostPort(range):containerPort(range)". > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > Attachments: YARN-4007.001.patch, YARN-4007.002.patch, > YARN-4007.003.patch > > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[
https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302579#comment-15302579
]
Hadoop QA commented on YARN-4007:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 26s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
0s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 31s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 40s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
31s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 4s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 43s
{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 32s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 32s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s {color} | {color:green} hadoop-yarn-project/hadoop-yarn: patch generated 0
new + 228 unchanged - 27 fixed = 228 total (was 255) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 22s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 20s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 21s
{color} | {color:green} hadoop-yarn-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 7s
{color} | {color:green} hadoop-yarn-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 11m 8s
{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 45m 14s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:2c91fd8 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12806430/YARN-4007.003.patch |
| JIRA Issue | YARN-4007 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle xml |
| uname | Linux 2f8f41eb5494 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / fed9bf0 |
| Default Java | 1.8.0_91 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/11713/testReport/ |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302481#comment-15302481 ] Sidharta Seethana commented on YARN-4007: - [~hex108], port handling is a bit more involved and I have intentionally left out port handling in this JIRA. Could you file a separate issue and we could discuss port handling there ? > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > Attachments: YARN-4007.001.patch, YARN-4007.002.patch, > YARN-4007.003.patch > > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[
https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302279#comment-15302279
]
Hadoop QA commented on YARN-4007:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 24s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
54s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 28s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 41s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
39s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
54s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 38s
{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
20s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 17s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 17s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 41s
{color} | {color:red} hadoop-yarn-project/hadoop-yarn: patch generated 1 new +
228 unchanged - 27 fixed = 229 total (was 255) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 25s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
34s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
10s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 25s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 24s
{color} | {color:green} hadoop-yarn-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 16s
{color} | {color:green} hadoop-yarn-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 11m 43s
{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 45m 32s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:2c91fd8 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12806394/YARN-4007.002.patch |
| JIRA Issue | YARN-4007 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle xml |
| uname | Linux 69a3df6d8bde 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / fed9bf0 |
| Default Java | 1.8.0_91 |
| findbugs | v3.0.0 |
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/11711/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
|
| Test Results |
https:/
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302243#comment-15302243 ] Jun Gong commented on YARN-4007: Thanks [~sidharta-s] for the patch and [~vvasudev]'s review! When we use network type "bridge", it seems that we need add "-P" in docker run args to map container's exposed ports to host ports? > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > Attachments: YARN-4007.001.patch, YARN-4007.002.patch > > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[
https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302086#comment-15302086
]
Varun Vasudev commented on YARN-4007:
-
Thanks for the patch [~sidharta-s]. Comments on the patch -
# Can you fix the following checkstyle issues -
{code}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:1379:
public static final String [] DEFAULT_NM_DOCKER_ALLOWED_CONTAINER_NETWORKS
=:29: 'String' is followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:1380:
{ "host", "none", "bridge" };:8: '{' is followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/TestDockerContainerRuntime.java:387:
String[] testCapabilities = {"NET_BIND_SERVICE", "SYS_CHROOT"};:14:
'testCapabilities' hides a field.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/TestDockerContainerRuntime.java:399:
String[] networks = { "host", "none", "bridge", customNetwork1,:26: '{' is
followed by whitespace.
{code}
# In testContainerLaunchWithNetworkingDefaults() - can you set
YarnConfiguration.NM_DOCKER_ALLOWED_CONTAINER_NETWORKS in the test? It looks
like you're relying on the order in which the tests run
# {code}
+//default network is "sdn3"
+conf.set(YarnConfiguration.NM_DOCKER_DEFAULT_CONTAINER_NETWORK,
+customNetwork1);
{code}
Comment doesn't match code - actual default network is sdn1
Rest of the patch looks good to me.
> Add support for different network setups when launching the docker container
>
>
> Key: YARN-4007
> URL: https://issues.apache.org/jira/browse/YARN-4007
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
>Affects Versions: 2.8.0
>Reporter: Varun Vasudev
>Assignee: Sidharta Seethana
> Attachments: YARN-4007.001.patch
>
>
> We should allow users to be able to launch containers with appropriate
> network setups. For security, we should allow admins to provide a set of
> options that the users are allowed to use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[
https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301961#comment-15301961
]
Hadoop QA commented on YARN-4007:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
30s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 57s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 19s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
32s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
31s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s
{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
5s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 57s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 57s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 35s
{color} | {color:red} hadoop-yarn-project/hadoop-yarn: patch generated 5 new +
254 unchanged - 1 fixed = 259 total (was 255) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 15s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
53s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 18s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 21s
{color} | {color:green} hadoop-yarn-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 6s
{color} | {color:green} hadoop-yarn-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 11m 5s
{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 41s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:2c91fd8 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12806308/YARN-4007.001.patch |
| JIRA Issue | YARN-4007 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle xml |
| uname | Linux 25557e440d62 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 77202fa |
| Default Java | 1.8.0_91 |
| findbugs | v3.0.0 |
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/11708/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
|
| Test Results |
https://bui
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301680#comment-15301680 ] Sidharta Seethana commented on YARN-4007: - [~vvasudev], I have submitted the patch to Jenkins. Could you please review the patch when possible? Thanks! > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > Attachments: YARN-4007.001.patch > > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297443#comment-15297443 ] Zhongyue Luo commented on YARN-4007: [~sidharta-s] Thanks for the heads up. We'd definitely try it out. > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296994#comment-15296994 ] Sidharta Seethana commented on YARN-4007: - Hi [~zyluo], I have work in progress patch - I should be able to put it up this week. > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290622#comment-15290622 ] Zhongyue Luo commented on YARN-4007: Hi, [~sidharta-s] We are planning to add BRIDGE mode support for Docker containers. Wondering if you have already implemented this feature. Any progress? > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Sidharta Seethana > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4007) Add support for different network setups when launching the docker container
[ https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086672#comment-15086672 ] Sidharta Seethana commented on YARN-4007: - Hi [~vvasudev], Would you mind if I take over this JIRA if you are not working on this currently? thanks, -Sidharta > Add support for different network setups when launching the docker container > > > Key: YARN-4007 > URL: https://issues.apache.org/jira/browse/YARN-4007 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Varun Vasudev >Assignee: Varun Vasudev > > We should allow users to be able to launch containers with appropriate > network setups. For security, we should allow admins to provide a set of > options that the users are allowed to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
