[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369714#comment-15369714
]
Hudson commented on YARN-4075:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934848#comment-14934848
]
Varun Saxena commented on YARN-4075:
[~gtCarrera9],
bq. A quick question: if I would like to query for
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934859#comment-14934859
]
Varun Saxena commented on YARN-4075:
Filed YARN-4210 for the same.
> [reader REST API] implement
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934450#comment-14934450
]
Li Lu commented on YARN-4075:
-
Hi [~varun_saxena]. I'm working on the web UI POC right now and ran into some
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934454#comment-14934454
]
Li Lu commented on YARN-4075:
-
BTW, I hit NPEs with the above format. I also checked my hbase and could see
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14909354#comment-14909354
]
Varun Saxena commented on YARN-4075:
Thanks Vrushali for review and commit.
Thanks Li, Sangjin and Joep
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908364#comment-14908364
]
Sangjin Lee commented on YARN-4075:
---
Kicking off the build one more time. It might be due to the issue of
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908458#comment-14908458
]
Vrushali C commented on YARN-4075:
--
Thanks @sjlee! The tests passed this time. Committing the patch in
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908548#comment-14908548
]
Vrushali C commented on YARN-4075:
--
Committed patch v05, thanks [~varun_saxena] for the patch and
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908471#comment-14908471
]
Li Lu commented on YARN-4075:
-
Thanks [~vrushalic]! I'll start to connect the web UI with this end point
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908440#comment-14908440
]
Hadoop QA commented on YARN-4075:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907787#comment-14907787
]
Varun Saxena commented on YARN-4075:
Test failures are weird. They seem to be triggered by
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906407#comment-14906407
]
Varun Saxena commented on YARN-4075:
[~vrushalic], thanks for the review.
bq. Some of the path/query
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906721#comment-14906721
]
Hadoop QA commented on YARN-4075:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906869#comment-14906869
]
Vrushali C commented on YARN-4075:
--
Thank you [~varun_saxena]! I think the unit test failures are
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907118#comment-14907118
]
Hadoop QA commented on YARN-4075:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904632#comment-14904632
]
Hadoop QA commented on YARN-4075:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904578#comment-14904578
]
Varun Saxena commented on YARN-4075:
In addition to rebasing on latest branch code, patch has following
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904820#comment-14904820
]
Li Lu commented on YARN-4075:
-
LGTM. Only one question: I'm not an expert in RESTful API implementation so
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904888#comment-14904888
]
Varun Saxena commented on YARN-4075:
Ok, will update a patch.
> [reader REST API] implement support
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904866#comment-14904866
]
Varun Saxena commented on YARN-4075:
I am not an expert either. Infact this has not been done
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904877#comment-14904877
]
Li Lu commented on YARN-4075:
-
Thanks for the reference [~varun_saxena]. Maybe we'd like to keep them
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904911#comment-14904911
]
Li Lu commented on YARN-4075:
-
Latest patch LGTM.
> [reader REST API] implement support for querying for
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905407#comment-14905407
]
Vrushali C commented on YARN-4075:
--
Alright, I have restarted the build on jenkins as well.
> [reader
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905385#comment-14905385
]
Li Lu commented on YARN-4075:
-
Tried the failed UTs on my local machine and could not reproduce the failures.
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905173#comment-14905173
]
Hadoop QA commented on YARN-4075:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905466#comment-14905466
]
Vrushali C commented on YARN-4075:
--
Filed https://issues.apache.org/jira/browse/YARN-4203 for adding
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905454#comment-14905454
]
Vrushali C commented on YARN-4075:
--
Thanks Varun! It look good.
In TimelineReaderWebServices.java
lines
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905478#comment-14905478
]
Li Lu commented on YARN-4075:
-
bq. Hmm. If this rest service is running outside of a hadoop cluster, wondering
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905582#comment-14905582
]
Hadoop QA commented on YARN-4075:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903305#comment-14903305
]
Varun Saxena commented on YARN-4075:
[~gtCarrera9], thanks for the review.
bq. Maybe we'd like to
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903329#comment-14903329
]
Varun Saxena commented on YARN-4075:
I mean "I plan to combine two of the test webservices classes to
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903162#comment-14903162
]
Li Lu commented on YARN-4075:
-
Sorry folks we're a little bit delayed on YARN-4074, but once that is in we can
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903342#comment-14903342
]
Li Lu commented on YARN-4075:
-
Hi [~varun_saxena], thanks for the note!
bq. Infact in initial patches in
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903396#comment-14903396
]
Li Lu commented on YARN-4075:
-
bq. This can lead to code bloating with similar methods repeating again and
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903363#comment-14903363
]
Varun Saxena commented on YARN-4075:
{quote}
Or we can have 2 separate REST endpoints, with and without
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903979#comment-14903979
]
Varun Saxena commented on YARN-4075:
bq. With proper overloading I don't see significant code
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14902902#comment-14902902
]
Joep Rottinghuis commented on YARN-4075:
Agreed with comments from [~gtCarrera]
> [reader REST
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901537#comment-14901537
]
Li Lu commented on YARN-4075:
-
Hi [~varun_saxena]! Thanks for the work and sorry for the delayed reply. I
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876934#comment-14876934
]
Varun Saxena commented on YARN-4075:
Yes. Will rebase after 4074 goes in. Have to remove user as
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876765#comment-14876765
]
Sangjin Lee commented on YARN-4075:
---
The latest patch looks good to me. Once YARN-4074 is committed, we
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745885#comment-14745885
]
Varun Saxena commented on YARN-4075:
Rebased the patch on top of latest patches of 3901 and 4074.
Same
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738559#comment-14738559
]
Varun Saxena commented on YARN-4075:
Ok, will rebase the patch. Maybe after reviewing 3901 and 4074
>
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735541#comment-14735541
]
Sangjin Lee commented on YARN-4075:
---
Sorry [~varun_saxena], it took me a while to review this. The patch
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727440#comment-14727440
]
Varun Saxena commented on YARN-4075:
Few comments about the patch :
# readResultsWithTimestampsForLongs
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727431#comment-14727431
]
Varun Saxena commented on YARN-4075:
This patch is on top of YARN-3901-YARN-2928.1.patch and
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720988#comment-14720988
]
Varun Saxena commented on YARN-4075:
Yup it can progress.
[reader REST API]
[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720406#comment-14720406
]
Li Lu commented on YARN-4075:
-
Hi [~varun_saxena], is this JIRA still blocked by YARN-4074, or
48 matches
Mail list logo