[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746349#comment-15746349
]
Junping Du commented on YARN-4438:
--
Per discussion in YARN-5709, I have merge the patch (apply clean
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093181#comment-15093181
]
Akira AJISAKA commented on YARN-4438:
-
Thanks Steve!
> Implement RM leader election with curator
>
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089661#comment-15089661
]
Jian He commented on YARN-4438:
---
[~ajisakaa], I think it's complaining that the newly added class requires a
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089770#comment-15089770
]
Steve Loughran commented on YARN-4438:
--
Everyone: yes, the build fails in javadocs. But I don't think
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089746#comment-15089746
]
Steve Loughran commented on YARN-4438:
--
Ignore everything I'm saying ... I'm confused now, and if
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089700#comment-15089700
]
Jian He commented on YARN-4438:
---
[~ajisakaa], actually, what I said is about checkstyle. For the javadoc -1.
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090235#comment-15090235
]
Jian He commented on YARN-4438:
---
no problem, Steve, thanks for spending time on investigating this !
>
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090074#comment-15090074
]
Steve Loughran commented on YARN-4438:
--
OK. I've got a on-line patch YARN-4567 covering the javadocs.
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089697#comment-15089697
]
Steve Loughran commented on YARN-4438:
--
It's complaining that the javadocs are invalid: Java 8 javadoc
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089512#comment-15089512
]
Akira AJISAKA commented on YARN-4438:
-
Hi [~xgong] and [~jianhe],
bq. -1 javadoc
please do not ignore
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088213#comment-15088213
]
Hadoop QA commented on YARN-4438:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088220#comment-15088220
]
Xuan Gong commented on YARN-4438:
-
+1 lgtm. Checking this in.
> Implement RM leader election with curator
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088285#comment-15088285
]
Xuan Gong commented on YARN-4438:
-
Committed into trunk/branch-2. Thanks, Jian. And thanks for the review,
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088306#comment-15088306
]
Hudson commented on YARN-4438:
--
FAILURE: Integrated in Hadoop-trunk-Commit #9071 (See
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074595#comment-15074595
]
Hadoop QA commented on YARN-4438:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073325#comment-15073325
]
Hadoop QA commented on YARN-4438:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072436#comment-15072436
]
Jian He commented on YARN-4438:
---
bq. Not sure I understand why ZKRMStateStore needs to be an AlwaysOn
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069202#comment-15069202
]
Karthik Kambatla commented on YARN-4438:
bq. And because ZKRMStateStore is currently in active
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061126#comment-15061126
]
Jian He commented on YARN-4438:
---
Thanks for detailed review !
bq. All that is needed is store the
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059248#comment-15059248
]
Karthik Kambatla commented on YARN-4438:
bq. I'll make the change accordingly.
Not sure I
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056849#comment-15056849
]
Hadoop QA commented on YARN-4438:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054052#comment-15054052
]
Hadoop QA commented on YARN-4438:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053955#comment-15053955
]
Jian He commented on YARN-4438:
---
[~ozawa], thanks for reviewing the patch, I fixed your comments;
bq. why did
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050391#comment-15050391
]
Karthik Kambatla commented on YARN-4438:
Would very much like for us to use Curator for leader
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052001#comment-15052001
]
Jian He commented on YARN-4438:
---
bq. Otherwise, the clients (and their individual timeouts etc.) could lead
[
https://issues.apache.org/jira/browse/YARN-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049835#comment-15049835
]
Hadoop QA commented on YARN-4438:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
26 matches
Mail list logo
