[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-22 Thread Jun Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112551#comment-15112551 ] Jun Gong commented on YARN-4497: [~rohithsharma] Thanks for the review, comments and commi

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112511#comment-15112511 ] Hudson commented on YARN-4497: -- FAILURE: Integrated in Hadoop-trunk-Commit #9166 (See [https:

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112378#comment-15112378 ] Hadoop QA commented on YARN-4497: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-22 Thread Jun Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112244#comment-15112244 ] Jun Gong commented on YARN-4497: [~rohithsharma] thanks, I just attached a rebased patch.

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-22 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112134#comment-15112134 ] Rohith Sharma K S commented on YARN-4497: - [~hex108] would mind rebase the patch? S

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-22 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112126#comment-15112126 ] Rohith Sharma K S commented on YARN-4497: - +1, committing shortly > RM might fail

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-21 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112023#comment-15112023 ] Jian He commented on YARN-4497: --- +1, thanks > RM might fail to restart when recovering apps

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111943#comment-15111943 ] Hadoop QA commented on YARN-4497: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-21 Thread Jun Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111823#comment-15111823 ] Jun Gong commented on YARN-4497: [~jianhe] Thanks for review. Attach a new patch to address

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-21 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111507#comment-15111507 ] Jian He commented on YARN-4497: --- looks good to me, minor comments is I think setRecoveredFina

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-17 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104225#comment-15104225 ] Rohith Sharma K S commented on YARN-4497: - +1 LGTM, I will wait for couple of days

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-13 Thread Jun Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097687#comment-15097687 ] Jun Gong commented on YARN-4497: [~rohithsharma] Thanks for the analysis. Yes, it is a bug.

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-13 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097653#comment-15097653 ] Rohith Sharma K S commented on YARN-4497: - bq. "If attempt 1~28 are removed and att

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-13 Thread Bibin A Chundatt (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097634#comment-15097634 ] Bibin A Chundatt commented on YARN-4497: # Also AM killed by RM cases too if possib

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-13 Thread Bibin A Chundatt (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097633#comment-15097633 ] Bibin A Chundatt commented on YARN-4497: [~hex108] YARN-4584 logs i have shared to

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097600#comment-15097600 ] Hadoop QA commented on YARN-4497: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-13 Thread Jun Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097434#comment-15097434 ] Jun Gong commented on YARN-4497: [~sunilg] Thanks for confirm and comments. I just updated

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-13 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096309#comment-15096309 ] Sunil G commented on YARN-4497: --- Hi [~hex108] I second the idea of sorting {{appState.attempt

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-13 Thread Jun Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095956#comment-15095956 ] Jun Gong commented on YARN-4497: [~rohithsharma] Thanks for the comments and suggestion. {

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-12 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095740#comment-15095740 ] Rohith Sharma K S commented on YARN-4497: - As a side node : since YARN-3840 removes

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-12 Thread Jun Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095389#comment-15095389 ] Jun Gong commented on YARN-4497: [~jianhe] Thanks for review and comments. {quote} for the

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2016-01-12 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094923#comment-15094923 ] Jian He commented on YARN-4497: --- [~hex108], thanks for working on this. for the patch, I th

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2015-12-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075257#comment-15075257 ] Hadoop QA commented on YARN-4497: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2015-12-30 Thread Jun Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075118#comment-15075118 ] Jun Gong commented on YARN-4497: In the patch, it deals with two cases: 1. attempt is miss

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2015-12-23 Thread Jun Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069480#comment-15069480 ] Jun Gong commented on YARN-4497: Yes, it is the problem. > RM might fail to restart when r

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2015-12-23 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069477#comment-15069477 ] Rohith Sharma K S commented on YARN-4497: - I got your point, if RM HA is not config

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2015-12-23 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069470#comment-15069470 ] Rohith Sharma K S commented on YARN-4497: - Currently, If any errors happened while

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2015-12-23 Thread Jun Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069454#comment-15069454 ] Jun Gong commented on YARN-4497: In *RMStateStore#notifyStoreOperationFailedInternal*, RMSt

[jira] [Commented] (YARN-4497) RM might fail to restart when recovering apps whose attempts are missing

2015-12-23 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069443#comment-15069443 ] Rohith Sharma K S commented on YARN-4497: - Thinking when it can happen attempt1 is