[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292192#comment-15292192 ] Hudson commented on YARN-5076: -- SUCCESS: Integrated in Hadoop-trunk-Commit #9826 (See

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292130#comment-15292130 ] Junping Du commented on YARN-5076: -- The other check-style issue is just a minor whitespace issue. Will fix

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292126#comment-15292126 ] Junping Du commented on YARN-5076: -- That's right. Just check again that it sounds like we were not adding

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Jonathan Maron (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291572#comment-15291572 ] Jonathan Maron commented on YARN-5076: -- Does a package-info.java file need to exist for

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291515#comment-15291515 ] Junping Du commented on YARN-5076: -- I think so - in this way, you have to also update the package name to

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Jonathan Maron (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291474#comment-15291474 ] Jonathan Maron commented on YARN-5076: -- Will that address this problem? I have no idea why this would

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291461#comment-15291461 ] Junping Du commented on YARN-5076: -- The unit test failure is not related and we have other JIRA to track

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291393#comment-15291393 ] Hadoop QA commented on YARN-5076: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291241#comment-15291241 ] Junping Du commented on YARN-5076: -- No worry. I already kicked it off:

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Jonathan Maron (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291162#comment-15291162 ] Jonathan Maron commented on YARN-5076: -- You kicked it off or do you want me to? I have been

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291157#comment-15291157 ] Junping Du commented on YARN-5076: -- It looks like Mr. Jenkins is on strike for some reason. Kick off it

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291150#comment-15291150 ] Junping Du commented on YARN-5076: -- Got it. If we don't set any CUSTOM_HEADER_PARAM, XFrameOptionsFilter

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Jonathan Maron (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291137#comment-15291137 ] Jonathan Maron commented on YARN-5076: -- The test actually verified that a value set for the property

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291091#comment-15291091 ] Junping Du commented on YARN-5076: -- Thanks Jon. v4 patch get very closed. Just one issue:

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Jonathan Maron (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291028#comment-15291028 ] Jonathan Maron commented on YARN-5076: -- Thanks - missed that. Will upload new patch. > YARN web

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-19 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291008#comment-15291008 ] Junping Du commented on YARN-5076: -- Thanks [~jmaron] for updating the patch. In yarn-default.xml, we still

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-18 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289507#comment-15289507 ] Junping Du commented on YARN-5076: -- Yes. Varun's list above is exactly what I prefer. Please go ahead to

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-18 Thread Jonathan Maron (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289362#comment-15289362 ] Jonathan Maron commented on YARN-5076: -- [~djp] - if you can confirm that the settings [~vvasudev]

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-18 Thread Varun Vasudev (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289269#comment-15289269 ] Varun Vasudev commented on YARN-5076: - Ah I think I misunderstood what you were saying. If I understand

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-18 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289254#comment-15289254 ] Junping Du commented on YARN-5076: -- bq. Like I mentioned above - embedding the RM/ATS ui in a frame but

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-18 Thread Varun Vasudev (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289161#comment-15289161 ] Varun Vasudev commented on YARN-5076: - Like I mentioned above - embedding the RM/ATS ui in a frame but

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-18 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289063#comment-15289063 ] Junping Du commented on YARN-5076: -- bq. I believe we need the granular control that Jon has implemented.

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-18 Thread Varun Vasudev (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289055#comment-15289055 ] Varun Vasudev commented on YARN-5076: - I'm fine with changing the default to SAMEORIGIN. I believe we

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-18 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289046#comment-15289046 ] Junping Du commented on YARN-5076: -- Granular control on different XFS options sounds reasonable. However,

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-18 Thread Jonathan Maron (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288999#comment-15288999 ] Jonathan Maron commented on YARN-5076: -- I agree with a [~vvasudev] - there are certainly use cases in

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-18 Thread Varun Vasudev (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288957#comment-15288957 ] Varun Vasudev commented on YARN-5076: - I think of a few cases around Ambari for example which may want

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-18 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288939#comment-15288939 ] Junping Du commented on YARN-5076: -- Hi [~jmaron] and [~vvasudev], do we have very solid case to partially

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-18 Thread Varun Vasudev (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288915#comment-15288915 ] Varun Vasudev commented on YARN-5076: - The resourcemanager test failures are known - it's due to an

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-17 Thread Jonathan Maron (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287399#comment-15287399 ] Jonathan Maron commented on YARN-5076: -- [~vvasudev] - the unit test failures above don't seem related

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287363#comment-15287363 ] Hadoop QA commented on YARN-5076: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5076) YARN web interfaces lack XFS protection

2016-05-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15282032#comment-15282032 ] Hadoop QA commented on YARN-5076: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||