[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723625#comment-15723625
]
Wangda Tan commented on YARN-5559:
--
Really apologize for my delayed response, thanks a lot to [~ajisakaa]
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723210#comment-15723210
]
Hudson commented on YARN-5559:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10939 (See
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15719304#comment-15719304
]
Hadoop QA commented on YARN-5559:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15718846#comment-15718846
]
Jian He commented on YARN-5559:
---
[~ajisakaa], mind check the findbugs warning?
> Analyse 2.8.0/3.0.0 jdiff
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717389#comment-15717389
]
Hadoop QA commented on YARN-5559:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717142#comment-15717142
]
Akira Ajisaka commented on YARN-5559:
-
Thanks [~jianhe] for the review. Agreed to synchronize these
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715947#comment-15715947
]
Jian He commented on YARN-5559:
---
[~ajisakaa], the patch looks good to me, only that I saw
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710860#comment-15710860
]
Hadoop QA commented on YARN-5559:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710737#comment-15710737
]
Akira Ajisaka commented on YARN-5559:
-
bq. GetClusterNodeLabelsResponsePBImpl is not thread safe.
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709497#comment-15709497
]
Jian He commented on YARN-5559:
---
sorry, I meant get/setNodeLabelList ... no 's'.. would you also if the
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708035#comment-15708035
]
Hadoop QA commented on YARN-5559:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707990#comment-15707990
]
Hadoop QA commented on YARN-5559:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707791#comment-15707791
]
Hadoop QA commented on YARN-5559:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707761#comment-15707761
]
Jian He commented on YARN-5559:
---
bq. we can make setNodeLabels(List) to
setNodeLabelsList(List
sounds good,
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707718#comment-15707718
]
Akira Ajisaka commented on YARN-5559:
-
bq. Found that the getter/setter name is inconsistent, make it
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706246#comment-15706246
]
Jian He commented on YARN-5559:
---
Thanks for updating !
- Found that the getter/setter name is inconsistent,
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704935#comment-15704935
]
Hadoop QA commented on YARN-5559:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704686#comment-15704686
]
Akira Ajisaka commented on YARN-5559:
-
{quote}
bq. 3) One of ContainerTokenIdentifier newInstance
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704159#comment-15704159
]
Akira Ajisaka commented on YARN-5559:
-
+1, thanks [~jianhe] and [~djp].
> Analyse 2.8.0/3.0.0 jdiff
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703666#comment-15703666
]
Junping Du commented on YARN-5559:
--
bq. I think we can use this single jira and upload two patches one for
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703623#comment-15703623
]
Jian He commented on YARN-5559:
---
[~ajisakaa], wangda is off for a while. would you like to update the patch
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692436#comment-15692436
]
Akira Ajisaka commented on YARN-5559:
-
Ping [~leftnoteasy]. How is this issue going on?
> Analyse
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672190#comment-15672190
]
Hadoop QA commented on YARN-5559:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671798#comment-15671798
]
Andrew Wang commented on YARN-5559:
---
Ping, seems like this patch is pretty close? Can we get it
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604561#comment-15604561
]
Akira Ajisaka commented on YARN-5559:
-
Additional comment: Would you add javadoc to document the
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604551#comment-15604551
]
Akira Ajisaka commented on YARN-5559:
-
Mostly looks good to me. I checked what issue broke the
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527006#comment-15527006
]
Wangda Tan commented on YARN-5559:
--
[~jianhe], since they're all marked as {{@Public/@Stable}}, which is
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436243#comment-15436243
]
Jian He commented on YARN-5559:
---
- Do we need the change in GetClusterNodeLabelsResponse ? it’s evolving. it
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435868#comment-15435868
]
Hadoop QA commented on YARN-5559:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435740#comment-15435740
]
Wangda Tan commented on YARN-5559:
--
Ping related folks:
[~jianhe], [~qwertymaniac], [~brahmareddy],
30 matches
Mail list logo
