[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523455#comment-15523455 ] Hudson commented on YARN-5609: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10488 (See

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523300#comment-15523300 ] Hudson commented on YARN-5609: -- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #10487 (See

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-26 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523284#comment-15523284 ] Arun Suresh commented on YARN-5609: --- Thanks for the reviews and the commit [~jianhe] > Expose upgrade

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522748#comment-15522748 ] Hadoop QA commented on YARN-5609: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522428#comment-15522428 ] Hadoop QA commented on YARN-5609: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-25 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520518#comment-15520518 ] Jian He commented on YARN-5609: --- yep, sounds good to me. > Expose upgrade and restart API in

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518418#comment-15518418 ] Hadoop QA commented on YARN-5609: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-23 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518409#comment-15518409 ] Arun Suresh commented on YARN-5609: --- Hmm.. so how about I put back the old {{setIsReinitializing(false)}}

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-23 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518350#comment-15518350 ] Jian He commented on YARN-5609: --- I see, I'm ok to not use the same method. The main thing I'm referring is

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-23 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518181#comment-15518181 ] Arun Suresh commented on YARN-5609: --- So, the container.setIsReInitializing(false) statements were

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-23 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518166#comment-15518166 ] Jian He commented on YARN-5609: --- I saw that the latest patch removed a couple occurrence of

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-23 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516704#comment-15516704 ] Arun Suresh commented on YARN-5609: --- The test case failures are not related to the patch.. > Expose

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516638#comment-15516638 ] Hadoop QA commented on YARN-5609: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-22 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513480#comment-15513480 ] Jian He commented on YARN-5609: --- looks good to me overall, I think wherever {{setIsReInitializing(false)}}

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-21 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512233#comment-15512233 ] Arun Suresh commented on YARN-5609: --- true... which is why the tests were passing in both cases... but I

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-21 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512205#comment-15512205 ] Jian He commented on YARN-5609: --- IIUC, even if it's a merged operation, the current will be a superset of

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-21 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512203#comment-15512203 ] Jian He commented on YARN-5609: --- IIUC, even if it's a merged operation, the current will be a superset of

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-21 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512144#comment-15512144 ] Arun Suresh commented on YARN-5609: --- bq. during rollback, we should not merge the current resourceSet

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-21 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512108#comment-15512108 ] Jian He commented on YARN-5609: --- bq. during rollback, we should not merge the current resourceSet with new

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510858#comment-15510858 ] Hadoop QA commented on YARN-5609: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-21 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510471#comment-15510471 ] Arun Suresh commented on YARN-5609: --- Ah ok (you mean v006).. sure.. I had found a minor bug in that

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-21 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510458#comment-15510458 ] Jian He commented on YARN-5609: --- Yep, what I meant is the second last patch is fine, as the issue I raised

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-21 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510384#comment-15510384 ] Arun Suresh commented on YARN-5609: --- bq. User anyway has to provide the full set of resources via the

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-21 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510111#comment-15510111 ] Jian He commented on YARN-5609: --- I had re-checked the code... actually, even the old resources will also not

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509580#comment-15509580 ] Hadoop QA commented on YARN-5609: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508807#comment-15508807 ] Hadoop QA commented on YARN-5609: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-20 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508770#comment-15508770 ] Jian He commented on YARN-5609: --- bq. since it is always called in conjunctions with a

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-20 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508741#comment-15508741 ] Jian He commented on YARN-5609: --- bq. I had intentionally kept it that way (my thinking was that the Tracker

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508366#comment-15508366 ] Hadoop QA commented on YARN-5609: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507633#comment-15507633 ] Hadoop QA commented on YARN-5609: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506069#comment-15506069 ] Hadoop QA commented on YARN-5609: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-20 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506031#comment-15506031 ] Jian He commented on YARN-5609: --- - I think this will cause the resources to be re-requested on restart. Even

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-19 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505585#comment-15505585 ] Jian He commented on YARN-5609: --- Thanks Arun, some more comments: - IIUC, when restarting the container, the

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504469#comment-15504469 ] Hadoop QA commented on YARN-5609: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-19 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503725#comment-15503725 ] Jian He commented on YARN-5609: --- - Can you add comments in commitLastReInitialization that once committed,

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503175#comment-15503175 ] Hadoop QA commented on YARN-5609: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-19 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502785#comment-15502785 ] Jian He commented on YARN-5609: --- Yes, it'll be sever-side changes and a bit of client. > Expose upgrade and

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-19 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502727#comment-15502727 ] Arun Suresh commented on YARN-5609: --- Yup.. that definitely makes sense.. happy to help with the reviews

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-19 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502625#comment-15502625 ] Jian He commented on YARN-5609: --- Also, I plan to use HADOOP-11552 for the relocalize API so that AM does not

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-18 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502265#comment-15502265 ] Arun Suresh commented on YARN-5609: --- Yup... thats the way I plan to implement it... > Expose upgrade and

[jira] [Commented] (YARN-5609) Expose upgrade and restart API in ContainerManagementProtocol

2016-09-18 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502259#comment-15502259 ] Jian He commented on YARN-5609: --- one question, what is the difference between restartContainer and