[jira] [Commented] (YARN-5642) Typos in 9 log messages
[
https://issues.apache.org/jira/browse/YARN-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498220#comment-15498220
]
Hudson commented on YARN-5642:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10454 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/10454/])
YARN-5642. Typos in 9 log messages. Contributed by Mehran Hassani
(naganarasimha_gr: rev 4174b9756c8c7877797545c4356b1f40df603ec5)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/YarnAuthorizationProvider.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/FileSystemApplicationHistoryStore.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/ParentQueue.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/AsyncDispatcher.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/AbstractReservationSystem.java
> Typos in 9 log messages
>
>
> Key: YARN-5642
> URL: https://issues.apache.org/jira/browse/YARN-5642
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Mehran Hassani
>Assignee: Mehran Hassani
>Priority: Trivial
> Labels: newbie
> Fix For: 2.9.0, 3.0.0-alpha2
>
> Attachments: YARN-5642.001.patch, YARN-5642.002.patch
>
>
> I am conducting research on log related bugs. I tried to make a tool to fix
> repetitive yet simple patterns of bugs that are related to logs. Typos in log
> messages are one of the reoccurring bugs. Therefore, I made a tool find typos
> in log statements. During my experiments, I managed to find the following
> typos in Hadoop YARN:
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/AsyncDispatcher.java,
> LOG.info("AsyncDispatcher is draining to stop igonring any new events."),
> igonring should be ignoring
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/YarnAuthorizationProvider.java,
> LOG.info(authorizerClass.getName() + " is instiantiated."),
> instiantiated should be instantiated
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/FileSystemApplicationHistoryStore.java,
> LOG.info("Completed reading history information of all conatiners"+ " of
> application attempt " + appAttemptId),
> conatiners should be containers
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java,
> LOG.info("Neither virutal-memory nor physical-memory monitoring is "
> +"needed. Not running the monitor-thread"),
> virutal should be virtual
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/AbstractReservationSystem.java,
> LOG.info("Intialized plan {} based on reservable queue {}" plan.toString()
> planQueueName),
> Intialized should be Initialized
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java,
> LOG.info("Initializing " + queueName + "\n" +"capacity = " +
> queueCapacities.getCapacity() +" [= (float) configuredCapacity / 100 ]" +
> "\n" +"asboluteCapacity = " + queueCapacities.getAbsoluteCapacity() +" [=
> parentAbsoluteCapacity * capacity ]" + "\n" +"maxCapacity = " +
> queueCapacities.getMaximumCapacity() +" [= configuredMaxCapacity ]" + "\n"
> +"absoluteMaxCapacity = " + queueCapacities.getAbsoluteMaximumCapacity() +"
> [= 1.0 maximumCapacity undefined "
[jira] [Commented] (YARN-5642) Typos in 9 log messages
[
https://issues.apache.org/jira/browse/YARN-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496856#comment-15496856
]
Hadoop QA commented on YARN-5642:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
53s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 19s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 56s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
56s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 5s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 20s
{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
35s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 16s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 16s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 37s
{color} | {color:red} hadoop-yarn-project/hadoop-yarn: The patch generated 1
new + 231 unchanged - 1 fixed = 232 total (was 232) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 49s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
49s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 11s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 17s
{color} | {color:green} hadoop-yarn-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 14m 11s {color}
| {color:red} hadoop-yarn-server-nodemanager in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 10s {color}
| {color:red} hadoop-yarn-server-applicationhistoryservice in the patch failed.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 39m 4s
{color} | {color:green} hadoop-yarn-server-resourcemanager in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 89m 34s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor |
| | hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12828844/YARN-5642.002.patch |
| JIRA Issue | YARN-5642 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 439e1ff02c70 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64
[jira] [Commented] (YARN-5642) Typos in 9 log messages
[
https://issues.apache.org/jira/browse/YARN-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496317#comment-15496317
]
Mehran Hassani commented on YARN-5642:
--
Thanks, will do shortly and add a new patch.
> Typos in 9 log messages
>
>
> Key: YARN-5642
> URL: https://issues.apache.org/jira/browse/YARN-5642
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Mehran Hassani
>Assignee: Mehran Hassani
>Priority: Trivial
> Labels: newbie
> Attachments: YARN-5642.001.patch
>
>
> I am conducting research on log related bugs. I tried to make a tool to fix
> repetitive yet simple patterns of bugs that are related to logs. Typos in log
> messages are one of the reoccurring bugs. Therefore, I made a tool find typos
> in log statements. During my experiments, I managed to find the following
> typos in Hadoop YARN:
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/AsyncDispatcher.java,
> LOG.info("AsyncDispatcher is draining to stop igonring any new events."),
> igonring should be ignoring
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/YarnAuthorizationProvider.java,
> LOG.info(authorizerClass.getName() + " is instiantiated."),
> instiantiated should be instantiated
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/FileSystemApplicationHistoryStore.java,
> LOG.info("Completed reading history information of all conatiners"+ " of
> application attempt " + appAttemptId),
> conatiners should be containers
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java,
> LOG.info("Neither virutal-memory nor physical-memory monitoring is "
> +"needed. Not running the monitor-thread"),
> virutal should be virtual
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/AbstractReservationSystem.java,
> LOG.info("Intialized plan {} based on reservable queue {}" plan.toString()
> planQueueName),
> Intialized should be Initialized
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java,
> LOG.info("Initializing " + queueName + "\n" +"capacity = " +
> queueCapacities.getCapacity() +" [= (float) configuredCapacity / 100 ]" +
> "\n" +"asboluteCapacity = " + queueCapacities.getAbsoluteCapacity() +" [=
> parentAbsoluteCapacity * capacity ]" + "\n" +"maxCapacity = " +
> queueCapacities.getMaximumCapacity() +" [= configuredMaxCapacity ]" + "\n"
> +"absoluteMaxCapacity = " + queueCapacities.getAbsoluteMaximumCapacity() +"
> [= 1.0 maximumCapacity undefined " +"(parentAbsoluteMaxCapacity *
> maximumCapacity) / 100 otherwise ]" +"\n" +"userLimit = " + userLimit +" [=
> configuredUserLimit ]" + "\n" +"userLimitFactor = " + userLimitFactor +" [=
> configuredUserLimitFactor ]" + "\n" +"maxApplications = " + maxApplications
> +" [= configuredMaximumSystemApplicationsPerQueue or" +"
> (int)(configuredMaximumSystemApplications * absoluteCapacity)]" +"\n"
> +"maxApplicationsPerUser = " + maxApplicationsPerUser +" [=
> (int)(maxApplications * (userLimit / 100.0f) * " +"userLimitFactor) ]" + "\n"
> +"usedCapacity = " + queueCapacities.getUsedCapacity() +" [=
> usedResourcesMemory / " +"(clusterResourceMemory * absoluteCapacity)]" + "\n"
> +"absoluteUsedCapacity = " + absoluteUsedCapacity +" [= usedResourcesMemory /
> clusterResourceMemory]" + "\n" +"maxAMResourcePerQueuePercent = " +
> maxAMResourcePerQueuePercent +" [= configuredMaximumAMResourcePercent ]" +
> "\n" +"minimumAllocationFactor = " + minimumAllocationFactor +" [=
> (float)(maximumAllocationMemory - minimumAllocationMemory) / "
> +"maximumAllocationMemory ]" + "\n" +"maximumAllocation = " +
> maximumAllocation +" [= configuredMaxAllocation ]" + "\n" +"numContainers = "
> + numContainers +" [= currentNumContainers ]" + "\n" +"state = " + state +"
> [= configuredState ]" + "\n" +"acls = " + aclsString +" [= configuredAcls ]"
> + "\n" +"nodeLocalityDelay = " + nodeLocalityDelay + "\n" +"labels=" +
> labelStrBuilder.toString() + "\n" +"reservationsContinueLooking = "
> +reservationsContinueLooking + "\n" +"preemptionDisabled = " +
> getPreemptionDisabled() + "\n" +"defaultAppPriorityPerQueue = " +
> defaultAppPriorityPerQueue),
> asbolute should be absolute
> In file
>
[jira] [Commented] (YARN-5642) Typos in 9 log messages
[
https://issues.apache.org/jira/browse/YARN-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496311#comment-15496311
]
Naganarasimha G R commented on YARN-5642:
-
Have assigned the jira to you [~MehranHassani]! and yes you need to get the
latest code and apply the modifications again
> Typos in 9 log messages
>
>
> Key: YARN-5642
> URL: https://issues.apache.org/jira/browse/YARN-5642
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Mehran Hassani
>Assignee: Mehran Hassani
>Priority: Trivial
> Labels: newbie
> Attachments: YARN-5642.001.patch
>
>
> I am conducting research on log related bugs. I tried to make a tool to fix
> repetitive yet simple patterns of bugs that are related to logs. Typos in log
> messages are one of the reoccurring bugs. Therefore, I made a tool find typos
> in log statements. During my experiments, I managed to find the following
> typos in Hadoop YARN:
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/AsyncDispatcher.java,
> LOG.info("AsyncDispatcher is draining to stop igonring any new events."),
> igonring should be ignoring
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/YarnAuthorizationProvider.java,
> LOG.info(authorizerClass.getName() + " is instiantiated."),
> instiantiated should be instantiated
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/FileSystemApplicationHistoryStore.java,
> LOG.info("Completed reading history information of all conatiners"+ " of
> application attempt " + appAttemptId),
> conatiners should be containers
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java,
> LOG.info("Neither virutal-memory nor physical-memory monitoring is "
> +"needed. Not running the monitor-thread"),
> virutal should be virtual
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/AbstractReservationSystem.java,
> LOG.info("Intialized plan {} based on reservable queue {}" plan.toString()
> planQueueName),
> Intialized should be Initialized
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java,
> LOG.info("Initializing " + queueName + "\n" +"capacity = " +
> queueCapacities.getCapacity() +" [= (float) configuredCapacity / 100 ]" +
> "\n" +"asboluteCapacity = " + queueCapacities.getAbsoluteCapacity() +" [=
> parentAbsoluteCapacity * capacity ]" + "\n" +"maxCapacity = " +
> queueCapacities.getMaximumCapacity() +" [= configuredMaxCapacity ]" + "\n"
> +"absoluteMaxCapacity = " + queueCapacities.getAbsoluteMaximumCapacity() +"
> [= 1.0 maximumCapacity undefined " +"(parentAbsoluteMaxCapacity *
> maximumCapacity) / 100 otherwise ]" +"\n" +"userLimit = " + userLimit +" [=
> configuredUserLimit ]" + "\n" +"userLimitFactor = " + userLimitFactor +" [=
> configuredUserLimitFactor ]" + "\n" +"maxApplications = " + maxApplications
> +" [= configuredMaximumSystemApplicationsPerQueue or" +"
> (int)(configuredMaximumSystemApplications * absoluteCapacity)]" +"\n"
> +"maxApplicationsPerUser = " + maxApplicationsPerUser +" [=
> (int)(maxApplications * (userLimit / 100.0f) * " +"userLimitFactor) ]" + "\n"
> +"usedCapacity = " + queueCapacities.getUsedCapacity() +" [=
> usedResourcesMemory / " +"(clusterResourceMemory * absoluteCapacity)]" + "\n"
> +"absoluteUsedCapacity = " + absoluteUsedCapacity +" [= usedResourcesMemory /
> clusterResourceMemory]" + "\n" +"maxAMResourcePerQueuePercent = " +
> maxAMResourcePerQueuePercent +" [= configuredMaximumAMResourcePercent ]" +
> "\n" +"minimumAllocationFactor = " + minimumAllocationFactor +" [=
> (float)(maximumAllocationMemory - minimumAllocationMemory) / "
> +"maximumAllocationMemory ]" + "\n" +"maximumAllocation = " +
> maximumAllocation +" [= configuredMaxAllocation ]" + "\n" +"numContainers = "
> + numContainers +" [= currentNumContainers ]" + "\n" +"state = " + state +"
> [= configuredState ]" + "\n" +"acls = " + aclsString +" [= configuredAcls ]"
> + "\n" +"nodeLocalityDelay = " + nodeLocalityDelay + "\n" +"labels=" +
> labelStrBuilder.toString() + "\n" +"reservationsContinueLooking = "
> +reservationsContinueLooking + "\n" +"preemptionDisabled = " +
> getPreemptionDisabled() + "\n" +"defaultAppPriorityPerQueue = " +
>
[jira] [Commented] (YARN-5642) Typos in 9 log messages
[
https://issues.apache.org/jira/browse/YARN-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495042#comment-15495042
]
Mehran Hassani commented on YARN-5642:
--
This means my patch has conflicts with the trunk ?
> Typos in 9 log messages
>
>
> Key: YARN-5642
> URL: https://issues.apache.org/jira/browse/YARN-5642
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Mehran Hassani
>Priority: Trivial
> Labels: newbie
> Attachments: YARN-5642.001.patch
>
>
> I am conducting research on log related bugs. I tried to make a tool to fix
> repetitive yet simple patterns of bugs that are related to logs. Typos in log
> messages are one of the reoccurring bugs. Therefore, I made a tool find typos
> in log statements. During my experiments, I managed to find the following
> typos in Hadoop YARN:
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/AsyncDispatcher.java,
> LOG.info("AsyncDispatcher is draining to stop igonring any new events."),
> igonring should be ignoring
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/YarnAuthorizationProvider.java,
> LOG.info(authorizerClass.getName() + " is instiantiated."),
> instiantiated should be instantiated
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/FileSystemApplicationHistoryStore.java,
> LOG.info("Completed reading history information of all conatiners"+ " of
> application attempt " + appAttemptId),
> conatiners should be containers
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java,
> LOG.info("Neither virutal-memory nor physical-memory monitoring is "
> +"needed. Not running the monitor-thread"),
> virutal should be virtual
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/AbstractReservationSystem.java,
> LOG.info("Intialized plan {} based on reservable queue {}" plan.toString()
> planQueueName),
> Intialized should be Initialized
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java,
> LOG.info("Initializing " + queueName + "\n" +"capacity = " +
> queueCapacities.getCapacity() +" [= (float) configuredCapacity / 100 ]" +
> "\n" +"asboluteCapacity = " + queueCapacities.getAbsoluteCapacity() +" [=
> parentAbsoluteCapacity * capacity ]" + "\n" +"maxCapacity = " +
> queueCapacities.getMaximumCapacity() +" [= configuredMaxCapacity ]" + "\n"
> +"absoluteMaxCapacity = " + queueCapacities.getAbsoluteMaximumCapacity() +"
> [= 1.0 maximumCapacity undefined " +"(parentAbsoluteMaxCapacity *
> maximumCapacity) / 100 otherwise ]" +"\n" +"userLimit = " + userLimit +" [=
> configuredUserLimit ]" + "\n" +"userLimitFactor = " + userLimitFactor +" [=
> configuredUserLimitFactor ]" + "\n" +"maxApplications = " + maxApplications
> +" [= configuredMaximumSystemApplicationsPerQueue or" +"
> (int)(configuredMaximumSystemApplications * absoluteCapacity)]" +"\n"
> +"maxApplicationsPerUser = " + maxApplicationsPerUser +" [=
> (int)(maxApplications * (userLimit / 100.0f) * " +"userLimitFactor) ]" + "\n"
> +"usedCapacity = " + queueCapacities.getUsedCapacity() +" [=
> usedResourcesMemory / " +"(clusterResourceMemory * absoluteCapacity)]" + "\n"
> +"absoluteUsedCapacity = " + absoluteUsedCapacity +" [= usedResourcesMemory /
> clusterResourceMemory]" + "\n" +"maxAMResourcePerQueuePercent = " +
> maxAMResourcePerQueuePercent +" [= configuredMaximumAMResourcePercent ]" +
> "\n" +"minimumAllocationFactor = " + minimumAllocationFactor +" [=
> (float)(maximumAllocationMemory - minimumAllocationMemory) / "
> +"maximumAllocationMemory ]" + "\n" +"maximumAllocation = " +
> maximumAllocation +" [= configuredMaxAllocation ]" + "\n" +"numContainers = "
> + numContainers +" [= currentNumContainers ]" + "\n" +"state = " + state +"
> [= configuredState ]" + "\n" +"acls = " + aclsString +" [= configuredAcls ]"
> + "\n" +"nodeLocalityDelay = " + nodeLocalityDelay + "\n" +"labels=" +
> labelStrBuilder.toString() + "\n" +"reservationsContinueLooking = "
> +reservationsContinueLooking + "\n" +"preemptionDisabled = " +
> getPreemptionDisabled() + "\n" +"defaultAppPriorityPerQueue = " +
> defaultAppPriorityPerQueue),
> asbolute should be absolute
> In file
>
[jira] [Commented] (YARN-5642) Typos in 9 log messages
[
https://issues.apache.org/jira/browse/YARN-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495027#comment-15495027
]
Hadoop QA commented on YARN-5642:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s {color}
| {color:red} YARN-5642 does not apply to trunk. Rebase required? Wrong Branch?
See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12828778/YARN-5642.001.patch |
| JIRA Issue | YARN-5642 |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/13119/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Typos in 9 log messages
>
>
> Key: YARN-5642
> URL: https://issues.apache.org/jira/browse/YARN-5642
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Mehran Hassani
>Priority: Trivial
> Labels: newbie
> Attachments: YARN-5642.001.patch
>
>
> I am conducting research on log related bugs. I tried to make a tool to fix
> repetitive yet simple patterns of bugs that are related to logs. Typos in log
> messages are one of the reoccurring bugs. Therefore, I made a tool find typos
> in log statements. During my experiments, I managed to find the following
> typos in Hadoop YARN:
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/AsyncDispatcher.java,
> LOG.info("AsyncDispatcher is draining to stop igonring any new events."),
> igonring should be ignoring
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/YarnAuthorizationProvider.java,
> LOG.info(authorizerClass.getName() + " is instiantiated."),
> instiantiated should be instantiated
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/FileSystemApplicationHistoryStore.java,
> LOG.info("Completed reading history information of all conatiners"+ " of
> application attempt " + appAttemptId),
> conatiners should be containers
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java,
> LOG.info("Neither virutal-memory nor physical-memory monitoring is "
> +"needed. Not running the monitor-thread"),
> virutal should be virtual
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/AbstractReservationSystem.java,
> LOG.info("Intialized plan {} based on reservable queue {}" plan.toString()
> planQueueName),
> Intialized should be Initialized
> In file
> /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java,
> LOG.info("Initializing " + queueName + "\n" +"capacity = " +
> queueCapacities.getCapacity() +" [= (float) configuredCapacity / 100 ]" +
> "\n" +"asboluteCapacity = " + queueCapacities.getAbsoluteCapacity() +" [=
> parentAbsoluteCapacity * capacity ]" + "\n" +"maxCapacity = " +
> queueCapacities.getMaximumCapacity() +" [= configuredMaxCapacity ]" + "\n"
> +"absoluteMaxCapacity = " + queueCapacities.getAbsoluteMaximumCapacity() +"
> [= 1.0 maximumCapacity undefined " +"(parentAbsoluteMaxCapacity *
> maximumCapacity) / 100 otherwise ]" +"\n" +"userLimit = " + userLimit +" [=
> configuredUserLimit ]" + "\n" +"userLimitFactor = " + userLimitFactor +" [=
> configuredUserLimitFactor ]" + "\n" +"maxApplications = " + maxApplications
> +" [= configuredMaximumSystemApplicationsPerQueue or" +"
> (int)(configuredMaximumSystemApplications * absoluteCapacity)]" +"\n"
> +"maxApplicationsPerUser = " + maxApplicationsPerUser +" [=
> (int)(maxApplications * (userLimit / 100.0f) * " +"userLimitFactor) ]" + "\n"
> +"usedCapacity = " + queueCapacities.getUsedCapacity() +" [=
> usedResourcesMemory / " +"(clusterResourceMemory * absoluteCapacity)]" + "\n"
> +"absoluteUsedCapacity = " + absoluteUsedCapacity +" [= usedResourcesMemory /
> clusterResourceMemory]" + "\n" +"maxAMResourcePerQueuePercent = " +
> maxAMResourcePerQueuePercent +" [= configuredMaximumAMResourcePercent ]" +
> "\n" +"minimumAllocationFactor = " + minimumAllocationFactor +" [=
>
