[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2017-08-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146720#comment-16146720 ] Hudson commented on YARN-5715: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1227

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-27 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614157#comment-15614157 ] Rohith Sharma K S commented on YARN-5715: - Thanks [~sjlee0] [~varun_saxena] [~gtCar

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-27 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613493#comment-15613493 ] Sangjin Lee commented on YARN-5715: --- Filed YARN-5792 for the above. > introduce entity p

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-27 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612940#comment-15612940 ] Sangjin Lee commented on YARN-5715: --- [~rohithsharma], I'll take the liberty of modifying

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-27 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612857#comment-15612857 ] Sangjin Lee commented on YARN-5715: --- This should be good to go if the above is addressed.

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-27 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612752#comment-15612752 ] Varun Saxena commented on YARN-5715: [~rohithsharma], I think this is good to go once y

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-21 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15596324#comment-15596324 ] Varun Saxena commented on YARN-5715: Thanks [~rohithsharma] for the patch. It looks go

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595052#comment-15595052 ] Hadoop QA commented on YARN-5715: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-20 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593274#comment-15593274 ] Sangjin Lee commented on YARN-5715: --- The jenkins appears to be unstable right now, and th

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-20 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15592457#comment-15592457 ] Varun Saxena commented on YARN-5715: bq. it is for more than 7 parameters. Sorry mixed

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-20 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15592348#comment-15592348 ] Sangjin Lee commented on YARN-5715: --- bq. Regarding Li's comment, we should have a constan

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-20 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15592343#comment-15592343 ] Rohith Sharma K S commented on YARN-5715: - bq. Checkstyle is related. it is for mor

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-20 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591602#comment-15591602 ] Varun Saxena commented on YARN-5715: Thanks [~rohithsharma] for the patch. Patch looks

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591547#comment-15591547 ] Hadoop QA commented on YARN-5715: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-20 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591509#comment-15591509 ] Rohith Sharma K S commented on YARN-5715: - bq. I think it might be helpful to have

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-18 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587562#comment-15587562 ] Rohith Sharma K S commented on YARN-5715: - Sure, I will include in next patch. > i

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-18 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587089#comment-15587089 ] Li Lu commented on YARN-5715: - I prefer the approach to provide an utility method to invert lon

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586951#comment-15586951 ] Sangjin Lee commented on YARN-5715: --- Yes, that sounds like a good idea. [~rohithsharma],

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-18 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586491#comment-15586491 ] Varun Saxena commented on YARN-5715: [~sjlee0], we have a class TimelineServiceHelper i

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586228#comment-15586228 ] Sangjin Lee commented on YARN-5715: --- That sounds reasonable. I haven't checked, but don't

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-18 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586168#comment-15586168 ] Varun Saxena commented on YARN-5715: I think we can create a separate TimelineUtils cla

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-18 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586123#comment-15586123 ] Sangjin Lee commented on YARN-5715: --- Thanks for bringing up the uid. Yes, I agree it is p

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-18 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585839#comment-15585839 ] Varun Saxena commented on YARN-5715: bq. I think we should discuss another point that d

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-18 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585744#comment-15585744 ] Rohith Sharma K S commented on YARN-5715: - bq. What do others think? As a user, I w

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-17 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584596#comment-15584596 ] Varun Saxena commented on YARN-5715: [~sjlee0] bq. I think it’s fine either way, altho

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-17 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583379#comment-15583379 ] Sangjin Lee commented on YARN-5715: --- Thanks for the patch [~rohithsharma]! I think one t

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576474#comment-15576474 ] Varun Saxena commented on YARN-5715: Changes related to TimelineReaderContext should be

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572451#comment-15572451 ] Varun Saxena commented on YARN-5715: bq. Here, we can not use bytes as directory. I thi

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571362#comment-15571362 ] Hadoop QA commented on YARN-5715: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570865#comment-15570865 ] Hadoop QA commented on YARN-5715: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-12 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569074#comment-15569074 ] Rohith Sharma K S commented on YARN-5715: - bq. As we are setting entity ID prefix t

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-12 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569043#comment-15569043 ] Varun Saxena commented on YARN-5715: Sorry hadn't read the description. Read part will

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-12 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569033#comment-15569033 ] Varun Saxena commented on YARN-5715: Thanks [~rohithsharma] for the patch. As we are s

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-12 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568985#comment-15568985 ] Rohith Sharma K S commented on YARN-5715: - Pending : # need up update same behavior

[jira] [Commented] (YARN-5715) introduce entity prefix for return and sort order

2016-10-06 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553462#comment-15553462 ] Sangjin Lee commented on YARN-5715: --- During the call, I was thinking we might want to hav