[
https://issues.apache.org/jira/browse/YARN-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971879#comment-15971879
]
Hadoop QA commented on YARN-6451:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971807#comment-15971807
]
Carlo Curino commented on YARN-6451:
Good call. I implemented the *fast* check all invariant at once,
[
https://issues.apache.org/jira/browse/YARN-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971709#comment-15971709
]
Chris Douglas commented on YARN-6451:
-
bq. when invariants are violated the log line is harder to read
[
https://issues.apache.org/jira/browse/YARN-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971619#comment-15971619
]
Hadoop QA commented on YARN-6451:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971530#comment-15971530
]
Carlo Curino commented on YARN-6451:
Thanks [~chris.douglas] for the feedback.
# I did the
[
https://issues.apache.org/jira/browse/YARN-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966500#comment-15966500
]
Chris Douglas commented on YARN-6451:
-
Cool, I hadn't seen the {{javax.script}} package before.
[
https://issues.apache.org/jira/browse/YARN-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966031#comment-15966031
]
Carlo Curino commented on YARN-6451:
Some more cleanup.
> Create a monitor to check whether we
[
https://issues.apache.org/jira/browse/YARN-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961521#comment-15961521
]
Carlo Curino commented on YARN-6451:
[~jlowe] I think the inline asserts might be useful particularly
[
https://issues.apache.org/jira/browse/YARN-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961022#comment-15961022
]
Jason Lowe commented on YARN-6451:
--
Interesting idea. For some of these invariants, would it make more
[
https://issues.apache.org/jira/browse/YARN-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960186#comment-15960186
]
Hadoop QA commented on YARN-6451:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960011#comment-15960011
]
Hadoop QA commented on YARN-6451:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959937#comment-15959937
]
Carlo Curino commented on YARN-6451:
The patch provides and initial implementation of this idea. It
12 matches
Mail list logo