[jira] [Commented] (YARN-654) AMRMClient: Perform sanity checks for parameters of public methods
[ https://issues.apache.org/jira/browse/YARN-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709673#comment-13709673 ] Hudson commented on YARN-654: - FAILURE: Integrated in Hadoop-Yarn-trunk #272 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/272/]) YARN-654. AMRMClient: Perform sanity checks for parameters of public methods (Xuan Gong via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1503353) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AMRMClient.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java AMRMClient: Perform sanity checks for parameters of public methods -- Key: YARN-654 URL: https://issues.apache.org/jira/browse/YARN-654 Project: Hadoop YARN Issue Type: Bug Reporter: Bikas Saha Assignee: Xuan Gong Fix For: 2.1.0-beta Attachments: YARN-654.1.patch, YARN-654.2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-654) AMRMClient: Perform sanity checks for parameters of public methods
[ https://issues.apache.org/jira/browse/YARN-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709751#comment-13709751 ] Hudson commented on YARN-654: - FAILURE: Integrated in Hadoop-Hdfs-trunk #1462 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1462/]) YARN-654. AMRMClient: Perform sanity checks for parameters of public methods (Xuan Gong via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1503353) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AMRMClient.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java AMRMClient: Perform sanity checks for parameters of public methods -- Key: YARN-654 URL: https://issues.apache.org/jira/browse/YARN-654 Project: Hadoop YARN Issue Type: Bug Reporter: Bikas Saha Assignee: Xuan Gong Fix For: 2.1.0-beta Attachments: YARN-654.1.patch, YARN-654.2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-654) AMRMClient: Perform sanity checks for parameters of public methods
[ https://issues.apache.org/jira/browse/YARN-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709815#comment-13709815 ] Hudson commented on YARN-654: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1489 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1489/]) YARN-654. AMRMClient: Perform sanity checks for parameters of public methods (Xuan Gong via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1503353) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AMRMClient.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java AMRMClient: Perform sanity checks for parameters of public methods -- Key: YARN-654 URL: https://issues.apache.org/jira/browse/YARN-654 Project: Hadoop YARN Issue Type: Bug Reporter: Bikas Saha Assignee: Xuan Gong Fix For: 2.1.0-beta Attachments: YARN-654.1.patch, YARN-654.2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-654) AMRMClient: Perform sanity checks for parameters of public methods
[ https://issues.apache.org/jira/browse/YARN-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708680#comment-13708680 ] Hudson commented on YARN-654: - SUCCESS: Integrated in Hadoop-trunk-Commit #4082 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4082/]) YARN-654. AMRMClient: Perform sanity checks for parameters of public methods (Xuan Gong via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1503353) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AMRMClient.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java AMRMClient: Perform sanity checks for parameters of public methods -- Key: YARN-654 URL: https://issues.apache.org/jira/browse/YARN-654 Project: Hadoop YARN Issue Type: Bug Reporter: Bikas Saha Assignee: Xuan Gong Fix For: 2.1.0-beta Attachments: YARN-654.1.patch, YARN-654.2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-654) AMRMClient: Perform sanity checks for parameters of public methods
[ https://issues.apache.org/jira/browse/YARN-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709243#comment-13709243 ] Bikas Saha commented on YARN-654: - Sorry the minor change I made in the patch that changed =0 to 0 is wrong. I did not follow the code correctly. Fixing it in the commit for YARN-521. AMRMClient: Perform sanity checks for parameters of public methods -- Key: YARN-654 URL: https://issues.apache.org/jira/browse/YARN-654 Project: Hadoop YARN Issue Type: Bug Reporter: Bikas Saha Assignee: Xuan Gong Fix For: 2.1.0-beta Attachments: YARN-654.1.patch, YARN-654.2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-654) AMRMClient: Perform sanity checks for parameters of public methods
[ https://issues.apache.org/jira/browse/YARN-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708195#comment-13708195 ] Xuan Gong commented on YARN-654: bq.Is the test failure related? I do not think so. All tests are passing in my local machine. AMRMClient: Perform sanity checks for parameters of public methods -- Key: YARN-654 URL: https://issues.apache.org/jira/browse/YARN-654 Project: Hadoop YARN Issue Type: Bug Reporter: Bikas Saha Assignee: Xuan Gong Fix For: 2.1.0-beta Attachments: YARN-654.1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-654) AMRMClient: Perform sanity checks for parameters of public methods
[ https://issues.apache.org/jira/browse/YARN-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708196#comment-13708196 ] Xuan Gong commented on YARN-654: use Google preconditions and throw standard IllegalArgumentException. AMRMClient: Perform sanity checks for parameters of public methods -- Key: YARN-654 URL: https://issues.apache.org/jira/browse/YARN-654 Project: Hadoop YARN Issue Type: Bug Reporter: Bikas Saha Assignee: Xuan Gong Fix For: 2.1.0-beta Attachments: YARN-654.1.patch, YARN-654.2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-654) AMRMClient: Perform sanity checks for parameters of public methods
[ https://issues.apache.org/jira/browse/YARN-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707867#comment-13707867 ] Bikas Saha commented on YARN-654: - Is the test failure related? AMRMClient: Perform sanity checks for parameters of public methods -- Key: YARN-654 URL: https://issues.apache.org/jira/browse/YARN-654 Project: Hadoop YARN Issue Type: Bug Reporter: Bikas Saha Assignee: Xuan Gong Fix For: 2.1.0-beta Attachments: YARN-654.1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-654) AMRMClient: Perform sanity checks for parameters of public methods
[ https://issues.apache.org/jira/browse/YARN-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707868#comment-13707868 ] Bikas Saha commented on YARN-654: - It might be cleaner to use Google preconditions and throw standard IllegalArgumentException. http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/base/Preconditions.html AMRMClient: Perform sanity checks for parameters of public methods -- Key: YARN-654 URL: https://issues.apache.org/jira/browse/YARN-654 Project: Hadoop YARN Issue Type: Bug Reporter: Bikas Saha Assignee: Xuan Gong Fix For: 2.1.0-beta Attachments: YARN-654.1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-654) AMRMClient: Perform sanity checks for parameters of public methods
[
https://issues.apache.org/jira/browse/YARN-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705470#comment-13705470
]
Hadoop QA commented on YARN-654:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12591792/YARN-654.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client:
org.apache.hadoop.yarn.client.api.impl.TestNMClient
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/1457//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1457//console
This message is automatically generated.
AMRMClient: Perform sanity checks for parameters of public methods
--
Key: YARN-654
URL: https://issues.apache.org/jira/browse/YARN-654
Project: Hadoop YARN
Issue Type: Bug
Reporter: Bikas Saha
Assignee: Xuan Gong
Fix For: 2.1.0-beta
Attachments: YARN-654.1.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
