[ https://issues.apache.org/jira/browse/YARN-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053705#comment-16053705 ]
Peter Bacsko commented on YARN-6715: ------------------------------------ I've seen that there's already a case for this: https://issues.apache.org/jira/browse/YARN-5567 (thanks [~miklos.szeg...@cloudera.com] for linking). Shouldn't we at least update the Hadoop documentation and source code? https://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/NodeManager.html#External_Health_Script This page says "If the script *exits with a non-zero exit code*, times out or results in an exception being thrown, the node is marked as unhealthy" which is completely false and I was misled by this statement. I spent 2-3 hours figuring out why returning a non-zero doesn't work and eventually I had to debug the Node manager. > NodeHealthScriptRunner does not handle non-zero exit codes properly > ------------------------------------------------------------------- > > Key: YARN-6715 > URL: https://issues.apache.org/jira/browse/YARN-6715 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Reporter: Peter Bacsko > > There is a bug in NodeHealthScriptRunner. The {{FAILED_WITH_EXIT_CODE}} case > is incorrect: > {noformat} > void reportHealthStatus(HealthCheckerExitStatus status) { > long now = System.currentTimeMillis(); > switch (status) { > case SUCCESS: > setHealthStatus(true, "", now); > break; > case TIMED_OUT: > setHealthStatus(false, NODE_HEALTH_SCRIPT_TIMED_OUT_MSG); > break; > case FAILED_WITH_EXCEPTION: > setHealthStatus(false, exceptionStackTrace); > break; > case FAILED_WITH_EXIT_CODE: > setHealthStatus(true, "", now); > break; > case FAILED: > setHealthStatus(false, shexec.getOutput()); > break; > } > } > {noformat} > This case also lacks unit test coverage. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org