[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253981#comment-16253981
]
Hudson commented on YARN-6953:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1323
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253771#comment-16253771
]
Manikandan R commented on YARN-6953:
Sorry for the delay. Rebased patch.
> Clean up Re
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226789#comment-16226789
]
Sunil G commented on YARN-6953:
---
[~maniraj...@gmail.com], please help to rebase.
> Clean up
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225522#comment-16225522
]
Daniel Templeton commented on YARN-6953:
+1 from me as well, except that the patch
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218149#comment-16218149
]
Sunil G commented on YARN-6953:
---
+1. Committing later today if there are no objections.
> Cl
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216595#comment-16216595
]
Hadoop QA commented on YARN-6953:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216435#comment-16216435
]
Sunil G commented on YARN-6953:
---
Kicking jenkins again before committing. Pinging [~templedf]
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202415#comment-16202415
]
Manikandan R commented on YARN-6953:
Can we move ahead if patch is good?
> Clean up Re
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178837#comment-16178837
]
Sunil G commented on YARN-6953:
---
Latest patch seems fine (v8 patch). I will wait for [~dan...
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177714#comment-16177714
]
Hadoop QA commented on YARN-6953:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177700#comment-16177700
]
Manikandan R commented on YARN-6953:
Fixed checkstyle issues.
> Clean up ResourceUtils
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177476#comment-16177476
]
Hadoop QA commented on YARN-6953:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177473#comment-16177473
]
Manikandan R commented on YARN-6953:
[~wangda] Rebased patch with latest trunk and atta
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175558#comment-16175558
]
Wangda Tan commented on YARN-6953:
--
[~maniraj...@gmail.com], could you rebase patch to lat
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175294#comment-16175294
]
Hadoop QA commented on YARN-6953:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168480#comment-16168480
]
Daniel Templeton commented on YARN-6953:
LGTM +1
> Clean up ResourceUtils.setMinim
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154807#comment-16154807
]
Manikandan R commented on YARN-6953:
[~dan...@cloudera.com] Can you review the latest p
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151471#comment-16151471
]
Hadoop QA commented on YARN-6953:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151468#comment-16151468
]
Manikandan R commented on YARN-6953:
Thanks for details. DEBUG seems to be good fit. At
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150851#comment-16150851
]
Daniel Templeton commented on YARN-6953:
Looks good to me, though I'm a bit biased.
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150655#comment-16150655
]
Hadoop QA commented on YARN-6953:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150595#comment-16150595
]
Manikandan R commented on YARN-6953:
[~dan...@cloudera.com] Yes, we can go with your pa
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147614#comment-16147614
]
Daniel Templeton commented on YARN-6953:
Getting better. Still seems rather comple
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147545#comment-16147545
]
Manikandan R commented on YARN-6953:
[~dan...@cloudera.com] Can you share your views?
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125323#comment-16125323
]
Sunil G commented on YARN-6953:
---
Thanks [~maniraj...@gmail.com].
I also agree with [~dan...@
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124906#comment-16124906
]
Manikandan R commented on YARN-6953:
[~dan...@cloudera.com] Thanks for sharing your vie
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124048#comment-16124048
]
Daniel Templeton commented on YARN-6953:
I think the WIP is still much more complic
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120200#comment-16120200
]
Manikandan R commented on YARN-6953:
[~sunilg] Attached WIP patch to make sure changes
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119591#comment-16119591
]
Manikandan R commented on YARN-6953:
[~sunilg] Thanks for review.
Agree with your comm
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119495#comment-16119495
]
Sunil G commented on YARN-6953:
---
[~maniraj...@gmail.com], I could see that the optimization d
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118590#comment-16118590
]
Hadoop QA commented on YARN-6953:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118541#comment-16118541
]
Manikandan R commented on YARN-6953:
Fixed whitespace issues.
> Clean up ResourceUtils
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118340#comment-16118340
]
Hadoop QA commented on YARN-6953:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118304#comment-16118304
]
Manikandan R commented on YARN-6953:
Fixed checkstyle issues. Attached patch for review
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116987#comment-16116987
]
Hadoop QA commented on YARN-6953:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116945#comment-16116945
]
Manikandan R commented on YARN-6953:
Rebased my working patch and attached patch for re
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115456#comment-16115456
]
Hadoop QA commented on YARN-6953:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115384#comment-16115384
]
Manikandan R commented on YARN-6953:
Attached patch for review.
> Clean up ResourceUti
38 matches
Mail list logo