[jira] [Commented] (YARN-7006) [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol

2017-08-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146758#comment-16146758
 ] 

Hudson commented on YARN-7006:
--

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12271 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/12271/])
YARN-7006. [ATSv2 Security] Changes for authentication for (varunsaxena: rev 
b664569586db39647f15340ce82ccc0f0869897e)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/collectormanager/NMCollectorService.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/AuxServices.java
* (add) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/security/CollectorNodemanagerSecurityInfo.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/timelineservice/NMTimelinePublisher.java
* (add) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo


> [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol
> 
>
> Key: YARN-7006
> URL: https://issues.apache.org/jira/browse/YARN-7006
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: timelineserver
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>  Labels: yarn-5355-merge-blocker
> Fix For: YARN-5355
>
> Attachments: YARN-7006-YARN-5355.01.patch, 
> YARN-7006-YARN-5355.02.patch, YARN-7006-YARN-5355_branch2.addendum.01.patch
>
>
> Communication between Collector and NM is via RPC.
> We would do kerberos based authentication for communication between these 2 
> components, as of now.  Added SecurityInfo implementation for it.
> We can think of adding token based access once collector starts outside of NM.
> Also creation of timeline client within NMTimelinePublisher would be done 
> using NM login UGI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-7006) [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol

2017-08-18 Thread Jian He (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133574#comment-16133574
 ] 

Jian He commented on YARN-7006:
---

I just committed the addendum patch. Didn't run compilation before commit, my 
bad.

Thanks Rohith and Varun !

> [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol
> 
>
> Key: YARN-7006
> URL: https://issues.apache.org/jira/browse/YARN-7006
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: timelineserver
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>  Labels: yarn-5355-merge-blocker
> Fix For: YARN-5355
>
> Attachments: YARN-7006-YARN-5355.01.patch, 
> YARN-7006-YARN-5355.02.patch, YARN-7006-YARN-5355_branch2.addendum.01.patch
>
>
> Communication between Collector and NM is via RPC.
> We would do kerberos based authentication for communication between these 2 
> components, as of now.  Added SecurityInfo implementation for it.
> We can think of adding token based access once collector starts outside of NM.
> Also creation of timeline client within NMTimelinePublisher would be done 
> using NM login UGI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-7006) [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol

2017-08-18 Thread Rohith Sharma K S (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131898#comment-16131898
 ] 

Rohith Sharma K S commented on YARN-7006:
-

It appears YARN-5355_branch2 has compilation error. [~varun_saxena] do  you 
also face compilation error? If so addendum patch would be better.
{noformat}
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on 
project hadoop-yarn-server-nodemanager: Compilation failure
[ERROR] 
/Users/rohithsharmaks/repository/apache/commit-repos/YARN-5355_branch2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/timelineservice/NMTimelinePublisher.java:[414,59]
 local variable appId is accessed from within inner class; needs to be declared 
final
[ERROR] -> [Help 1]
{noformat}

> [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol
> 
>
> Key: YARN-7006
> URL: https://issues.apache.org/jira/browse/YARN-7006
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: timelineserver
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>  Labels: yarn-5355-merge-blocker
> Fix For: YARN-5355
>
> Attachments: YARN-7006-YARN-5355.01.patch, 
> YARN-7006-YARN-5355.02.patch
>
>
> Communication between Collector and NM is via RPC.
> We would do kerberos based authentication for communication between these 2 
> components, as of now.  Added SecurityInfo implementation for it.
> We can think of adding token based access once collector starts outside of NM.
> Also creation of timeline client within NMTimelinePublisher would be done 
> using NM login UGI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-7006) [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol

2017-08-17 Thread Jian He (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130937#comment-16130937
 ] 

Jian He commented on YARN-7006:
---

yep, just pulled into YARN-5355_branch2 

> [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol
> 
>
> Key: YARN-7006
> URL: https://issues.apache.org/jira/browse/YARN-7006
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: timelineserver
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>  Labels: yarn-5355-merge-blocker
> Fix For: YARN-5355
>
> Attachments: YARN-7006-YARN-5355.01.patch, 
> YARN-7006-YARN-5355.02.patch
>
>
> Communication between Collector and NM is via RPC.
> We would do kerberos based authentication for communication between these 2 
> components, as of now.  Added SecurityInfo implementation for it.
> We can think of adding token based access once collector starts outside of NM.
> Also creation of timeline client within NMTimelinePublisher would be done 
> using NM login UGI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-7006) [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol

2017-08-17 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130090#comment-16130090
 ] 

Varun Saxena commented on YARN-7006:


This needs to be pulled into YARN-5355_branch2 as well BTW.

> [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol
> 
>
> Key: YARN-7006
> URL: https://issues.apache.org/jira/browse/YARN-7006
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: timelineserver
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>  Labels: yarn-5355-merge-blocker
> Fix For: YARN-5355
>
> Attachments: YARN-7006-YARN-5355.01.patch, 
> YARN-7006-YARN-5355.02.patch
>
>
> Communication between Collector and NM is via RPC.
> We would do kerberos based authentication for communication between these 2 
> components, as of now.  Added SecurityInfo implementation for it.
> We can think of adding token based access once collector starts outside of NM.
> Also creation of timeline client within NMTimelinePublisher would be done 
> using NM login UGI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-7006) [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol

2017-08-17 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130089#comment-16130089
 ] 

Varun Saxena commented on YARN-7006:


Thanks [~jianhe] and [~rohithsharma].

> [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol
> 
>
> Key: YARN-7006
> URL: https://issues.apache.org/jira/browse/YARN-7006
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: timelineserver
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>  Labels: yarn-5355-merge-blocker
> Fix For: YARN-5355
>
> Attachments: YARN-7006-YARN-5355.01.patch, 
> YARN-7006-YARN-5355.02.patch
>
>
> Communication between Collector and NM is via RPC.
> We would do kerberos based authentication for communication between these 2 
> components, as of now.  Added SecurityInfo implementation for it.
> We can think of adding token based access once collector starts outside of NM.
> Also creation of timeline client within NMTimelinePublisher would be done 
> using NM login UGI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-7006) [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol

2017-08-16 Thread Rohith Sharma K S (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128555#comment-16128555
 ] 

Rohith Sharma K S commented on YARN-7006:
-

thanks [~varun_saxena] for the patch!
+1 lgtm as well

> [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol
> 
>
> Key: YARN-7006
> URL: https://issues.apache.org/jira/browse/YARN-7006
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: timelineserver
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>  Labels: yarn-5355-merge-blocker
> Attachments: YARN-7006-YARN-5355.01.patch, 
> YARN-7006-YARN-5355.02.patch
>
>
> Communication between Collector and NM is via RPC.
> We would do kerberos based authentication for communication between these 2 
> components, as of now.  Added SecurityInfo implementation for it.
> We can think of adding token based access once collector starts outside of NM.
> Also creation of timeline client within NMTimelinePublisher would be done 
> using NM login UGI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-7006) [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol

2017-08-16 Thread Jian He (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128424#comment-16128424
 ] 

Jian He commented on YARN-7006:
---

lgtm, [~rohithsharma], wanna take a look ?

> [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol
> 
>
> Key: YARN-7006
> URL: https://issues.apache.org/jira/browse/YARN-7006
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: timelineserver
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>  Labels: yarn-5355-merge-blocker
> Attachments: YARN-7006-YARN-5355.01.patch, 
> YARN-7006-YARN-5355.02.patch
>
>
> Communication between Collector and NM is via RPC.
> We would do kerberos based authentication for communication between these 2 
> components, as of now.  Added SecurityInfo implementation for it.
> We can think of adding token based access once collector starts outside of NM.
> Also creation of timeline client within NMTimelinePublisher would be done 
> using NM login UGI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-7006) [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol

2017-08-15 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127031#comment-16127031
 ] 

Varun Saxena commented on YARN-7006:


Thanks [~jianhe] for the review.
bq. why is this change required?
This is required because I noticed that we do not pass user from CotainerImpl, 
where CONTAINER_INIT Aux services event is generated. Hence the change.
We rely on this user(i.e. AM user) to fill owner of token.

This is not directly related to title of this JIRA and is bug in current code. 
As it was only one line change, I included it here instead of raising a new 
JIRA. 

> [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol
> 
>
> Key: YARN-7006
> URL: https://issues.apache.org/jira/browse/YARN-7006
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: timelineserver
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>  Labels: yarn-5355-merge-blocker
> Attachments: YARN-7006-YARN-5355.01.patch, 
> YARN-7006-YARN-5355.02.patch
>
>
> Communication between Collector and NM is via RPC.
> We would do kerberos based authentication for communication between these 2 
> components, as of now.  Added SecurityInfo implementation for it.
> We can think of adding token based access once collector starts outside of NM.
> Also creation of timeline client within NMTimelinePublisher would be done 
> using NM login UGI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-7006) [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol

2017-08-14 Thread Jian He (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126358#comment-16126358
 ] 

Jian He commented on YARN-7006:
---

looks good to me, one question, why is this change required?
{code}
-event.getUser(), event.getContainer().getContainerId(),
+event.getContainer().getUser(),
{code}

> [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol
> 
>
> Key: YARN-7006
> URL: https://issues.apache.org/jira/browse/YARN-7006
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: timelineserver
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>  Labels: yarn-5355-merge-blocker
> Attachments: YARN-7006-YARN-5355.01.patch, 
> YARN-7006-YARN-5355.02.patch
>
>
> Communication between Collector and NM is via RPC.
> We would do kerberos based authentication for communication between these 2 
> components, as of now.  Added SecurityInfo implementation for it.
> We can think of adding token based access once collector starts outside of NM.
> Also creation of timeline client within NMTimelinePublisher would be done 
> using NM login UGI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-7006) [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol

2017-08-14 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126126#comment-16126126
 ] 

Hadoop QA commented on YARN-7006:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 12m 
53s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} YARN-5355 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 
33s{color} | {color:green} YARN-5355 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
46s{color} | {color:green} YARN-5355 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
38s{color} | {color:green} YARN-5355 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
48s{color} | {color:green} YARN-5355 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
48s{color} | {color:red} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 in YARN-5355 has 5 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} YARN-5355 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m 
56s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
48s{color} | {color:green} hadoop-yarn-server-timelineservice in the patch 
passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
27s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 59m 12s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:0ac17dc |
| JIRA Issue | YARN-7006 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881789/YARN-7006-YARN-5355.02.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux 8d7fe00d494d 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | YARN-5355 / ee5d80d |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| findbugs | 
https://builds.apache.org/job/PreCommit-YARN-Build/16888/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/16888/testReport/ |
| modules | C: 

[jira] [Commented] (YARN-7006) [ATSv2 Security] Changes for authentication for CollectorNodemanagerProtocol

2017-08-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125067#comment-16125067
 ] 

Hadoop QA commented on YARN-7006:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m 
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} YARN-5355 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m 
 0s{color} | {color:green} YARN-5355 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
18s{color} | {color:green} YARN-5355 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
44s{color} | {color:green} YARN-5355 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
4s{color} | {color:green} YARN-5355 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m  
1s{color} | {color:red} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 in YARN-5355 has 5 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
43s{color} | {color:green} YARN-5355 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m  
4s{color} | {color:red} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 13m 
26s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
55s{color} | {color:green} hadoop-yarn-server-timelineservice in the patch 
passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
24s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 64m 50s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | 
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.yarn.server.nodemanager.timelineservice.NMTimelinePublisher.createTimelineClient(ApplicationId)
  At NMTimelinePublisher.java:is not thrown in 
org.apache.hadoop.yarn.server.nodemanager.timelineservice.NMTimelinePublisher.createTimelineClient(ApplicationId)
  At NMTimelinePublisher.java:[line 421] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:0ac17dc |
| JIRA Issue | YARN-7006 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881668/YARN-7006-YARN-5355.01.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux eda88642cecb