[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434525#comment-16434525 ] Eric Yang commented on YARN-7221: - [~billie.rinaldi] Thank you for the review and commit. [

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434403#comment-16434403 ] Hudson commented on YARN-7221: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1397

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434288#comment-16434288 ] Billie Rinaldi commented on YARN-7221: -- +1 for patch 22 as well. I think we have all a

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434092#comment-16434092 ] Shane Kumpf commented on YARN-7221: --- Thanks the updated patch, [~eyang]. The latest patch

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433162#comment-16433162 ] Eric Yang commented on YARN-7221: - TestContainerSchedulerQueuing unit test failure is not r

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433080#comment-16433080 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432936#comment-16432936 ] Eric Yang commented on YARN-7221: - Patch 22 rebased to current trunk. > Add security check

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432433#comment-16432433 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432393#comment-16432393 ] Eric Yang commented on YARN-7221: - Patch 21 Remove checkstyle error, and also removed group

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430726#comment-16430726 ] Eric Badger commented on YARN-7221: --- bq. Hi Eric Badger Jason Lowe, do we agree on the la

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430715#comment-16430715 ] Jason Lowe commented on YARN-7221: -- bq. do we agree on the last change to check submitting

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429360#comment-16429360 ] Shane Kumpf commented on YARN-7221: --- Thanks for the patch, [~eyang]. Sorry I'm just getti

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429031#comment-16429031 ] Eric Yang commented on YARN-7221: - Hi [~ebadger] [~jlowe], do we agree on the last change t

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428400#comment-16428400 ] Billie Rinaldi commented on YARN-7221: -- Thanks [~eyang], I am +1 for patch 020. > Add

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427866#comment-16427866 ] genericqa commented on YARN-7221: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427832#comment-16427832 ] Eric Yang commented on YARN-7221: - Patch 20 fixed test case errors. > Add security check f

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427802#comment-16427802 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427739#comment-16427739 ] Eric Yang commented on YARN-7221: - I agree with Billie that we want to check for submitting

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427683#comment-16427683 ] Billie Rinaldi commented on YARN-7221: -- I tried out patch 018. I only have one additio

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427611#comment-16427611 ] Jason Lowe commented on YARN-7221: -- Thanks for updating the patch! +1 latest patch looks

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427419#comment-16427419 ] genericqa commented on YARN-7221: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427229#comment-16427229 ] Eric Yang commented on YARN-7221: - [~jlowe] Thanks for the sample code. This sample code w

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426994#comment-16426994 ] Jason Lowe commented on YARN-7221: -- {quote}WNOHANG flag was used to track all child proces

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426398#comment-16426398 ] Eric Yang commented on YARN-7221: - [~jlowe] {quote} I don't think WNOHANG is appropriate he

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426061#comment-16426061 ] Jason Lowe commented on YARN-7221: -- Thanks for updating the patch! I don't think WNOHANG

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426040#comment-16426040 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425947#comment-16425947 ] Eric Yang commented on YARN-7221: - [~jlowe] Good catch on wait doesn't catch signals. Patc

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425548#comment-16425548 ] Jason Lowe commented on YARN-7221: -- Thanks for updating the patch! The unit test failure

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424779#comment-16424779 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424758#comment-16424758 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424725#comment-16424725 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424701#comment-16424701 ] Eric Yang commented on YARN-7221: - [~jlowe] Patch 16 avoids calling getgrouplist twice. >

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424690#comment-16424690 ] Eric Yang commented on YARN-7221: - [~jlowe] Sorry, my bad. I fixed the ngroup and dynamic

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424688#comment-16424688 ] Jason Lowe commented on YARN-7221: -- Thanks for updating the patch! The groups variable ne

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424630#comment-16424630 ] Jason Lowe commented on YARN-7221: -- Thanks for updating the patch! Curious, why does the

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424392#comment-16424392 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424264#comment-16424264 ] Eric Yang commented on YARN-7221: - - Patch 13 fixed ngroups allocation, and check_privilege

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424192#comment-16424192 ] Eric Yang commented on YARN-7221: - [~jlowe] [~ebadger] Thanks for the review. I will chang

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420561#comment-16420561 ] Eric Badger commented on YARN-7221: --- bq. Eric Badger said we are using 0 = true in c. The

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420558#comment-16420558 ] Jason Lowe commented on YARN-7221: -- But 0 does _not_ equal true in C, otherwise we would j

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420126#comment-16420126 ] Eric Yang commented on YARN-7221: - [~jlowe] Thanks for catching ngroups bug. I will fix it

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419890#comment-16419890 ] Jason Lowe commented on YARN-7221: -- Sorry to show up late, but there's an uninitialized va

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417963#comment-16417963 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417827#comment-16417827 ] Eric Yang commented on YARN-7221: - [~billie.rinaldi] Thank you for catching the defects. P

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417528#comment-16417528 ] Billie Rinaldi commented on YARN-7221: -- It looks like set_privileged is missing free(u

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416100#comment-16416100 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416041#comment-16416041 ] Eric Badger commented on YARN-7221: --- lgtm +1 (non-binding) > Add security check for priv

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415986#comment-16415986 ] Eric Yang commented on YARN-7221: - [~ebadger] Thank you for the review. I have updated pat

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415939#comment-16415939 ] Eric Badger commented on YARN-7221: --- Hey [~eyang], thanks for the update! {noformat} + g

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411594#comment-16411594 ] Eric Yang commented on YARN-7221: - [~ebadger] The unit test failure is not related to this

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410664#comment-16410664 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410577#comment-16410577 ] Eric Yang commented on YARN-7221: - - Patch 10, fixed formatting issue. > Add security chec

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408976#comment-16408976 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408838#comment-16408838 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408671#comment-16408671 ] Eric Yang commented on YARN-7221: - [~ebadger] Patch 09 will fail non-sudoers from launching

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408602#comment-16408602 ] Eric Yang commented on YARN-7221: - Summary of possible combination of sudo vs privileged im

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407164#comment-16407164 ] Eric Badger commented on YARN-7221: --- I must have misunderstood something we said in the m

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407125#comment-16407125 ] Eric Yang commented on YARN-7221: - [~ebadger] Thanks for the suggestions. I will update th

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407006#comment-16407006 ] Eric Badger commented on YARN-7221: --- Hey [~eyang], thanks for the new patch! I tried it o

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405438#comment-16405438 ] Eric Yang commented on YARN-7221: - The failed test cases are not related to this patch. >

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403199#comment-16403199 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403147#comment-16403147 ] Eric Yang commented on YARN-7221: - [~ebadger] Patch 7 fixes all of the errors mentioned abo

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401370#comment-16401370 ] Eric Yang commented on YARN-7221: - [~ebadger] Good points, I will update the patch to refle

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401161#comment-16401161 ] Eric Badger commented on YARN-7221: --- bq. Eric Badger Are you running sudo -U ebadger -n -

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399551#comment-16399551 ] Eric Yang commented on YARN-7221: - [~ebadger] Are you running sudo -U ebadger -n -l docker

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399493#comment-16399493 ] Eric Badger commented on YARN-7221: --- Hi [~eyang], I just tried out patch 006. I'm getting

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386373#comment-16386373 ] Eric Yang commented on YARN-7221: - Hi [~ebadger], can you give patch 006 a try? Thanks >

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384384#comment-16384384 ] genericqa commented on YARN-7221: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384339#comment-16384339 ] Eric Yang commented on YARN-7221: - - Fixed white space and unit test errors. > Add securit

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382846#comment-16382846 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372110#comment-16372110 ] Eric Yang commented on YARN-7221: - YARN-7654 will change the launcher script invocation to

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372089#comment-16372089 ] Eric Yang commented on YARN-7221: - [~ebadger] Patch 005 will pass string username instead o

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366395#comment-16366395 ] Eric Yang commented on YARN-7221: - [~ebadger] My apologies, I know the current patch isn't

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366240#comment-16366240 ] Eric Badger commented on YARN-7221: --- [~eyang], I meant how did you test your patch such t

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366224#comment-16366224 ] Eric Yang commented on YARN-7221: - [~ebadger], I tested with: {code:java} docker run -it --

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362741#comment-16362741 ] Eric Yang commented on YARN-7221: - [~ebadger] Thank you for the review. Our decision was t

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361138#comment-16361138 ] Eric Badger commented on YARN-7221: --- [~eyang], I'm not able to get this patch to work in

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355883#comment-16355883 ] Eric Yang commented on YARN-7221: - [~ebadger] Patch 004 is rebased to after YARN-7446. You

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355748#comment-16355748 ] Eric Badger commented on YARN-7221: --- Hey [~eyang], can you rebase this to trunk? Didn't a

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349474#comment-16349474 ] Eric Yang commented on YARN-7221: - The failed unit test is not related to this patch. > Ad

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349350#comment-16349350 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349262#comment-16349262 ] Eric Yang commented on YARN-7221: - Rebased patch to current trunk. > Add security check fo

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349080#comment-16349080 ] Shane Kumpf commented on YARN-7221: --- Sure. I agree that we need protections in place arou

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1634#comment-1634 ] Eric Yang commented on YARN-7221: - [~shaneku...@gmail.com] How about get this in, and commu

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348882#comment-16348882 ] Eric Badger commented on YARN-7221: --- bq. I'll just point out that In many organization th

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348544#comment-16348544 ] Shane Kumpf commented on YARN-7221: --- I'll just point out that In many organization the Ha

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348116#comment-16348116 ] Eric Yang commented on YARN-7221: - [~shaneku...@gmail.com] [~ebadger] Thanks for the review

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347215#comment-16347215 ] Eric Badger commented on YARN-7221: --- bq. I'm not a huge fan of relying on sudo to provide

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346940#comment-16346940 ] Shane Kumpf commented on YARN-7221: --- Thanks [~eyang]! Could we consider adding ACLs in YA

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345480#comment-16345480 ] genericqa commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345470#comment-16345470 ] Eric Badger commented on YARN-7221: --- [~eyang], can you rebase this patch to trunk? It doe

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324496#comment-16324496 ] Eric Badger commented on YARN-7221: --- Hi, [~eyang], I will review this when I get a chance

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324453#comment-16324453 ] Eric Yang commented on YARN-7221: - Can someone review this patch? Thanks > Add security c

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238030#comment-16238030 ] Hadoop QA commented on YARN-7221: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237026#comment-16237026 ] Hadoop QA commented on YARN-7221: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173881#comment-16173881 ] Eric Yang commented on YARN-7221: - [~chris.douglas] This is not a duplicate of YARN-6623.

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173864#comment-16173864 ] Chris Douglas commented on YARN-7221: - Is this a duplicate of YARN-6623? Or is it an ex

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172454#comment-16172454 ] Eric Badger commented on YARN-7221: --- Linking YARN-4266 as a blocker, since that is the JI