[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336770#comment-16336770 ] Hudson commented on YARN-7605: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13541 (See

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-23 Thread Billie Rinaldi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336755#comment-16336755 ] Billie Rinaldi commented on YARN-7605: -- Thanks for all the hard work writing and reviewing this patch,

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-23 Thread Billie Rinaldi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336729#comment-16336729 ] Billie Rinaldi commented on YARN-7605: -- +1 for patch 20. I will commit this now. > Implement doAs for

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-23 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336650#comment-16336650 ] Eric Yang commented on YARN-7605: - +1 Patch 20 looks good to me. > Implement doAs for Api Service REST API

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-23 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336527#comment-16336527 ] genericqa commented on YARN-7605: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-23 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336273#comment-16336273 ] Jian He commented on YARN-7605: --- new patch uploaded > Implement doAs for Api Service REST API >

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-23 Thread Billie Rinaldi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336268#comment-16336268 ] Billie Rinaldi commented on YARN-7605: -- Now that YARN-7766 is committed, we'll need a small change in

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-23 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336265#comment-16336265 ] Jian He commented on YARN-7605: --- sounds good, let me revert the doc > Implement doAs for Api Service REST

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-23 Thread Billie Rinaldi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336248#comment-16336248 ] Billie Rinaldi commented on YARN-7605: -- [~eyang] [~jianhe] I have done some testing of patch 019 and

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-22 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335394#comment-16335394 ] genericqa commented on YARN-7605: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-22 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335278#comment-16335278 ] Eric Yang commented on YARN-7605: - Fixed checkstyle issues, and findbug report issue, the rest of patch is

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-20 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1693#comment-1693 ] genericqa commented on YARN-7605: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-20 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1663#comment-1663 ] Jian He commented on YARN-7605: --- I combined this and YARN-7540 and rebased this on latest trunk and made some

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-17 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329854#comment-16329854 ] genericqa commented on YARN-7605: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-17 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329851#comment-16329851 ] Eric Yang commented on YARN-7605: - Found a bug in registry DNS security, it doesn't handle simple security,

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-11 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323382#comment-16323382 ] genericqa commented on YARN-7605: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-11 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322767#comment-16322767 ] Eric Yang commented on YARN-7605: - [~billie.rinaldi] Thank you for the input. I will revert the code to

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-11 Thread Billie Rinaldi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322749#comment-16322749 ] Billie Rinaldi commented on YARN-7605: -- bq. Back to the comment about getStatus structure, do you

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-09 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319511#comment-16319511 ] genericqa commented on YARN-7605: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-09 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319497#comment-16319497 ] Jian He commented on YARN-7605: --- ah, that is the issue, makes sense, thanks > Implement doAs for Api

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-09 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319487#comment-16319487 ] Eric Yang commented on YARN-7605: - [~jianhe] In the current trunk, the life time is set at [line

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-09 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319443#comment-16319443 ] Jian He commented on YARN-7605: --- bq. Life time remaining calculated from RM doesn't appear to be real time.

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-09 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319275#comment-16319275 ] Eric Yang commented on YARN-7605: - [~jianhe] Life time remaining calculated from RM doesn't appear to be

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-09 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319181#comment-16319181 ] Jian He commented on YARN-7605: --- bq. It appears that the application master stores the information to update

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-09 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318862#comment-16318862 ] Eric Yang commented on YARN-7605: - [~jianhe] If we don't load spec from HDFS, then the information shown

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-08 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317705#comment-16317705 ] Eric Yang commented on YARN-7605: - [~jianhe] {quote} IIUC, the code is load if app is not running. This can

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-08 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317647#comment-16317647 ] Jian He commented on YARN-7605: --- bq. I added a check to return EXIT_NOT_FOUND in actionDestroy, if the file

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-08 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317550#comment-16317550 ] Eric Yang commented on YARN-7605: - Patch failed due to revert of YARN-7540. Please commit YARN-7540 so

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-08 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317547#comment-16317547 ] genericqa commented on YARN-7605: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-08 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317538#comment-16317538 ] genericqa commented on YARN-7605: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-08 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317313#comment-16317313 ] Jian He commented on YARN-7605: --- - Previous comment: Here it still assumes if {{result \!= 0}} , it is

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-05 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314344#comment-16314344 ] genericqa commented on YARN-7605: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-05 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313746#comment-16313746 ] genericqa commented on YARN-7605: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-04 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312472#comment-16312472 ] genericqa commented on YARN-7605: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-03 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310526#comment-16310526 ] Jian He commented on YARN-7605: --- - the addInternalServlet has an unused parameter clazz > Implement doAs for

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2018-01-03 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310519#comment-16310519 ] Jian He commented on YARN-7605: --- - we can't assume if result != 0, it is ApplicationNotFoundException ? and

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2017-12-22 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301946#comment-16301946 ] genericqa commented on YARN-7605: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2017-12-21 Thread Gour Saha (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300954#comment-16300954 ] Gour Saha commented on YARN-7605: - -1 for this patch, since YARN-7540 breaks all basic Yarn Services

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2017-12-21 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300235#comment-16300235 ] Eric Yang commented on YARN-7605: - Hadoop common unit test failure is tracked in HADOOP-15128, and not

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2017-12-20 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299557#comment-16299557 ] genericqa commented on YARN-7605: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2017-12-20 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299025#comment-16299025 ] genericqa commented on YARN-7605: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2017-12-18 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296071#comment-16296071 ] Eric Yang commented on YARN-7605: - The unit test failure for hadoop-common is broken by HADOOP-10054.

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2017-12-18 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295774#comment-16295774 ] genericqa commented on YARN-7605: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2017-12-13 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290336#comment-16290336 ] genericqa commented on YARN-7605: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7605) Implement doAs for Api Service REST API

2017-12-13 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290315#comment-16290315 ] genericqa commented on YARN-7605: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||