[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321308#comment-16321308
]
Robert Kanter commented on YARN-7622:
-
+1 on the branch-2 patch
> Allow fair-scheduler configuration
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321002#comment-16321002
]
Greg Phillips commented on YARN-7622:
-
[~rkanter] The branch-2 patch remedies the import & lambda
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320474#comment-16320474
]
genericqa commented on YARN-7622:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312097#comment-16312097
]
genericqa commented on YARN-7622:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311811#comment-16311811
]
genericqa commented on YARN-7622:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310492#comment-16310492
]
Hudson commented on YARN-7622:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13446 (See
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310482#comment-16310482
]
Robert Kanter commented on YARN-7622:
-
Thanks [~gphillips] and [~wilfreds] for review. Committed to
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310459#comment-16310459
]
Robert Kanter commented on YARN-7622:
-
+1 LGTM
> Allow fair-scheduler configuration on HDFS
>
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310354#comment-16310354
]
genericqa commented on YARN-7622:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310224#comment-16310224
]
genericqa commented on YARN-7622:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310216#comment-16310216
]
Greg Phillips commented on YARN-7622:
-
[~rkanter] - s3 & viewfs have been added to allowed filesystems
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308849#comment-16308849
]
Robert Kanter commented on YARN-7622:
-
Overall looks good. Just one trivial comment:
- We should add
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297666#comment-16297666
]
Wilfred Spiegelenburg commented on YARN-7622:
-
thanks for all the work and working through the
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297038#comment-16297038
]
genericqa commented on YARN-7622:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296241#comment-16296241
]
Wilfred Spiegelenburg commented on YARN-7622:
-
Looking good now, thank you for the update.
Can
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296046#comment-16296046
]
genericqa commented on YARN-7622:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295920#comment-16295920
]
genericqa commented on YARN-7622:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291796#comment-16291796
]
Wilfred Spiegelenburg commented on YARN-7622:
-
Sorry for the delay in the review,
Using the
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288054#comment-16288054
]
genericqa commented on YARN-7622:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287060#comment-16287060
]
Wilfred Spiegelenburg commented on YARN-7622:
-
Thank you for the update.
You can not move the
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286331#comment-16286331
]
Greg Phillips commented on YARN-7622:
-
Thanks for the review [~wilfreds]. I moved the two mixed sync
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286194#comment-16286194
]
genericqa commented on YARN-7622:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285424#comment-16285424
]
Wilfred Spiegelenburg commented on YARN-7622:
-
Forgot to add: rest of the change looks good +1
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285423#comment-16285423
]
Wilfred Spiegelenburg commented on YARN-7622:
-
The findbugs message is correct. Not sure why it
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283810#comment-16283810
]
Greg Phillips commented on YARN-7622:
-
The failed unit test is unrelated, it is currently failing in
[
https://issues.apache.org/jira/browse/YARN-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282578#comment-16282578
]
genericqa commented on YARN-7622:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
26 matches
Mail list logo
