[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498637#comment-16498637
]
Hudson commented on YARN-7962:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14338 (See
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498276#comment-16498276
]
Billie Rinaldi commented on YARN-7962:
--
Sounds good to me. Thanks, [~leftnoteasy]!
> Race Condition
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498246#comment-16498246
]
Wangda Tan commented on YARN-7962:
--
Thanks [~billie.rinaldi], to me, differences between ver.6 and ver.7
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498149#comment-16498149
]
genericqa commented on YARN-7962:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498013#comment-16498013
]
Billie Rinaldi commented on YARN-7962:
--
Patch 7 is the same as patch 3 without the serviceStart
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498004#comment-16498004
]
Billie Rinaldi commented on YARN-7962:
--
Ah, I see what Wilfred is saying now. I don't think the
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497368#comment-16497368
]
Wangda Tan commented on YARN-7962:
--
The failed tests happened in other JIRAs as well:
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497190#comment-16497190
]
genericqa commented on YARN-7962:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497022#comment-16497022
]
Wangda Tan commented on YARN-7962:
--
The attached patch looks good, +1. Thanks [~belugabehr].
I did some
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447673#comment-16447673
]
Wilfred Spiegelenburg commented on YARN-7962:
-
Sorry for the delay was caught up in other
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441037#comment-16441037
]
BELUGA BEHR commented on YARN-7962:
---
[~billie.rinaldi] [~wilfreds] Any additional concerns? Please
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430677#comment-16430677
]
Billie Rinaldi commented on YARN-7962:
--
[~wilfreds], any further comments about patch 3, given that
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425525#comment-16425525
]
BELUGA BEHR commented on YARN-7962:
---
[~wilfreds] {{try...finally}} is a best practice.
bq. It is
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425515#comment-16425515
]
Wilfred Spiegelenburg commented on YARN-7962:
-
Sorry I made a typo in my comment [~belugabehr]:
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424795#comment-16424795
]
genericqa commented on YARN-7962:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421096#comment-16421096
]
Wilfred Spiegelenburg commented on YARN-7962:
-
Thank you [~belugabehr] patch is looking better
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419830#comment-16419830
]
BELUGA BEHR commented on YARN-7962:
---
[~billie.rinaldi] Thank you for the assist! I have been on vacation
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416860#comment-16416860
]
genericqa commented on YARN-7962:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406375#comment-16406375
]
Billie Rinaldi commented on YARN-7962:
--
Hi [~belugabehr], thanks for working on this patch. The patch
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403559#comment-16403559
]
genericqa commented on YARN-7962:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403069#comment-16403069
]
Wilfred Spiegelenburg commented on YARN-7962:
-
I don't think this is a really a race condition
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402242#comment-16402242
]
BELUGA BEHR commented on YARN-7962:
---
[~wilfreds] Can you please provide thoughts on how to unit test a
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401513#comment-16401513
]
Wilfred Spiegelenburg commented on YARN-7962:
-
[~belugabehr] Thank you for logging this issue.
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377552#comment-16377552
]
BELUGA BEHR commented on YARN-7962:
---
Unit test failures appear to be unrelated.
> Race Condition When
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375133#comment-16375133
]
genericqa commented on YARN-7962:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374999#comment-16374999
]
BELUGA BEHR commented on YARN-7962:
---
Also tighten things up a little (make start and stop symmetrical)
[
https://issues.apache.org/jira/browse/YARN-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373587#comment-16373587
]
BELUGA BEHR commented on YARN-7962:
---
{quote}pool size = 0, active threads = 0, queued tasks = 0{quote}
27 matches
Mail list logo
