[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-12 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542329#comment-16542329 ] Robert Kanter commented on YARN-8518: - LGTM +1 I also ran the test myself to double c

[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542171#comment-16542171 ] Jim Brennan commented on YARN-8518: --- [~rkanter], can you please review this fix?   > t

[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541894#comment-16541894 ] Jim Brennan commented on YARN-8518: --- The unit test failure is not related to this change

[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-12 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541889#comment-16541889 ] genericqa commented on YARN-8518: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-12 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541883#comment-16541883 ] Jason Lowe commented on YARN-8518: -- Ah, right. I verified that running mvn test in the n

[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541878#comment-16541878 ] Jim Brennan commented on YARN-8518: --- I can confirm that it is running this test for pre-

[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-12 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541861#comment-16541861 ] Robert Kanter commented on YARN-8518: - The original commit was part of a security fix,

[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-12 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541832#comment-16541832 ] Jason Lowe commented on YARN-8518: -- It would also be good to understand why this wasn't c

[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-11 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540604#comment-16540604 ] Robert Kanter commented on YARN-8518: - That would be great [~Jim_Brennan], thanks! >

[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-11 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540597#comment-16540597 ] Jim Brennan commented on YARN-8518: --- [~rkanter], [~szegedim], let me know if you would l