[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752093#comment-16752093 ] Sunil Govindan commented on YARN-8914: -- I can see this as a new feature altogether. Hence lets keep

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752083#comment-16752083 ] Sunil Govindan commented on YARN-8914: -- Hi [~eyang] Is this patch or feature applicable in

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713219#comment-16713219 ] Hudson commented on YARN-8914: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15575 (See

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713206#comment-16713206 ] Eric Yang commented on YARN-8914: - Thank you [~akhilpb] for the contribution and review. Thank you

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713188#comment-16713188 ] Billie Rinaldi commented on YARN-8914: -- +1 for patch 9. Thanks for working on this, [~eyang] and

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713116#comment-16713116 ] Eric Yang commented on YARN-8914: - [~akhilpb] I see the clean up.  Patch 009 looks good to me.  +1 > Add

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712361#comment-16712361 ] Akhil PB commented on YARN-8914: [~eyang]  Please use the UI2 changes from patch 9. I have made it a bit

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712110#comment-16712110 ] Eric Yang commented on YARN-8914: - While developing for Service > Components > Component Instance view, I

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710533#comment-16710533 ] Akhil PB commented on YARN-8914: [~eyang] {quote}Serializer change seems not necessary, can you confirm?

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710441#comment-16710441 ] Eric Yang commented on YARN-8914: - [~akhilpb] Thanks for patch 9.  My version of patch 8 also works.  It

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709930#comment-16709930 ] Hadoop QA commented on YARN-8914: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709647#comment-16709647 ] Akhil PB commented on YARN-8914: [~eyang] Please let me know what are the steps to make the terminal work.

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709640#comment-16709640 ] Akhil PB commented on YARN-8914: [~eyang] Please find the v8 patch [^YARN-8914.008.patch] with latest UI2

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709633#comment-16709633 ] Hadoop QA commented on YARN-8914: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709477#comment-16709477 ] Eric Yang commented on YARN-8914: - [~akhilpb] Patch 008 fixes the issues 1-4 from your last comments.

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707522#comment-16707522 ] Eric Yang commented on YARN-8914: - [~akhilpb] Thanks for the input. {quote}The Terminal column in

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706715#comment-16706715 ] Akhil PB commented on YARN-8914: [~eyang] I have found a couple of issues. # The Terminal column in

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705031#comment-16705031 ] Eric Yang commented on YARN-8914: - [~akhilpb] I couldn't figure out how to access application.js's

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704966#comment-16704966 ] Akhil PB commented on YARN-8914: Hi [~eyang] I think its good to get username from userInfo object which

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703884#comment-16703884 ] Billie Rinaldi commented on YARN-8914: -- +1 for patch 7. I tested out this patch and it worked for me.

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702244#comment-16702244 ] Eric Yang commented on YARN-8914: - [~akhilpb] it sounds like development environment does not have cmake

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701624#comment-16701624 ] Akhil PB commented on YARN-8914: Hi [~eyang] Build failed in Apache Hadoop Common project with following

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700857#comment-16700857 ] Eric Yang commented on YARN-8914: - The failed unit test is not related to patch 007. [~akhilpb] Unit test

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700198#comment-16700198 ] Akhil PB commented on YARN-8914: Hi [~eyang], I am reviewing the patch. What are the steps to test the

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699775#comment-16699775 ] Hadoop QA commented on YARN-8914: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699514#comment-16699514 ] Eric Yang commented on YARN-8914: - [~billie.rinaldi] Patch 007 resolves LICENSE.txt and NOTICE.txt

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679093#comment-16679093 ] Hadoop QA commented on YARN-8914: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678592#comment-16678592 ] Eric Yang commented on YARN-8914: - Patch 006 added user.name query parameter for non-secure cluster. >

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671007#comment-16671007 ] Hadoop QA commented on YARN-8914: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668065#comment-16668065 ] Hadoop QA commented on YARN-8914: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667885#comment-16667885 ] Eric Yang commented on YARN-8914: - The failed unit tests were not related to this JIRA. They failed due

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665910#comment-16665910 ] Hadoop QA commented on YARN-8914: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665687#comment-16665687 ] Eric Yang commented on YARN-8914: - Patch 003 fixed, checkstyle, and white space issues. The failed unit

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664803#comment-16664803 ] Hadoop QA commented on YARN-8914: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664664#comment-16664664 ] Eric Yang commented on YARN-8914: - [~akhilpb] The add-on scripts are already minified. Some modules are

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664641#comment-16664641 ] Akhil PB commented on YARN-8914: [~eyang] Pls use minified js in addon/dist files along with map files.

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664436#comment-16664436 ] Eric Yang commented on YARN-8914: - [~akhilpb] I removed overlay.js for now because it can be implemented

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663963#comment-16663963 ] Eric Yang commented on YARN-8914: - [~akhilpb] Thank you for the review. I will remove js.map files, if

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663305#comment-16663305 ] Akhil PB commented on YARN-8914: [~eyang] Couple of comments. # Patch looks huge in size. Could we remove

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663169#comment-16663169 ] Hadoop QA commented on YARN-8914: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662960#comment-16662960 ] Eric Yang commented on YARN-8914: - Secure websocket and non-Kerberos mode still need refinement. > Add