[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752627#comment-16752627
]
Billie Rinaldi commented on YARN-9089:
--
[~sunilg] No, all the subtasks under YARN-8762 would need to
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752079#comment-16752079
]
Sunil Govindan commented on YARN-9089:
--
[~eyang] [~billie.rinaldi]
Is this patch applicable for
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721971#comment-16721971
]
Hudson commented on YARN-9089:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15614 (See
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721965#comment-16721965
]
Billie Rinaldi commented on YARN-9089:
--
+1 for patch 4. Thanks for the patch [~eyang] and for the
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721872#comment-16721872
]
Eric Yang commented on YARN-9089:
-
[~akhilpb] Thanks for the information and review.
> Add Terminal Link
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720941#comment-16720941
]
Akhil PB commented on YARN-9089:
[~eyang] patch 4 looks good to me.
{code}
var httpUrl =
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720510#comment-16720510
]
Hadoop QA commented on YARN-9089:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720476#comment-16720476
]
Eric Yang commented on YARN-9089:
-
[~akhilpb] Patch 004 includes your suggestions. What is the benefit of
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719827#comment-16719827
]
Akhil PB commented on YARN-9089:
Hi [~eyang], Could please add the following changes. I had missed those
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719520#comment-16719520
]
Hadoop QA commented on YARN-9089:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719479#comment-16719479
]
Eric Yang commented on YARN-9089:
-
[~akhilpb] Patch 3 contains fixed from your last comment. Please have
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718561#comment-16718561
]
Akhil PB commented on YARN-9089:
[~eyang] Couple of comments.
# We don't need {{termLink:
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718145#comment-16718145
]
Eric Yang commented on YARN-9089:
-
[~akhilpb] Please review patch 002. Thanks
> Add Terminal Link to
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717723#comment-16717723
]
Hadoop QA commented on YARN-9089:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717637#comment-16717637
]
Eric Yang commented on YARN-9089:
-
[~akhilpb] Thanks for the hints. Patch 002 is revised to inject node
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717395#comment-16717395
]
Akhil PB commented on YARN-9089:
[~eyang] Yes, It is the convention we are following to use initializers
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715796#comment-16715796
]
Eric Yang commented on YARN-9089:
-
[~akhilpb] Thank you for the review. Agree that models are not meant
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714309#comment-16714309
]
Akhil PB commented on YARN-9089:
[~eyang] We should not call ajax call in models. The calls should be made
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713478#comment-16713478
]
Eric Yang commented on YARN-9089:
-
[~akhilpb] Can you review this patch? Thanks
> Add Terminal Link to
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713468#comment-16713468
]
Hadoop QA commented on YARN-9089:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712191#comment-16712191
]
Eric Yang commented on YARN-9089:
-
I was able to find a shorter workaround without refactoring data that
21 matches
Mail list logo
