[jira] [Updated] (YARN-10147) FPGA plugin can't find the localized aocx file

2020-02-19 Thread Szilard Nemeth (Jira)


 [ 
https://issues.apache.org/jira/browse/YARN-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szilard Nemeth updated YARN-10147:
--
Fix Version/s: 3.3.0

> FPGA plugin can't find the localized aocx file
> --
>
> Key: YARN-10147
> URL: https://issues.apache.org/jira/browse/YARN-10147
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: nodemanager
>Reporter: Peter Bacsko
>Assignee: Peter Bacsko
>Priority: Major
> Fix For: 3.3.0
>
> Attachments: YARN-10147-001.patch, YARN-10147-002.patch, 
> YARN-10147-003.patch
>
>
> There's a bug in the FPGA plugin which is intended to find the localized 
> "aocx" file:
> {noformat}
> ...
> if (localizedResources != null) {
>   Optional aocxPath = localizedResources
>   .keySet()
>   .stream()
>   .filter(path -> matchesIpid(path, id))
>   .findFirst();
>   if (aocxPath.isPresent()) {
> ipFilePath = aocxPath.get().toUri().toString();
> LOG.debug("Found: " + ipFilePath);
>   }
> } else {
>   LOG.warn("Localized resource is null!");
> }
> return ipFilePath;
>   }
>   private boolean matchesIpid(Path p, String id) {
> return p.getName().toLowerCase().equals(id.toLowerCase())
> && p.getName().endsWith(".aocx");
>   }
> {noformat}
> The method {{matchesIpid()}} works incorrecty: the {{id}} argument is the 
> expected filename, but without the extension. Therefore the {{equals()}} 
> comparison will always be false.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Updated] (YARN-10147) FPGA plugin can't find the localized aocx file

2020-02-19 Thread Peter Bacsko (Jira)


 [ 
https://issues.apache.org/jira/browse/YARN-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Bacsko updated YARN-10147:

Attachment: YARN-10147-003.patch

> FPGA plugin can't find the localized aocx file
> --
>
> Key: YARN-10147
> URL: https://issues.apache.org/jira/browse/YARN-10147
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: nodemanager
>Reporter: Peter Bacsko
>Assignee: Peter Bacsko
>Priority: Major
> Attachments: YARN-10147-001.patch, YARN-10147-002.patch, 
> YARN-10147-003.patch
>
>
> There's a bug in the FPGA plugin which is intended to find the localized 
> "aocx" file:
> {noformat}
> ...
> if (localizedResources != null) {
>   Optional aocxPath = localizedResources
>   .keySet()
>   .stream()
>   .filter(path -> matchesIpid(path, id))
>   .findFirst();
>   if (aocxPath.isPresent()) {
> ipFilePath = aocxPath.get().toUri().toString();
> LOG.debug("Found: " + ipFilePath);
>   }
> } else {
>   LOG.warn("Localized resource is null!");
> }
> return ipFilePath;
>   }
>   private boolean matchesIpid(Path p, String id) {
> return p.getName().toLowerCase().equals(id.toLowerCase())
> && p.getName().endsWith(".aocx");
>   }
> {noformat}
> The method {{matchesIpid()}} works incorrecty: the {{id}} argument is the 
> expected filename, but without the extension. Therefore the {{equals()}} 
> comparison will always be false.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Updated] (YARN-10147) FPGA plugin can't find the localized aocx file

2020-02-18 Thread Peter Bacsko (Jira)


 [ 
https://issues.apache.org/jira/browse/YARN-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Bacsko updated YARN-10147:

Attachment: YARN-10147-002.patch

> FPGA plugin can't find the localized aocx file
> --
>
> Key: YARN-10147
> URL: https://issues.apache.org/jira/browse/YARN-10147
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: nodemanager
>Reporter: Peter Bacsko
>Assignee: Peter Bacsko
>Priority: Major
> Attachments: YARN-10147-001.patch, YARN-10147-002.patch
>
>
> There's a bug in the FPGA plugin which is intended to find the localized 
> "aocx" file:
> {noformat}
> ...
> if (localizedResources != null) {
>   Optional aocxPath = localizedResources
>   .keySet()
>   .stream()
>   .filter(path -> matchesIpid(path, id))
>   .findFirst();
>   if (aocxPath.isPresent()) {
> ipFilePath = aocxPath.get().toUri().toString();
> LOG.debug("Found: " + ipFilePath);
>   }
> } else {
>   LOG.warn("Localized resource is null!");
> }
> return ipFilePath;
>   }
>   private boolean matchesIpid(Path p, String id) {
> return p.getName().toLowerCase().equals(id.toLowerCase())
> && p.getName().endsWith(".aocx");
>   }
> {noformat}
> The method {{matchesIpid()}} works incorrecty: the {{id}} argument is the 
> expected filename, but without the extension. Therefore the {{equals()}} 
> comparison will always be false.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Updated] (YARN-10147) FPGA plugin can't find the localized aocx file

2020-02-18 Thread Peter Bacsko (Jira)


 [ 
https://issues.apache.org/jira/browse/YARN-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Bacsko updated YARN-10147:

Attachment: YARN-10147-001.patch

> FPGA plugin can't find the localized aocx file
> --
>
> Key: YARN-10147
> URL: https://issues.apache.org/jira/browse/YARN-10147
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: nodemanager
>Reporter: Peter Bacsko
>Assignee: Peter Bacsko
>Priority: Major
> Attachments: YARN-10147-001.patch
>
>
> There's a bug in the FPGA plugin which is intended to find the localized 
> "aocx" file:
> {noformat}
> ...
> if (localizedResources != null) {
>   Optional aocxPath = localizedResources
>   .keySet()
>   .stream()
>   .filter(path -> matchesIpid(path, id))
>   .findFirst();
>   if (aocxPath.isPresent()) {
> ipFilePath = aocxPath.get().toUri().toString();
> LOG.debug("Found: " + ipFilePath);
>   }
> } else {
>   LOG.warn("Localized resource is null!");
> }
> return ipFilePath;
>   }
>   private boolean matchesIpid(Path p, String id) {
> return p.getName().toLowerCase().equals(id.toLowerCase())
> && p.getName().endsWith(".aocx");
>   }
> {noformat}
> The method {{matchesIpid()}} works incorrecty: the {{id}} argument is the 
> expected filename, but without the extension. Therefore the {{equals()}} 
> comparison will always be false.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org