[jira] [Updated] (YARN-2988) Graph#save() may leak resource

[Tsuyoshi OZAWA (JIRA)]

 [ 
https://issues.apache.org/jira/browse/YARN-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsuyoshi OZAWA updated YARN-2988:
-
Target Version/s: 2.7.0
   Fix Version/s: 2.7.0
Hadoop Flags: Reviewed

> Graph#save() may leak resource
> --
>
> Key: YARN-2988
> URL: https://issues.apache.org/jira/browse/YARN-2988
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: YARN-2988-001.patch, YARN-2988-002.patch
>
>
> In 
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/Graph.java
>  :
> {code}
>   public void save(String filepath) throws IOException {
> OutputStreamWriter fout = new OutputStreamWriter(
> new FileOutputStream(filepath), Charset.forName("UTF-8"));
> fout.write(generateGraphViz());
> fout.close();
> {code}
> The close of fout should be enclosed in finally clause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (YARN-2988) Graph#save() may leak resource

[Ted Yu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/YARN-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated YARN-2988:
-
Attachment: YARN-2988-002.patch

How about this patch ?

> Graph#save() may leak resource
> --
>
> Key: YARN-2988
> URL: https://issues.apache.org/jira/browse/YARN-2988
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: YARN-2988-001.patch, YARN-2988-002.patch
>
>
> In 
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/Graph.java
>  :
> {code}
>   public void save(String filepath) throws IOException {
> OutputStreamWriter fout = new OutputStreamWriter(
> new FileOutputStream(filepath), Charset.forName("UTF-8"));
> fout.write(generateGraphViz());
> fout.close();
> {code}
> The close of fout should be enclosed in finally clause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (YARN-2988) Graph#save() may leak resource

[Ted Yu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/YARN-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated YARN-2988:
-
Attachment: YARN-2988-001.patch

> Graph#save() may leak resource
> --
>
> Key: YARN-2988
> URL: https://issues.apache.org/jira/browse/YARN-2988
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: YARN-2988-001.patch
>
>
> In 
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/Graph.java
>  :
> {code}
>   public void save(String filepath) throws IOException {
> OutputStreamWriter fout = new OutputStreamWriter(
> new FileOutputStream(filepath), Charset.forName("UTF-8"));
> fout.write(generateGraphViz());
> fout.close();
> {code}
> The close of fout should be enclosed in finally clause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)