[jira] [Updated] (YARN-3147) Clean up RM web proxy code

2015-02-05 Thread Steve Loughran (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated YARN-3147:
-
Attachment: YARN-3147-001.patch

Patch -001

* new ProxyUtils class contains code common across classes; 
* {{ProxyUtils.sendRedirect()}} generates the 302 exit code, redirect header 
and the error message; used in filter and servlet.
* Tests updated to handle use/checking of the extended redirection logic.
* adopt SLF4J everywhere
* Switch to {{ExitUtil}} for exit logic
* move to {{serviceStart()}}  {{serviceStop()}}; throw exceptions here without 
needing to wrap them.
* move to java 7 code ({{}} types; merged exception catching.

This does not do anything about handling new HTTP verbs. All it does is prepare 
for it by factoring the redirect logic to one place  updating the tests, along 
with general code cleanup.

 Clean up RM web proxy code 
 ---

 Key: YARN-3147
 URL: https://issues.apache.org/jira/browse/YARN-3147
 Project: Hadoop YARN
  Issue Type: Improvement
  Components: webapp
Affects Versions: 2.6.0
Reporter: Steve Loughran
Assignee: Steve Loughran
 Attachments: YARN-3147-001.patch


 YARN-2084 covers fixing up the RM proxy  filter for REST support.
 Before doing that, prepare for it by cleaning up the codebase: factoring out 
 the redirect logic into a single method, some minor reformatting, move to 
 SLF4J and Java7 code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YARN-3147) Clean up RM web proxy code

2015-02-05 Thread Steve Loughran (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated YARN-3147:
-
Attachment: YARN-3147-002.patch

Patch -002: Reinstate  the deleted method, add javadocs saying: leave this 
alone.

 Clean up RM web proxy code 
 ---

 Key: YARN-3147
 URL: https://issues.apache.org/jira/browse/YARN-3147
 Project: Hadoop YARN
  Issue Type: Improvement
  Components: webapp
Affects Versions: 2.6.0
Reporter: Steve Loughran
Assignee: Steve Loughran
 Attachments: YARN-3147-001.patch, YARN-3147-002.patch


 YARN-2084 covers fixing up the RM proxy  filter for REST support.
 Before doing that, prepare for it by cleaning up the codebase: factoring out 
 the redirect logic into a single method, some minor reformatting, move to 
 SLF4J and Java7 code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)