[jira] [Updated] (YARN-3393) Getting application(s) goes wrong when app finishes before starting the attempt

[Vinod Kumar Vavilapalli (JIRA)]

 [ 
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Kumar Vavilapalli updated YARN-3393:
--
Fix Version/s: 2.6.1

Pulled this into 2.6.1. The patch applied cleanly for the most part, had to 
make one change to not use the java-7 style exception handling.

Ran compilation and TestApplicationHistoryManagerOnTimelineStore before the 
push.

> Getting application(s) goes wrong when app finishes before starting the 
> attempt
> ---
>
> Key: YARN-3393
> URL: https://issues.apache.org/jira/browse/YARN-3393
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: timelineserver
>Reporter: Zhijie Shen
>Assignee: Zhijie Shen
>Priority: Critical
>  Labels: 2.6.1-candidate
> Fix For: 2.7.0, 2.6.1
>
> Attachments: YARN-3393.1.patch
>
>
> When generating app report in ApplicationHistoryManagerOnTimelineStore, it 
> checks if appAttempt == null.
> {code}
> ApplicationAttemptReport appAttempt = 
> getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
> if (appAttempt != null) {
>   app.appReport.setHost(appAttempt.getHost());
>   app.appReport.setRpcPort(appAttempt.getRpcPort());
>   app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
>   
> app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
> }
> {code}
> However, {{getApplicationAttempt}} doesn't return null but throws 
> ApplicationAttemptNotFoundException:
> {code}
> if (entity == null) {
>   throw new ApplicationAttemptNotFoundException(
>   "The entity for application attempt " + appAttemptId +
>   " doesn't exist in the timeline store");
> } else {
>   return convertToApplicationAttemptReport(entity);
> }
> {code}
> They code isn't coupled well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (YARN-3393) Getting application(s) goes wrong when app finishes before starting the attempt

[Vinod Kumar Vavilapalli (JIRA)]

 [ 
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Kumar Vavilapalli updated YARN-3393:
--
Labels: 2.6.1-candidate  (was: )

 Getting application(s) goes wrong when app finishes before starting the 
 attempt
 ---

 Key: YARN-3393
 URL: https://issues.apache.org/jira/browse/YARN-3393
 Project: Hadoop YARN
  Issue Type: Bug
  Components: timelineserver
Reporter: Zhijie Shen
Assignee: Zhijie Shen
Priority: Critical
  Labels: 2.6.1-candidate
 Fix For: 2.7.0

 Attachments: YARN-3393.1.patch


 When generating app report in ApplicationHistoryManagerOnTimelineStore, it 
 checks if appAttempt == null.
 {code}
 ApplicationAttemptReport appAttempt = 
 getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
 if (appAttempt != null) {
   app.appReport.setHost(appAttempt.getHost());
   app.appReport.setRpcPort(appAttempt.getRpcPort());
   app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
   
 app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
 }
 {code}
 However, {{getApplicationAttempt}} doesn't return null but throws 
 ApplicationAttemptNotFoundException:
 {code}
 if (entity == null) {
   throw new ApplicationAttemptNotFoundException(
   The entity for application attempt  + appAttemptId +
doesn't exist in the timeline store);
 } else {
   return convertToApplicationAttemptReport(entity);
 }
 {code}
 They code isn't coupled well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (YARN-3393) Getting application(s) goes wrong when app finishes before starting the attempt

[Zhijie Shen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhijie Shen updated YARN-3393:
--
Attachment: YARN-3393.1.patch

Create the patch to fix the problem

 Getting application(s) goes wrong when app finishes before starting the 
 attempt
 ---

 Key: YARN-3393
 URL: https://issues.apache.org/jira/browse/YARN-3393
 Project: Hadoop YARN
  Issue Type: Bug
  Components: timelineserver
Reporter: Zhijie Shen
Assignee: Zhijie Shen
Priority: Critical
 Attachments: YARN-3393.1.patch


 When generating app report in ApplicationHistoryManagerOnTimelineStore, it 
 checks if appAttempt == null.
 {code}
 ApplicationAttemptReport appAttempt = 
 getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
 if (appAttempt != null) {
   app.appReport.setHost(appAttempt.getHost());
   app.appReport.setRpcPort(appAttempt.getRpcPort());
   app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
   
 app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
 }
 {code}
 However, {{getApplicationAttempt}} doesn't return null but throws 
 ApplicationAttemptNotFoundException:
 {code}
 if (entity == null) {
   throw new ApplicationAttemptNotFoundException(
   The entity for application attempt  + appAttemptId +
doesn't exist in the timeline store);
 } else {
   return convertToApplicationAttemptReport(entity);
 }
 {code}
 They code isn't coupled well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)