[jira] [Updated] (YARN-357) App submission should not be synchronized

2014-09-03 Thread Allen Wittenauer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated YARN-357:
--
Fix Version/s: (was: 3.0.0)

> App submission should not be synchronized
> -
>
> Key: YARN-357
> URL: https://issues.apache.org/jira/browse/YARN-357
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 0.23.3, 3.0.0, 2.0.0-alpha
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Fix For: 2.0.3-alpha, 0.23.7
>
> Attachments: YARN-357.branch-23.patch, YARN-357.patch, 
> YARN-357.patch, YARN-357.txt
>
>
> MAPREDUCE-2953 fixed a race condition with querying of app status by making 
> {{RMClientService#submitApplication}} synchronously invoke 
> {{RMAppManager#submitApplication}}. However, the {{synchronized}} keyword was 
> also added to {{RMAppManager#submitApplication}} with the comment:
> bq. I made the submitApplication synchronized to keep it consistent with the 
> other routines in RMAppManager although I do not believe it needs it since 
> the rmapp datastructure is already a concurrentMap and I don't see anything 
> else that would be an issue.
> It's been observed that app submission latency is being unnecessarily 
> impacted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (YARN-357) App submission should not be synchronized

2013-02-06 Thread Daryn Sharp (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daryn Sharp updated YARN-357:
-

Attachment: YARN-357.branch-23.patch

For branch 23, change test to use {{ApplicationsStore}} instead of 
{{RMStateStore}}.

> App submission should not be synchronized
> -
>
> Key: YARN-357
> URL: https://issues.apache.org/jira/browse/YARN-357
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 0.23.3, 3.0.0, 2.0.0-alpha
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Attachments: YARN-357.branch-23.patch, YARN-357.patch, 
> YARN-357.patch, YARN-357.txt
>
>
> MAPREDUCE-2953 fixed a race condition with querying of app status by making 
> {{RMClientService#submitApplication}} synchronously invoke 
> {{RMAppManager#submitApplication}}. However, the {{synchronized}} keyword was 
> also added to {{RMAppManager#submitApplication}} with the comment:
> bq. I made the submitApplication synchronized to keep it consistent with the 
> other routines in RMAppManager although I do not believe it needs it since 
> the rmapp datastructure is already a concurrentMap and I don't see anything 
> else that would be an issue.
> It's been observed that app submission latency is being unnecessarily 
> impacted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-357) App submission should not be synchronized

2013-02-05 Thread Siddharth Seth (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Siddharth Seth updated YARN-357:


Attachment: YARN-357.txt

Pretty much the same patch, but with the mockito EventHandler replaced.
I'm +1 on the previous patch. Daryn, if you think this change to the unit test 
looks OK, please go ahead and commit it. Thanks

> App submission should not be synchronized
> -
>
> Key: YARN-357
> URL: https://issues.apache.org/jira/browse/YARN-357
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 0.23.3, 3.0.0, 2.0.0-alpha
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Attachments: YARN-357.patch, YARN-357.patch, YARN-357.txt
>
>
> MAPREDUCE-2953 fixed a race condition with querying of app status by making 
> {{RMClientService#submitApplication}} synchronously invoke 
> {{RMAppManager#submitApplication}}. However, the {{synchronized}} keyword was 
> also added to {{RMAppManager#submitApplication}} with the comment:
> bq. I made the submitApplication synchronized to keep it consistent with the 
> other routines in RMAppManager although I do not believe it needs it since 
> the rmapp datastructure is already a concurrentMap and I don't see anything 
> else that would be an issue.
> It's been observed that app submission latency is being unnecessarily 
> impacted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-357) App submission should not be synchronized

2013-01-28 Thread Daryn Sharp (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daryn Sharp updated YARN-357:
-

Attachment: YARN-357.patch

Add tests that both better verify MAPREDUCE-2953 by ensuring 
{{ClientRMService}} is synchronously calling {{RMAppManager}}, but that 
{{RMAppManager}} is not synchronizing concurrent job submissions.

> App submission should not be synchronized
> -
>
> Key: YARN-357
> URL: https://issues.apache.org/jira/browse/YARN-357
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 0.23.3, 3.0.0, 2.0.0-alpha
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Attachments: YARN-357.patch, YARN-357.patch
>
>
> MAPREDUCE-2953 fixed a race condition with querying of app status by making 
> {{RMClientService#submitApplication}} synchronously invoke 
> {{RMAppManager#submitApplication}}. However, the {{synchronized}} keyword was 
> also added to {{RMAppManager#submitApplication}} with the comment:
> bq. I made the submitApplication synchronized to keep it consistent with the 
> other routines in RMAppManager although I do not believe it needs it since 
> the rmapp datastructure is already a concurrentMap and I don't see anything 
> else that would be an issue.
> It's been observed that app submission latency is being unnecessarily 
> impacted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-357) App submission should not be synchronized

2013-01-24 Thread Daryn Sharp (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daryn Sharp updated YARN-357:
-

Attachment: YARN-357.patch

Existing tests for MAPREDUCE-2953 demonstrate the race is fixed w/o 
synchronizing the method.

> App submission should not be synchronized
> -
>
> Key: YARN-357
> URL: https://issues.apache.org/jira/browse/YARN-357
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 0.23.3, 3.0.0, 2.0.0-alpha
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Attachments: YARN-357.patch
>
>
> MAPREDUCE-2953 fixed a race condition with querying of app status by making 
> {{RMClientService#submitApplication}} synchronously invoke 
> {{RMAppManager#submitApplication}}. However, the {{synchronized}} keyword was 
> also added to {{RMAppManager#submitApplication}} with the comment:
> bq. I made the submitApplication synchronized to keep it consistent with the 
> other routines in RMAppManager although I do not believe it needs it since 
> the rmapp datastructure is already a concurrentMap and I don't see anything 
> else that would be an issue.
> It's been observed that app submission latency is being unnecessarily 
> impacted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira