[jira] [Updated] (YARN-3780) Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition
[ https://issues.apache.org/jira/browse/YARN-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junping Du updated YARN-3780: - Fix Version/s: 2.8.0 > Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition > - > > Key: YARN-3780 > URL: https://issues.apache.org/jira/browse/YARN-3780 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Affects Versions: 2.7.0 >Reporter: zhihai xu >Assignee: zhihai xu >Priority: Minor > Fix For: 2.8.0, 2.7.2, 2.6.2, 3.0.0-alpha1 > > Attachments: YARN-3780.000.patch > > > Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition > to avoid unnecessary NodeResourceUpdateSchedulerEvent. > The current code use {{!=}} to compare Resource totalCapability, which will > compare reference not the real value in Resource. So we should use equals to > compare Resource. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-3780) Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition
[ https://issues.apache.org/jira/browse/YARN-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-3780: - Fix Version/s: (was: 2.8.0) 2.6.2 2.7.2 I committed this to branch-2.7 and branch-2.6 as well. > Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition > - > > Key: YARN-3780 > URL: https://issues.apache.org/jira/browse/YARN-3780 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Affects Versions: 2.7.0 >Reporter: zhihai xu >Assignee: zhihai xu >Priority: Minor > Fix For: 2.7.2, 2.6.2 > > Attachments: YARN-3780.000.patch > > > Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition > to avoid unnecessary NodeResourceUpdateSchedulerEvent. > The current code use {{!=}} to compare Resource totalCapability, which will > compare reference not the real value in Resource. So we should use equals to > compare Resource. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-3780) Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition
[ https://issues.apache.org/jira/browse/YARN-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj K updated YARN-3780: Hadoop Flags: Reviewed +1, Looks good to me, will commit it shortly. > Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition > - > > Key: YARN-3780 > URL: https://issues.apache.org/jira/browse/YARN-3780 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Affects Versions: 2.7.0 >Reporter: zhihai xu >Assignee: zhihai xu >Priority: Minor > Attachments: YARN-3780.000.patch > > > Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition > to avoid unnecessary NodeResourceUpdateSchedulerEvent. > The current code use {{!=}} to compare Resource totalCapability, which will > compare reference not the real value in Resource. So we should use equals to > compare Resource. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-3780) Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition
[ https://issues.apache.org/jira/browse/YARN-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhihai xu updated YARN-3780: Attachment: YARN-3780.000.patch > Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition > - > > Key: YARN-3780 > URL: https://issues.apache.org/jira/browse/YARN-3780 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Affects Versions: 2.7.0 >Reporter: zhihai xu >Assignee: zhihai xu >Priority: Minor > Attachments: YARN-3780.000.patch > > > Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition > to avoid unnecessary NodeResourceUpdateSchedulerEvent. > The current code use {{!=}} to compare Resource totalCapability, which will > compare reference not the real value in Resource. So we should use equals to > compare Resource. -- This message was sent by Atlassian JIRA (v6.3.4#6332)