[jira] [Updated] (YARN-3794) TestRMEmbeddedElector fails because of ambiguous LOG reference
[ https://issues.apache.org/jira/browse/YARN-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj K updated YARN-3794: Hadoop Flags: Reviewed +1, Looks good to me, will commit it shortly. YARN-3790 exists to track the TestWorkPreservingRMRestart failure. > TestRMEmbeddedElector fails because of ambiguous LOG reference > -- > > Key: YARN-3794 > URL: https://issues.apache.org/jira/browse/YARN-3794 > Project: Hadoop YARN > Issue Type: Bug > Components: test >Affects Versions: 2.7.0 >Reporter: Chengbing Liu >Assignee: Chengbing Liu > Attachments: YARN-3794.01.patch > > > After YARN-2921, {{MockRM}} has also a {{LOG}} field. Therefore {{LOG}} in > the following code snippet is ambiguous. > {code} > protected AdminService createAdminService() { > return new AdminService(MockRMWithElector.this, getRMContext()) { > @Override > protected EmbeddedElectorService createEmbeddedElectorService() { > return new EmbeddedElectorService(getRMContext()) { > @Override > public void becomeActive() throws > ServiceFailedException { > try { > callbackCalled.set(true); > LOG.info("Callback called. Sleeping now"); > Thread.sleep(delayMs); > LOG.info("Sleep done"); > } catch (InterruptedException e) { > e.printStackTrace(); > } > super.becomeActive(); > } > }; > } > }; > } > {code} > Eclipse gives the following error: > {quote} > The field LOG is defined in an inherited type and an enclosing scope > {quote} > IMO, we should fix this as {{TestRMEmbeddedElector.LOG}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-3794) TestRMEmbeddedElector fails because of ambiguous LOG reference
[ https://issues.apache.org/jira/browse/YARN-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengbing Liu updated YARN-3794: Attachment: YARN-3794.01.patch > TestRMEmbeddedElector fails because of ambiguous LOG reference > -- > > Key: YARN-3794 > URL: https://issues.apache.org/jira/browse/YARN-3794 > Project: Hadoop YARN > Issue Type: Bug > Components: test >Affects Versions: 2.7.0 >Reporter: Chengbing Liu >Assignee: Chengbing Liu > Attachments: YARN-3794.01.patch > > > After YARN-2921, {{MockRM}} has also a {{LOG}} field. Therefore {{LOG}} in > the following code snippet is ambiguous. > {code} > protected AdminService createAdminService() { > return new AdminService(MockRMWithElector.this, getRMContext()) { > @Override > protected EmbeddedElectorService createEmbeddedElectorService() { > return new EmbeddedElectorService(getRMContext()) { > @Override > public void becomeActive() throws > ServiceFailedException { > try { > callbackCalled.set(true); > LOG.info("Callback called. Sleeping now"); > Thread.sleep(delayMs); > LOG.info("Sleep done"); > } catch (InterruptedException e) { > e.printStackTrace(); > } > super.becomeActive(); > } > }; > } > }; > } > {code} > Eclipse gives the following error: > {quote} > The field LOG is defined in an inherited type and an enclosing scope > {quote} > IMO, we should fix this as {{TestRMEmbeddedElector.LOG}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)