[jira] [Updated] (YARN-4151) findbugs errors in hadoop-yarn-server-common module

2015-09-14 Thread MENG DING (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

MENG DING updated YARN-4151:

Attachment: YARN-4151.1.patch

Attaching the patch that addresses the findbugs warnings. Some of the warnings 
are introduced by YARN-4055 and YARN-3948

I am not really sure if we need to fix the following though. We may still want 
to keep the branch as is, as different scheduler pages may have different 
column definitions for the cluster page.
{code}
@@ -51,8 +51,7 @@ private static String getAppsTableColumnDefs(
 sb.append("[\n")
   .append("{'sType':'string', 'aTargets': [0]")
   .append(", 'mRender': parseHadoopID }")
-  .append("\n, {'sType':'numeric', 'aTargets': " +
-  (isFairSchedulerPage ? "[6, 7]": "[6, 7]"))
+  .append("\n, {'sType':'numeric', 'aTargets': [6, 7]")
   .append(", 'mRender': renderHadoopDate }")
   .append("\n, {'sType':'numeric', bSearchable:false, 'aTargets':");
 if (isFairSchedulerPage) {
{code}

> findbugs errors in hadoop-yarn-server-common module
> ---
>
> Key: YARN-4151
> URL: https://issues.apache.org/jira/browse/YARN-4151
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: MENG DING
>Assignee: MENG DING
> Attachments: YARN-4151.1.patch, findbugs.xml
>
>
> 7 findbugs warnings are found in hadoop-yarn-server-common module which needs 
> to be fixed:
> {code}
> [INFO]
> [INFO] --- findbugs-maven-plugin:3.0.0:findbugs (default-cli) @ 
> hadoop-yarn-server-common ---
> [INFO] Fork Value is true
>  [java] Warnings generated: 7
> [INFO] Done FindBugs Analysis
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YARN-4151) findbugs errors in hadoop-yarn-server-common module

2015-09-11 Thread MENG DING (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

MENG DING updated YARN-4151:

Attachment: findbugs.xml

Attaching the findbugs report.

> findbugs errors in hadoop-yarn-server-common module
> ---
>
> Key: YARN-4151
> URL: https://issues.apache.org/jira/browse/YARN-4151
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: MENG DING
>Assignee: MENG DING
> Attachments: findbugs.xml
>
>
> 7 findbugs warnings are found in hadoop-yarn-server-common module which needs 
> to be fixed:
> {code}
> [INFO]
> [INFO] --- findbugs-maven-plugin:3.0.0:findbugs (default-cli) @ 
> hadoop-yarn-server-common ---
> [INFO] Fork Value is true
>  [java] Warnings generated: 7
> [INFO] Done FindBugs Analysis
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)