Re: [yocto] does git SRC_URI really *require" a SRCREV setting?

2020-02-16 Thread Martin Jansa
ter > > > > *From:* yocto@lists.yoctoproject.org *On > Behalf Of *Martin Jansa > *Sent:* den 15 februari 2020 18:39 > *To:* Rudolf J Streif > *Cc:* rpj...@crashcourse.ca; Yocto discussion list > > *Subject:* Re: [yocto] does git SRC_URI really *require" a SRCREV setting

Re: [yocto] does git SRC_URI really *require" a SRCREV setting?

2020-02-16 Thread rpj...@crashcourse.ca
On Sun, 16 Feb 2020, Peter Kjellerstedt wrote: > We use tags in SRCREV for our own recipes since we have control over > them and know that the tags won’t move. If one sets BB_SRCREV_POLICY > = "cache", then bitbake will not do `git ls-remote` for the tags > more than once. So as long as you have

Re: [yocto] does git SRC_URI really *require" a SRCREV setting?

2020-02-16 Thread Peter Kjellerstedt
on list Subject: Re: [yocto] does git SRC_URI really *require" a SRCREV setting? Both recipes should be updated to use SRCREV like any other recipe, I'll send patch for that. The documentation should also mention that using tag names in SRCREV (or tag parameter) is not recommended,

Re: [yocto] does git SRC_URI really *require" a SRCREV setting?

2020-02-15 Thread rpj...@crashcourse.ca
On Sat, 15 Feb 2020, Martin Jansa wrote: > or not.. both were already > fixedhttp://git.openembedded.org/meta-openembedded/commit/?id=2f6c043c0c99ccf71f9eb9088adbe42972b9d8a0 > http://git.openembedded.org/meta-openembedded/commit/?id=f61d9b3fd32dede5f2ab2aabbf0a8fb9fa75dd98 whoops, my fault, i

Re: [yocto] does git SRC_URI really *require" a SRCREV setting?

2020-02-15 Thread Martin Jansa
or not.. both were already fixed http://git.openembedded.org/meta-openembedded/commit/?id=2f6c043c0c99ccf71f9eb9088adbe42972b9d8a0 http://git.openembedded.org/meta-openembedded/commit/?id=f61d9b3fd32dede5f2ab2aabbf0a8fb9fa75dd98 On Sat, Feb 15, 2020 at 6:38 PM Martin Jansa wrote: > Both recipes

Re: [yocto] does git SRC_URI really *require" a SRCREV setting?

2020-02-15 Thread Martin Jansa
Both recipes should be updated to use SRCREV like any other recipe, I'll send patch for that. The documentation should also mention that using tag names in SRCREV (or tag parameter) is not recommended, because tags can be moved and bitbake will always use "git ls-remote" to map the tag name to

Re: [yocto] does git SRC_URI really *require" a SRCREV setting?

2020-02-15 Thread rpj...@crashcourse.ca
On Sat, 15 Feb 2020, Rudolf J Streif wrote: > The wording might need improvement but both of your examples > actually do provide SRC_REV but in the inline form with SRC_URI > (rev/tag). > > The documentation should probably say something like SRC_REV needs > to be provided but it can either be

Re: [yocto] does git SRC_URI really *require" a SRCREV setting?

2020-02-15 Thread Rudolf J Streif
The wording might need improvement but both of your examples actually do provide SRC_REV but in the inline form with SRC_URI (rev/tag). The documentation should probably say something like SRC_REV needs to be provided but it can either be done by setting the variable explicitly or by using the

[yocto] does git SRC_URI really *require" a SRCREV setting?

2020-02-14 Thread rpj...@crashcourse.ca
yes, yes, more obsessive-compulsive nitpickery, but YP dev tasks manual, section 3.3.5, reads: "Another way of specifying source is from an SCM. For Git repositories, you must specify SRCREV and you should specify PV to include the revision with SRCPV." you *must* specify SRCREV? i don't