Re: [yocto] [meta-mingw] [PATCH 1/3] protobuf: static link tools when generating sdk

2021-08-17 Thread Joshua Watt


On 8/17/21 6:03 AM, Sinan Kaya wrote:

On 8/17/2021 6:26 AM, Khem Raj wrote:

 +EXTRA_OECONF:append:class-nativesdk = " --disable-shared"


This is not an inert change can it use some mingw specific override as well

Change is targeting meta-mingw repository. I looked at other files
in the repo to see what the pattern is.


All of the bbappends in meta-mingw should be using the :mingw32 override 
(or sdkmingw32 if it specific to just the SDK). If you found an example 
in the current code where that is not the case, it needs to be fixed. 
Either way, you need to use that override in your patches.



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#54435): https://lists.yoctoproject.org/g/yocto/message/54435
Mute This Topic: https://lists.yoctoproject.org/mt/84939073/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [yocto] [meta-mingw] [PATCH 1/3] protobuf: static link tools when generating sdk

2021-08-17 Thread Sinan Kaya
On 8/17/2021 6:26 AM, Khem Raj wrote:
> +EXTRA_OECONF:append:class-nativesdk = " --disable-shared"
> 
> 
> This is not an inert change can it use some mingw specific override as well 

Change is targeting meta-mingw repository. I looked at other files
in the repo to see what the pattern is.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#54432): https://lists.yoctoproject.org/g/yocto/message/54432
Mute This Topic: https://lists.yoctoproject.org/mt/84939073/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [yocto] [meta-mingw] [PATCH 1/3] protobuf: static link tools when generating sdk

2021-08-16 Thread Khem Raj
On Mon, Aug 16, 2021 at 6:36 PM Sinan Kaya  wrote:

> Dynamically linked protoc.exe is failing as follows:
>
> [libprotobuf ERROR google/protobuf/descriptor_database.cc:641]
> File already exists in database: google/protobuf/descriptor.proto
> [libprotobuf FATAL google/protobuf/descriptor.cc:1371] CHECK failed:
> GeneratedDatabase()->Add(encoded_file_descriptor, size):
>
> Switch to static linkage per upstream recommendation.
>
> Signed-off-by: Sinan Kaya 
> ---
>  recipes-devtools/protobuf/protobuf_%.bbappend | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 recipes-devtools/protobuf/protobuf_%.bbappend
>
> diff --git a/recipes-devtools/protobuf/protobuf_%.bbappend
> b/recipes-devtools/protobuf/protobuf_%.bbappend
> new file mode 100644
> index 000..7e62ff6
> --- /dev/null
> +++ b/recipes-devtools/protobuf/protobuf_%.bbappend
> @@ -0,0 +1 @@
> +EXTRA_OECONF:append:class-nativesdk = " --disable-shared"


This is not an inert change can it use some mingw specific override as well

>
> --
> 2.17.1
>
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#54426): https://lists.yoctoproject.org/g/yocto/message/54426
Mute This Topic: https://lists.yoctoproject.org/mt/84939073/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[yocto] [meta-mingw] [PATCH 1/3] protobuf: static link tools when generating sdk

2021-08-16 Thread Sinan Kaya
Dynamically linked protoc.exe is failing as follows:

[libprotobuf ERROR google/protobuf/descriptor_database.cc:641]
File already exists in database: google/protobuf/descriptor.proto
[libprotobuf FATAL google/protobuf/descriptor.cc:1371] CHECK failed:
GeneratedDatabase()->Add(encoded_file_descriptor, size):

Switch to static linkage per upstream recommendation.

Signed-off-by: Sinan Kaya 
---
 recipes-devtools/protobuf/protobuf_%.bbappend | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 recipes-devtools/protobuf/protobuf_%.bbappend

diff --git a/recipes-devtools/protobuf/protobuf_%.bbappend 
b/recipes-devtools/protobuf/protobuf_%.bbappend
new file mode 100644
index 000..7e62ff6
--- /dev/null
+++ b/recipes-devtools/protobuf/protobuf_%.bbappend
@@ -0,0 +1 @@
+EXTRA_OECONF:append:class-nativesdk = " --disable-shared"
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#54418): https://lists.yoctoproject.org/g/yocto/message/54418
Mute This Topic: https://lists.yoctoproject.org/mt/84939073/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-