Re: [yocto] [PATCH v3 1/3] recipes-multimedia: add Rockchip MPP library

2017-05-17 Thread Ayaka 


從我的 iPad 傳送

> Romain Perier  於 2017年5月17日 下午2:48 寫道：
> 
> Hello,
> 
> 
>> Le 16/05/2017 à 20:44, Trevor Woerner a écrit :
>> Randy,
>> 
>> Neither of the issues that were identified in your v2 of this patch were
>> addressed in this v3. Namely:
>> 
>> 1) please use your real name (first, last) in your signed-off-by line
>> 2) please don't create a package from this recipe whose name doesn't include
>>   the recipe name (i.e. please don't create "rockchip-vpu" from a recipe
>>   "rockchip-mpp"), suggestions were provided
It is a isolated library. I would suggest a new library named rockchip-mpp-vpu.
>> 
>> Aside from the email headers and the version of git used, this patch is
>> identical to the v2 you submitted.
>> 
>> Best regards,
>>Trevor
> +1
> 
> And please, include a changelog in your new version, at least in the
> cover letter, something like:
> 
> Changes in v3:
> - Item1 fixed
> - Item2 fixed
> 
> Changes in v2:
> - Item1 fixed
> - Item2 fixed
> 
> 
> Thanks,
> Romain

-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Re: [yocto] [PATCH v3 1/3] recipes-multimedia: add Rockchip MPP library

2017-05-17 Thread Romain Perier 
Hello,


Le 16/05/2017 à 20:44, Trevor Woerner a écrit :
> Randy,
>
> Neither of the issues that were identified in your v2 of this patch were
> addressed in this v3. Namely:
>
> 1) please use your real name (first, last) in your signed-off-by line
> 2) please don't create a package from this recipe whose name doesn't include
>the recipe name (i.e. please don't create "rockchip-vpu" from a recipe
>"rockchip-mpp"), suggestions were provided
>
> Aside from the email headers and the version of git used, this patch is
> identical to the v2 you submitted.
>
> Best regards,
>   Trevor
+1

And please, include a changelog in your new version, at least in the
cover letter, something like:

Changes in v3:
- Item1 fixed
- Item2 fixed

Changes in v2:
- Item1 fixed
- Item2 fixed


Thanks,
Romain
-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Re: [yocto] [PATCH v3 1/3] recipes-multimedia: add Rockchip MPP library

2017-05-16 Thread Trevor Woerner 
Randy,

Neither of the issues that were identified in your v2 of this patch were
addressed in this v3. Namely:

1) please use your real name (first, last) in your signed-off-by line
2) please don't create a package from this recipe whose name doesn't include
   the recipe name (i.e. please don't create "rockchip-vpu" from a recipe
   "rockchip-mpp"), suggestions were provided

Aside from the email headers and the version of git used, this patch is
identical to the v2 you submitted.

Best regards,
Trevor
-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

[yocto] [PATCH v3 1/3] recipes-multimedia: add Rockchip MPP library

2017-05-16 Thread ayaka 
MPP means Media Process Platform. The MPP is a middleware
for the other video encoder/decoder interface, translating
the video information into the hardware registers.

Signed-off-by: ayaka 
---
 recipes-multimedia/rockchip-mpp/rockchip-mpp.inc| 21 +
 .../rockchip-mpp/rockchip-mpp_20170412.bb   |  9 +
 recipes-multimedia/rockchip-mpp/rockchip-mpp_git.bb | 16 
 3 files changed, 46 insertions(+)
 create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp.inc
 create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp_20170412.bb
 create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp_git.bb

diff --git a/recipes-multimedia/rockchip-mpp/rockchip-mpp.inc 
b/recipes-multimedia/rockchip-mpp/rockchip-mpp.inc
new file mode 100644
index 000..6a45637
--- /dev/null
+++ b/recipes-multimedia/rockchip-mpp/rockchip-mpp.inc
@@ -0,0 +1,21 @@
+# Copyright (C) 2016 - 2017 Randy Li 
+# Released under the GNU GENERAL PUBLIC LICENSE Version 2
+# (see COPYING.GPLv2 for the terms)
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = 
"file://inc/rk_mpi.h;beginline=4;endline=14;md5=acbba394ae5639b0c786f60c1f48e3d6"
+
+inherit pkgconfig cmake
+
+EXTRA_OECMAKE = " \
+-DRKPLATFORM=ON   \
+-DHAVE_DRM=ON \
+"
+
+PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN} rockchip-vpu"
+FILES_rockchip-vpu = "${libdir}/lib*vpu${SOLIBS}"
+FILES_${PN} = "${libdir}/lib*mpp${SOLIBS}"
+FILES_${PN}-dev = "${libdir}/lib*${SOLIBSDEV} ${includedir} 
${libdir}/pkgconfig"
+SECTION_${PN}-dev = "devel"
+FILES_${PN}-staticdev = "${libdir}/*.a"
+SECTION_${PN}-staticdev = "devel"
diff --git a/recipes-multimedia/rockchip-mpp/rockchip-mpp_20170412.bb 
b/recipes-multimedia/rockchip-mpp/rockchip-mpp_20170412.bb
new file mode 100644
index 000..501306a
--- /dev/null
+++ b/recipes-multimedia/rockchip-mpp/rockchip-mpp_20170412.bb
@@ -0,0 +1,9 @@
+# Copyright (C) 2016 - 2017 Randy Li 
+# Released under the GNU GENERAL PUBLIC LICENSE Version 2
+# (see COPYING.GPLv2 for the terms)
+include rockchip-mpp.inc
+
+TAG = "release_${PV}"
+SRC_URI = "git://github.com/rockchip-linux/mpp.git;tag=${TAG};nobranch=1"
+
+S = "${WORKDIR}/git"
diff --git a/recipes-multimedia/rockchip-mpp/rockchip-mpp_git.bb 
b/recipes-multimedia/rockchip-mpp/rockchip-mpp_git.bb
new file mode 100644
index 000..23f3f15
--- /dev/null
+++ b/recipes-multimedia/rockchip-mpp/rockchip-mpp_git.bb
@@ -0,0 +1,16 @@
+# Copyright (C) 2016 - 2017 Randy Li 
+# Released under the GNU GENERAL PUBLIC LICENSE Version 2
+# (see COPYING.GPLv2 for the terms)
+
+DEFAULT_PREFERENCE = "-1"
+
+include rockchip-mpp.inc
+DEPENDS = "git-replacement-native"
+
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+FILESPATH_prepend := "${THISDIR}/${PN}:"
+
+SRCREV = "${AUTOREV}"
+SRC_URI = "git://github.com/rockchip-linux/mpp.git;branch=develop"
+
+S = "${WORKDIR}/git"
-- 
2.9.4

-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto