Re: [yocto] [layerindex-web] Add SPDX Identifier

[Paul Eggleton]

Hi Yann

On Wednesday, 23 October 2019 2:25:48 AM NZDT Yann CARDAILLAC wrote:
> On Mon, Oct 21, 2019 at 9:37 PM Paul Eggleton 
> wrote:
> > On Tuesday, 22 October 2019 4:15:03 AM NZDT Yann CARDAILLAC wrote:
> > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=13527
> > >
> > > I'm beginning the work of updating the layerindex-web repo, this one is a
> > > bit tricky, how should I treat the files generated using Django ?
> >
> > I believe the correct license for Django-derived files is BSD-3-Clause:
> >
> >   https://github.com/django/django/blob/master/LICENSE
> >
> > > I've yet to do html, txt and sh files, do you have any advices before I
> > > start?
> >
> > Note that some of the templates used for authentication originally came
> > from
> > here:
> >
> >   https://github.com/macdhuibh/django-registration-templates
> >
> > The LICENSE file indicates MIT for those though.
> >
> > The txt files are tricky because any stray newlines will affect
> > formatting. I would probably avoid touching them.
>
> I did not yet add MIT to html files, I don't really know if that makes
> sense or not?  I didn't do that because it seemed a bit weird to me, but I
> don't know what to think of that. Most of the time you'll find copyright on
> the footer of the page, but I'm not sure about Licensing those.
> 
> So here is a first iteration of the patch without htmls file licensed.

I think it's fine to add to the HTML as long as you add it as part of the 
Django template comment at the top and not in the actual text that gets 
rendered.

Looking over the license definitions they look fine, except the migrations - if 
these are considered derived from Django (which is fine) then they should all 
be BSD-3-Clause rather than some being MIT. It looks like some of the earlier 
ones don't have a "generated by django" comment, but they were all initially 
generated with ./manage.py makemigrations; some then had additional code added 
to them.

Cheers
Paul

-- 

Paul Eggleton
Intel System Software Products


-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Re: [yocto] [layerindex-web] Add SPDX Identifier

[Yann CARDAILLAC]

On Mon, Oct 21, 2019 at 9:37 PM Paul Eggleton 
wrote:

> On Tuesday, 22 October 2019 4:15:03 AM NZDT Yann CARDAILLAC wrote:
> > https://bugzilla.yoctoproject.org/show_bug.cgi?id=13527
> >
> > I'm beginning the work of updating the layerindex-web repo, this one is a
> > bit tricky, how should I treat the files generated using Django ?
>
> I believe the correct license for Django-derived files is BSD-3-Clause:
>
>   https://github.com/django/django/blob/master/LICENSE
>
> > I've yet to do html, txt and sh files, do you have any advices before I
> > start?
>
> Note that some of the templates used for authentication originally came
> from
> here:
>
>   https://github.com/macdhuibh/django-registration-templates
>
> The LICENSE file indicates MIT for those though.
>
> The txt files are tricky because any stray newlines will affect
> formatting. I
> would probably avoid touching them.
>
> I did not yet add MIT to html files, I don't really know if that makes
sense or not?  I didn't do that because it seemed a bit weird to me, but I
don't know what to think of that. Most of the time you'll find copyright on
the footer of the page, but I'm not sure about Licensing those.

So here is a first iteration of the patch without htmls file licensed.

Regards,

-- 
[image: SMILE] 

20 rue des Jardins
92600 Asnières-sur-Seine
*Yann CARDAILLAC*
Ingénieur Systèmes Embarqués

[image: email] yann.cardail...@smile.fr
[image: url] http://www.smile.eu

[image: Twitter]  [image: Facebook]
 [image: LinkedIn]
 [image: Github]



[image: eco] Pour la planète, n'imprimez ce mail que si c'est nécessaire
From e46cd0244aa8134318236a2f1aee96682e09715b Mon Sep 17 00:00:00 2001
From: Yann CARDAILLAC 
Date: Tue, 22 Oct 2019 15:17:21 +0200
Subject: [PATCH] add SPDX License identifier

Signed-off-by: Yann CARDAILLAC 
---
 __init__.py | 2 ++
 check_requirements.sh   | 1 +
 docker/connectivity_check.sh| 1 +
 docker/git-proxy| 1 +
 docker/migrate.sh   | 1 +
 docker/refreshlayers.sh | 1 +
 docker/settings.py  | 1 +
 docker/updatelayers.sh  | 1 +
 dockersetup.py  | 1 +
 layerindex/__init__.py  | 1 +
 layerindex/admin.py | 1 +
 layerindex/auth_forms.py| 1 +
 layerindex/auth_views.py| 1 +
 layerindex/bulkchange.py| 1 +
 layerindex/context_processors.py| 1 +
 layerindex/forms.py | 1 +
 layerindex/layerconfparse.py| 1 +
 layerindex/middleware.py| 1 +
 layerindex/migrations/0001_initial.py   | 1 +
 layerindex/migrations/0002_distro.py| 1 +
 layerindex/migrations/0003_auto_20161011_0304.py| 1 +
 layerindex/migrations/0004_layerdependency_required.py  | 1 +
 layerindex/migrations/0005_layerupdate.py   | 1 +
 layerindex/migrations/0006_change_branch_meta.py| 1 +
 layerindex/migrations/0007_layeritem_status_noupdate.py | 1 +
 layerindex/migrations/0008_yp_compatible.py | 1 +
 layerindex/migrations/0009_layerbranch_collection.py| 1 +
 layerindex/migrations/0010_add_dependencies.py  | 1 +
 layerindex/migrations/0011_source.py| 1 +
 layerindex/migrations/0012_layeritem_vcs_commit_url.py  | 1 +
 layerindex/migrations/0013_patch.py | 1 +
 layerindex/migrations/0014_sitenotice.py| 1 +
 layerindex/migrations/0015_comparison.py| 1 +
 layerindex/migrations/0016_classicrecipe_delete.py  | 1 +
 layerindex/migrations/0017_classicrecipe_needs_attention.py | 1 +
 layerindex/migrations/0018_layerrecipeextraurl.py   | 1 +
 layerindex/migrations/0019_layeritem_classic_comparison.py  | 1 +
 layerindex/migrations/0020_update_manual.py | 1 +
 layerindex/migrations/0021_layerupdate_add_layer_branch.py  | 1 +
 layerindex/migrations/0022_layerupdate_set_layer_branch.py  | 1 +
 layerindex/migrations/0023_layerupdate_layer_branch_finalise.py | 1 +
 layerindex/migrations/0024_layerupdate_vcs_revs.py  | 1 +
 layerindex/migrations/0025_update_re

Re: [yocto] [layerindex-web] Add SPDX Identifier

[Paul Eggleton]

Hi Yann

Thanks for looking into this.

On Tuesday, 22 October 2019 4:15:03 AM NZDT Yann CARDAILLAC wrote:
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=13527
> 
> I'm beginning the work of updating the layerindex-web repo, this one is a
> bit tricky, how should I treat the files generated using Django ?
> 
> *For now I've given them MIT as for the other hand written script. However
> I'm kind of worried that it's not the proper licence. *

I believe the correct license for Django-derived files is BSD-3-Clause:

  https://github.com/django/django/blob/master/LICENSE

> For the css side, I've added MIT to :
> 
> ./rrs/static/css/rrs-additional.css
> and
> ./layerindex/static/css/additional.css

That should be fine, those files were authored as part of the project.

> *I've let the bootstraps css untouched since I guess that's not for us to
> licence. *

Correct, and we'd be required to re-apply it every time we upgraded as well 
which is likely to get forgotten. You could always get them to add one 
upstream if you're really keen :)
 
> I've yet to do html, txt and sh files, do you have any advices before I
> start?

Note that some of the templates used for authentication originally came from 
here:

  https://github.com/macdhuibh/django-registration-templates

The LICENSE file indicates MIT for those though.

The txt files are tricky because any stray newlines will affect formatting. I 
would probably avoid touching them.

Cheers
Paul

-- 

Paul Eggleton
Intel System Software Products


-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

[yocto] [layerindex-web] Add SPDX Identifier

[Yann CARDAILLAC]

Hi,

https://bugzilla.yoctoproject.org/show_bug.cgi?id=13527

I'm beginning the work of updating the layerindex-web repo, this one is a
bit tricky, how should I treat the files generated using Django ?

*For now I've given them MIT as for the other hand written script. However
I'm kind of worried that it's not the proper licence. *

For the css side, I've added MIT to :

./rrs/static/css/rrs-additional.css
and
./layerindex/static/css/additional.css

*I've let the bootstraps css untouched since I guess that's not for us to
licence. *

I've yet to do html, txt and sh files, do you have any advices before I
start?

Regards,

-- 
[image: SMILE] 

20 rue des Jardins
92600 Asnières-sur-Seine
*Yann CARDAILLAC*
Ingénieur Systèmes Embarqués

[image: email] yann.cardail...@smile.fr
[image: url] http://www.smile.eu

[image: Twitter]  [image: Facebook]
 [image: LinkedIn]
 [image: Github]



[image: eco] Pour la planète, n'imprimez ce mail que si c'est nécessaire
-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto