Re: [yocto] [PATCH][yocto-autobuilder] nigthly-qa-*, nigthly-rpm*: Move RunSanityTests before SendErrorReport

2016-09-19 Thread Joshua Lock
On Sun, 2016-09-18 at 13:05 -0500, Aníbal Limón wrote:
> If RunSanityTests executes after SendErrorReport and fails, the error
> report was not send to the errors.yp.org server.

Pushed, thanks.

Joshua

> Signed-off-by: Aníbal Limón 
> ---
>  buildset-config.controller/nightly-qa-extras.conf   | 4 ++--
>  buildset-config.controller/nightly-qa-logrotate.conf| 6 ++
>  buildset-config.controller/nightly-qa-pam.conf  | 5 ++---
>  buildset-config.controller/nightly-qa-skeleton.conf | 5 ++---
>  buildset-config.controller/nightly-qa-systemd.conf  | 4 ++--
>  buildset-config.controller/nightly-qa-targetbuilds.conf | 6 +++---
>  buildset-config.controller/nightly-rpm-non-rpm.conf | 4 ++--
>  buildset-config.controller/nightly-rpm.conf | 4 ++--
>  8 files changed, 17 insertions(+), 21 deletions(-)
> 
> diff --git a/buildset-config.controller/nightly-qa-extras.conf
> b/buildset-config.controller/nightly-qa-extras.conf
> index 2ec7b50..f796bb1 100644
> --- a/buildset-config.controller/nightly-qa-extras.conf
> +++ b/buildset-config.controller/nightly-qa-extras.conf
> @@ -18,6 +18,6 @@ steps: [{'SetDest':{}},
>  'distro': 'poky', 'buildhistory' :
> False,
>  'atextappend' : '\nROOT_HOME =
> "/root"\n'}},
>  {'BuildImages': {'images': 'core-image-minimal'}},
> +{'RunSanityTests': {'images': 'core-image-minimal'}},
>  {'DownloadErrorReports': {}},
> -{'SendErrorReport': {}},
> -{'RunSanityTests': {'images': 'core-image-minimal'}}]
> +{'SendErrorReport': {}}]
> diff --git a/buildset-config.controller/nightly-qa-logrotate.conf
> b/buildset-config.controller/nightly-qa-logrotate.conf
> index 41dd135..1545509 100644
> --- a/buildset-config.controller/nightly-qa-logrotate.conf
> +++ b/buildset-config.controller/nightly-qa-logrotate.conf
> @@ -13,8 +13,6 @@ steps: [{'SetDest':{}},
>  'atextappend' : '\nIMAGE_INSTALL_append
> = " logrotate"\n'}},
>  {'CreateBBLayersConf': {'buildprovider' : 'yocto'}},
>  {'BuildImages': {'images': 'core-image-sato'}},
> +{'RunSanityTests': {'images': 'core-image-sato',
> 'suitesappend' : 'logrotate'}},
>  {'DownloadErrorReports': {}},
> -{'SendErrorReport': {}},
> -{'RunSanityTests': {'images': 'core-image-sato',
> 'suitesappend' : 'logrotate'}}]
> -
> -
> +{'SendErrorReport': {}}]
> diff --git a/buildset-config.controller/nightly-qa-pam.conf
> b/buildset-config.controller/nightly-qa-pam.conf
> index 5cec2c8..3fdb76f 100644
> --- a/buildset-config.controller/nightly-qa-pam.conf
> +++ b/buildset-config.controller/nightly-qa-pam.conf
> @@ -13,7 +13,6 @@ steps: [{'SetDest':{}},
>  'atextappend' :
> '\nDISTRO_FEATURES_append = " pam"\n'}},
>  {'CreateBBLayersConf': {'buildprovider' : 'yocto'}},
>  {'BuildImages': {'images': 'core-image-sato'}},
> +{'RunSanityTests': {'images': 'core-image-sato',
> 'suitesappend' : 'pam'}},
>  {'SendErrorReport': {}},
> -{'DownloadErrorReports': {}},
> -{'RunSanityTests': {'images': 'core-image-sato',
> 'suitesappend' : 'pam'}}]
> -
> +{'DownloadErrorReports': {}}]
> diff --git a/buildset-config.controller/nightly-qa-skeleton.conf
> b/buildset-config.controller/nightly-qa-skeleton.conf
> index c29ca7b..9ac4c5e 100644
> --- a/buildset-config.controller/nightly-qa-skeleton.conf
> +++ b/buildset-config.controller/nightly-qa-skeleton.conf
> @@ -13,7 +13,6 @@ steps: [{'SetDest':{}},
>  'atextappend' : '\nIMAGE_INSTALL_append
> = " service hello-mod"\n'}},
>  {'CreateBBLayersConf': {'buildprovider' : 'yocto',
> 'layerdirs': ['meta-skeleton']}},
>  {'BuildImages': {'images': 'core-image-sato'}},
> +{'RunSanityTests': {'images': 'core-image-sato',
> 'suitesappend' : 'skeletoninit'}},
>  {'DownloadErrorReports': {}},
> -{'SendErrorReport': {}},
> -{'RunSanityTests': {'images': 'core-image-sato',
> 'suitesappend' : 'skeletoninit'}}]
> -
> +{'SendErrorReport': {}}]
> diff --git a/buildset-config.controller/nightly-qa-systemd.conf
> b/buildset-config.controller/nightly-qa-systemd.conf
> index 662caa6..bb6da0b 100644
> --- a/buildset-config.controller/nightly-qa-systemd.conf
> +++ b/buildset-config.controller/nightly-qa-systemd.conf
> @@ -27,6 +27,6 @@ steps: [{'SetDest':{}},
>  'buildhistory' : False, 'distro':
> 'poky',
>  'initmgr' : 'systemd'}},
>  {'BuildImages': {'images': 'core-image-sato'}},
> +{'RunSanityTests': {'images': 'core-image-sato',
> 'suitesappend' : 'systemd'}},
>  {'DownloadErrorReports': {}},
> -{'SendErrorReport': {}},
> -{'RunSanityTests': {'images': 'core-image-sato',
> 'suitesappend' : 'systemd'}}]
> +{'SendErrorReport': {}}]
> diff --git a/buildset-config.c

[yocto] [PATCH][yocto-autobuilder] nigthly-qa-*, nigthly-rpm*: Move RunSanityTests before SendErrorReport

2016-09-18 Thread Aníbal Limón
If RunSanityTests executes after SendErrorReport and fails, the error
report was not send to the errors.yp.org server.

Signed-off-by: Aníbal Limón 
---
 buildset-config.controller/nightly-qa-extras.conf   | 4 ++--
 buildset-config.controller/nightly-qa-logrotate.conf| 6 ++
 buildset-config.controller/nightly-qa-pam.conf  | 5 ++---
 buildset-config.controller/nightly-qa-skeleton.conf | 5 ++---
 buildset-config.controller/nightly-qa-systemd.conf  | 4 ++--
 buildset-config.controller/nightly-qa-targetbuilds.conf | 6 +++---
 buildset-config.controller/nightly-rpm-non-rpm.conf | 4 ++--
 buildset-config.controller/nightly-rpm.conf | 4 ++--
 8 files changed, 17 insertions(+), 21 deletions(-)

diff --git a/buildset-config.controller/nightly-qa-extras.conf 
b/buildset-config.controller/nightly-qa-extras.conf
index 2ec7b50..f796bb1 100644
--- a/buildset-config.controller/nightly-qa-extras.conf
+++ b/buildset-config.controller/nightly-qa-extras.conf
@@ -18,6 +18,6 @@ steps: [{'SetDest':{}},
 'distro': 'poky', 'buildhistory' : False,
 'atextappend' : '\nROOT_HOME = "/root"\n'}},
 {'BuildImages': {'images': 'core-image-minimal'}},
+{'RunSanityTests': {'images': 'core-image-minimal'}},
 {'DownloadErrorReports': {}},
-{'SendErrorReport': {}},
-{'RunSanityTests': {'images': 'core-image-minimal'}}]
+{'SendErrorReport': {}}]
diff --git a/buildset-config.controller/nightly-qa-logrotate.conf 
b/buildset-config.controller/nightly-qa-logrotate.conf
index 41dd135..1545509 100644
--- a/buildset-config.controller/nightly-qa-logrotate.conf
+++ b/buildset-config.controller/nightly-qa-logrotate.conf
@@ -13,8 +13,6 @@ steps: [{'SetDest':{}},
 'atextappend' : '\nIMAGE_INSTALL_append = " 
logrotate"\n'}},
 {'CreateBBLayersConf': {'buildprovider' : 'yocto'}},
 {'BuildImages': {'images': 'core-image-sato'}},
+{'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 
'logrotate'}},
 {'DownloadErrorReports': {}},
-{'SendErrorReport': {}},
-{'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 
'logrotate'}}]
-
-
+{'SendErrorReport': {}}]
diff --git a/buildset-config.controller/nightly-qa-pam.conf 
b/buildset-config.controller/nightly-qa-pam.conf
index 5cec2c8..3fdb76f 100644
--- a/buildset-config.controller/nightly-qa-pam.conf
+++ b/buildset-config.controller/nightly-qa-pam.conf
@@ -13,7 +13,6 @@ steps: [{'SetDest':{}},
 'atextappend' : '\nDISTRO_FEATURES_append = " 
pam"\n'}},
 {'CreateBBLayersConf': {'buildprovider' : 'yocto'}},
 {'BuildImages': {'images': 'core-image-sato'}},
+{'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 
'pam'}},
 {'SendErrorReport': {}},
-{'DownloadErrorReports': {}},
-{'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 
'pam'}}]
-
+{'DownloadErrorReports': {}}]
diff --git a/buildset-config.controller/nightly-qa-skeleton.conf 
b/buildset-config.controller/nightly-qa-skeleton.conf
index c29ca7b..9ac4c5e 100644
--- a/buildset-config.controller/nightly-qa-skeleton.conf
+++ b/buildset-config.controller/nightly-qa-skeleton.conf
@@ -13,7 +13,6 @@ steps: [{'SetDest':{}},
 'atextappend' : '\nIMAGE_INSTALL_append = " 
service hello-mod"\n'}},
 {'CreateBBLayersConf': {'buildprovider' : 'yocto', 'layerdirs': 
['meta-skeleton']}},
 {'BuildImages': {'images': 'core-image-sato'}},
+{'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 
'skeletoninit'}},
 {'DownloadErrorReports': {}},
-{'SendErrorReport': {}},
-{'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 
'skeletoninit'}}]
-
+{'SendErrorReport': {}}]
diff --git a/buildset-config.controller/nightly-qa-systemd.conf 
b/buildset-config.controller/nightly-qa-systemd.conf
index 662caa6..bb6da0b 100644
--- a/buildset-config.controller/nightly-qa-systemd.conf
+++ b/buildset-config.controller/nightly-qa-systemd.conf
@@ -27,6 +27,6 @@ steps: [{'SetDest':{}},
 'buildhistory' : False, 'distro': 'poky',
 'initmgr' : 'systemd'}},
 {'BuildImages': {'images': 'core-image-sato'}},
+{'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 
'systemd'}},
 {'DownloadErrorReports': {}},
-{'SendErrorReport': {}},
-{'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 
'systemd'}}]
+{'SendErrorReport': {}}]
diff --git a/buildset-config.controller/nightly-qa-targetbuilds.conf 
b/buildset-config.controller/nightly-qa-targetbuilds.conf
index e31af26..c36f518 100644
--- a/buildset-config.controller/nightly-qa-targetbuilds.conf
+++ b/buildset-config.controller/nightly-qa-targetbuilds.conf
@@ -27,7 +27,7 @@ s