[Yum-devel] [PATCH 3/3] Use the urlgrabber's checksum as a hint argument to verifyLocalPkg()

2011-06-30 Thread Zdeněk Pavlas
--- yum/__init__.py |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/yum/__init__.py b/yum/__init__.py index 92f25d4..39b 100644 --- a/yum/__init__.py +++ b/yum/__init__.py @@ -1855,13 +1855,17 @@ class YumBase(depsolve.Depsolve): otherwise it returns f

Re: [Yum-devel] [PATCH 2/2] Add new urlgrabber option 'csum_type'.

2011-06-30 Thread James Antill
On Thu, 2011-06-30 at 19:07 +0200, Zdeněk Pavlas wrote: > When not 'None', urlgrabber checksums the downloaded files with specified > algorithm. This is cheaper than reopening the file later, esp. for large > ones. > hexdigest is then made available to the 'checkfunc'. Do you have any stats. on

[Yum-devel] [PATCH 2/3] Tell urlgrab() we'd like to know the checksum.

2011-06-30 Thread Zdeněk Pavlas
Seems that all we now use is 'sha256', and it's not going to change in near future. If this assumption proves wrong, the checksum is calculated again with "right" algo. --- yum/yumRepo.py |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/yum/yumRepo.py b/yum/yumRepo.py ind

[Yum-devel] [PATCH 1/3] Add arg 'hint' to YumAvailablePackage.verifyLocalPkg()

2011-06-30 Thread Zdeněk Pavlas
If we already know the local file checksum, verifyLocalPkg() does not have to calculate it again (unless it's wrong). --- yum/packages.py | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/yum/packages.py b/yum/packages.py index 5ef9951..d5de234 100644 --- a/yum/pac

[Yum-devel] [PATCH 2/2] Add new urlgrabber option 'csum_type'.

2011-06-30 Thread Zdeněk Pavlas
When not 'None', urlgrabber checksums the downloaded files with specified algorithm. This is cheaper than reopening the file later, esp. for large ones. hexdigest is then made available to the 'checkfunc'. --- urlgrabber/grabber.py | 16 1 files changed, 16 insertions(+), 0 del

[Yum-devel] [PATCH 1/2] Fix a typo in a docstring.

2011-06-30 Thread Zdeněk Pavlas
--- urlgrabber/grabber.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/urlgrabber/grabber.py b/urlgrabber/grabber.py index f6f57bd..8e5ea3f 100644 --- a/urlgrabber/grabber.py +++ b/urlgrabber/grabber.py @@ -969,7 +969,7 @@ class URLGrabber(object): """grab the

Re: [Yum-devel] [PATCH] Fix confusion from passing pkgtup as an nevra_dict. BZ 717973.

2011-06-30 Thread seth vidal
On Thu, 2011-06-30 at 12:06 -0400, James Antill wrote: > --- > yum/__init__.py | 14 -- > 1 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/yum/__init__.py b/yum/__init__.py > index 99039e0..e9bc1f9 100644 > --- a/yum/__init__.py > +++ b/yum/__init__.py > @@ -1242,13

[Yum-devel] [PATCH] Fix confusion from passing pkgtup as an nevra_dict. BZ 717973.

2011-06-30 Thread James Antill
--- yum/__init__.py | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/yum/__init__.py b/yum/__init__.py index 99039e0..e9bc1f9 100644 --- a/yum/__init__.py +++ b/yum/__init__.py @@ -1242,13 +1242,15 @@ class YumBase(depsolve.Depsolve): if None in pkgtup