> What's the "if 0" for?
It's just a (disabled) example how to make use of the new attributes.
May or may not go there as well, not sure.
> Apart from that, it looks fine.
Hmm, I just realized that MirrorGroup class supports failure_callback
that receives equally detailed information as well, an
> I think the idea behind both of these patches are ok, but I'm not 100%
> sure ... how much/what testing have you done?
Checked that 'yum clean all' + 'yum update' runs fine.
(downloads metalinks, repomds, and primary metadata).
This does not cover the _getFile() with url != None case,
in fact I
On Thu, 2011-09-08 at 12:06 +0200, Zdeněk Pavlas wrote:
> if url and scheme != "media":
> -ugopts = self._default_grabopts(cache=cache)
> -ug = URLGrabber(progress_obj = self.callback,
> -copy_local = copy_local,
> -
On Thu, 2011-09-15 at 14:52 +0200, Zdeněk Pavlas wrote:
>
> if __name__ == '__main__':
> -pass
> + if 0:
> +from urlgrabber import grabber, mirror
What's the "if 0" for?
Apart from that, it looks fine.
___
Yum-devel mailing list
Yum-devel@
URLGrabError(256) now includes attributes:
.url = relative url
.errors = list of mirrors' exceptions.
Note: This info was already passed to MG's failure_callback,
but processing that there would likely be hairy in yum.
---
urlgrabber/mirror.py | 25 +++--
1 files changed, 2
