Branch: refs/heads/znta-2247-find-glossary-columns
Home: https://github.com/zanata/zanata-platform
Commit: 80e841e84c7aab201aa03ecf19aa082bbc7d8a69
https://github.com/zanata/zanata-platform/commit/80e841e84c7aab201aa03ecf19aa082bbc7d8a69
Author: Damian Jansen <djan...@redhat.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M
common/zanata-adapter-glossary/src/main/java/org/zanata/adapter/glossary/GlossaryCSVReader.java
Log Message:
-----------
fix(ZNTA-2247): Remove magic numbers for glossary csv columns
Still expects column 0 to be the source locale, but checks that the
PoS and Description columns are named. This prevents garbage in
said fields.
This change also prevents repeatedly setting these fields, only
doing so once per row.
Commit: 271d61da2f517ee60a76cd9ed85a6f0b829d3571
https://github.com/zanata/zanata-platform/commit/271d61da2f517ee60a76cd9ed85a6f0b829d3571
Author: Damian Jansen <djan...@redhat.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M
common/zanata-adapter-glossary/src/main/java/org/zanata/adapter/glossary/GlossaryCSVReader.java
M
common/zanata-adapter-glossary/src/test/java/org/zanata/adapter/glossary/GlossaryCSVReaderTest.java
M common/zanata-adapter-glossary/src/test/resources/glossary/translate1.csv
M common/zanata-adapter-glossary/src/test/resources/glossary/translate2.csv
Log Message:
-----------
fix(ZNTA-2247): Allow several synonyms for data fields
Fix invalid test, contradicting the specified behaviour.
Compare:
https://github.com/zanata/zanata-platform/compare/6bdb5e990d48...271d61da2f51_______________________________________________
zanata-commits mailing list
zanata-commits@redhat.com
https://www.redhat.com/mailman/listinfo/zanata-commits
