Re: [zathura] [PATCH] synctex backwards syncronization

2012-07-13 Thread Roland Schatz
> One more think that just came to my mind: could you document -s and -x in > zathura.1.rst? A section on how to use synctex would be nice there as well. Ok. I'm not sure if I'll get to it this weekend, but I should have some time next week. That reminds me: I forgot to mention that the two new st

Re: [zathura] [PATCH] synctex backwards syncronization

2012-07-13 Thread Sebastian Ramacher
One more think that just came to my mind: could you document -s and -x in zathura.1.rst? A section on how to use synctex would be nice there as well. Cheers ___ zathura mailing list zathura@lists.pwmt.org http://lists.pwmt.org/mailman/listinfo/zathura

Re: [zathura] [PATCH] synctex backwards syncronization

2012-07-13 Thread Sebastian Ramacher
On 13/07/12 15:30, Roland Schatz wrote: > New patch is attached. Thanks. Commited and pushed. Regards ___ zathura mailing list zathura@lists.pwmt.org http://lists.pwmt.org/mailman/listinfo/zathura

Re: [zathura] [PATCH] synctex backwards syncronization

2012-07-13 Thread Roland Schatz
Hi, > * Could you please use g_strdup_printf instead of a fix sized buffer? > * For consistency with all the other parts in girara and zathura that spawn > process please use something like g_spawn_sync to execute synctex. No problem. I should really make myself familiar with glib, there are some q

Re: [zathura] [PATCH] synctex backwards syncronization

2012-07-13 Thread Sebastian Ramacher
Hi Roland, thanks for you work. The patch looks good so far. Just two minor remarks in synctex_edit: * Could you please use g_strdup_printf instead of a fix sized buffer? * For consistency with all the other parts in girara and zathura that spawn process please use something like g_spawn_sync to