Re: [zathura] [PATCH] Center pages

2014-01-20 Thread akbjker
From a first look at it, this leaks all old GtkAlignment instances on every page_widget_set_mode call. Whoops, you're right. I misunderstood the purpose of gtk_widget_reparent. Here's the patch v2. diff --git a/zathura.c b/zathura.c index 75aabc5..49a78b0 100644 --- a/zathura.c +++ b/zathura.c

Re: [zathura] [PATCH] Center pages

2014-01-20 Thread Sebastian Ramacher
On 2014-01-19 20:29:40, akbjker wrote: From a first look at it, this leaks all old GtkAlignment instances on every page_widget_set_mode call. Whoops, you're right. I misunderstood the purpose of gtk_widget_reparent. Here's the patch v2. Thank you. I've pushed it for now. We probably need