Re: [zathura] [Zathura PATCH v2] Replace the periodic page reclaiming code with a LRU caching algorithm.

2013-03-26 Thread Sebastian Ramacher
On 2013-03-26 05:50:22, Marwan Tanager wrote: > This patch implements a page cache that is invalidated in a LRU fashion. > > Pages are added to the cache as soon as they become visible. When the cache > is > full and a new page that isn't in the cache becomes visible, the least > recently > v

Re: [zathura] [Zathura PATCH v2] Replace the periodic page reclaiming code with a LRU caching algorithm.

2013-03-26 Thread Marwan Tanager
On Tue, Mar 26, 2013 at 01:04:29PM +0100, Sebastian Ramacher wrote: > On 2013-03-26 05:50:22, Marwan Tanager wrote: > > This patch implements a page cache that is invalidated in a LRU fashion. > > > > Pages are added to the cache as soon as they become visible. When the cache > > is > > full an

Re: [zathura] [Zathura PATCH v2] Replace the periodic page reclaiming code with a LRU caching algorithm.

2013-03-26 Thread Sebastian Ramacher
> > Thanks. I've applied it with an additional check if the user-specified page > > size is positive. (Just in case someone thinks -1 is a good cache size > > and the code would allocate an array of INT_MAX integers). > > Great! > > I think you meant the user-specified cache size, not page size.