Re: [zathura] [PATCH] Fix zathura's bisect

2013-07-06 Thread Sebastian Ramacher
Separating the bisection code a little bit more from the jump list is properly a code idea. I took the opportunity to rewrite it a little bit and came up with the attached patch. What do you think of it? * It moves some state to zathura_t: start and end denote the range that is bisected. last_

Re: [zathura] [PATCH] Fix zathura's bisect

2013-07-06 Thread Abdó Roig-Maranges
Hi, That looks quite good to me :) I attach a couple of patches changing some things, mainly simplifying the initial range setup. In detail: * added / fixed some comments * Simplified initial range setup. As we don't use the jumplist for state, we only need to look back one jump. I mean

Re: [zathura] [PATCH] Fix zathura's bisect

2013-07-06 Thread Moritz Lipp
On 2013-07-07 00:30:30, Marwan Tanager wrote: > On Sun, Jul 07, 2013 at 12:16:58AM +0200, Sebastian Ramacher wrote: > > Thanks, applied. Let's see how this works out. > > Bad news. I get a segfault once I start bisecting: Should be fixed with 2b6fa0cfe65bbc86995eb456215031c3aca1eaf7 Best regards